Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4184360ybz; Tue, 28 Apr 2020 07:08:58 -0700 (PDT) X-Google-Smtp-Source: APiQypLEc4vo2RyNjCPbCC2irU0malfIHc9gVQbK8xAySS7JNk1zNtwB4Sgt0wvTyuwU++wcVYCj X-Received: by 2002:aa7:c3c2:: with SMTP id l2mr22935488edr.362.1588082938547; Tue, 28 Apr 2020 07:08:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588082938; cv=none; d=google.com; s=arc-20160816; b=dJuWPhF5E9VCQE31tplDHZCz3Zncz8aB8kBT2Cm5E0ejtCm1SvGRxfB0HHYadYBweX HZpaqhp0JI29hC/+3mIVB7JeP3xNrd/1zXawjOHSIKGqaegoCbZa/2tMcXDPuEUJzjZk jKWL6DqAX+woL3omi8YeKZaXt/VUB+jsFFeg0huQvGYW0OE7nXyox4HTXdTo9UP1vqjq edH2/MbjexJ+vg/gBxzuQ+dssmf4lnR1BAwW6LJC9Nrx/S3Dxqi/SPQRBE6aTV/xkPBb cA6XsofDiKm97CHtknULdPkSC8GrBQTosG9C/ShD2ffUxYXxeV4SZGN7n3UZk30pobwM yNuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=r3hzm7yTEE9xqQrbBm8OOfDWzkr0IEj+zeX1Eo846UY=; b=Sk2/kmIhdhymndnXfYujjSn8s6WiKlWQlI9jVCxEvGi+IWK0N0P6y9C5GtQbMXoiXE IBx3rQG1khA3PZO+Q4rVfDvY3aNIGsbV6nvpE6pAMX+RyvYnILErNkjYnCsAyITmzaoZ criJE0ahrQ82OgttgpVtlBNILf5dghPZKFk/vYvH8Gi1aJZk6PhOFE8LUgAiWg1nkbvh c/AdqO7byBCnY7ZE/+u6tfI53f9uuiPq7rf8SnZEjc5p73XvhGIO+qtBy9P5hXmNM12M BxcUUnfGJVW3XNCBlHfpuo41Xd4amXADCzvhclW5+hz8XN5Ei5MyDDW5ai2+ZWmjC79w Urig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=p4OEQHwX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e5si1919429edc.160.2020.04.28.07.08.30; Tue, 28 Apr 2020 07:08:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=p4OEQHwX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727970AbgD1OFl (ORCPT + 99 others); Tue, 28 Apr 2020 10:05:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727110AbgD1OFl (ORCPT ); Tue, 28 Apr 2020 10:05:41 -0400 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF07CC03C1A9; Tue, 28 Apr 2020 07:05:40 -0700 (PDT) Received: by mail-lf1-x142.google.com with SMTP id m2so16978691lfo.6; Tue, 28 Apr 2020 07:05:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=r3hzm7yTEE9xqQrbBm8OOfDWzkr0IEj+zeX1Eo846UY=; b=p4OEQHwXTSirIiP6YEPENS2RQpq4t+1vw3fDD9fE9E8qcWtTcCZjEiliG02mYh8L94 Ywbew18Wx/pTNrgJ+iHkP5dxm6P9hnXERGOxdOLboqd3bVsAeMPPfDmhx/9sHfnt+4FR TEESang+PBYT9XsK31s2qaADmj/AtHch+sKPWBZm3AnGtBIgwYadBoNSVOsqG4GpuNWm Td/NDuBgeXQR3rdklugeFSOOfDo1Sa/LSfOniv818VlOnD8TxHpSK0/bETwCF0a+liRJ C0QxMCjnQIp6K07U1Qxed5S1lL+fJTnCz2dFKVL4R2Hx9NpJ8t83Ddf5qX9NH5EGIiwY 1f+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=r3hzm7yTEE9xqQrbBm8OOfDWzkr0IEj+zeX1Eo846UY=; b=rvQewAiAQQg29GHhXgGxX7iWhEyKPL5vK95a8av+TfPIbkGP9VI91V4qWVVKI8ZxWt 1q9TGd8Yyv9LcghToZDTL3e6gVSJfFvuc8wb4lNUq90mueYinWI+y/N/9zYTCP6I1GuZ wYh/VlWuv3XzpvTv594Dfgnq4rRas4hF7lFRRvxCZkGe7v4l/cauj9ukKKgZVOgWy+Ty /gRXm4Vi0+yVBqhT/zmznLoR3sMCjYIDXbzxQW50tsOgxlyPbRJpnpTJkcSMqVUCT+tt TJxArA4AtcZ9P8EXGy8HhgTCn5nKx3itWiRl1gTknNEXgVHP0vyNAT0XiWZVUNFuauNw LVZQ== X-Gm-Message-State: AGi0PuadPeqQ6Lq4QfUjXg/Q8Y67Qt/XdcCmJhJ+EcloQIxIb6Nyg1zt e9WxWSUh9GIi1PtP1jqB95ZhsEFE X-Received: by 2002:ac2:53a6:: with SMTP id j6mr19174715lfh.153.1588082736038; Tue, 28 Apr 2020 07:05:36 -0700 (PDT) Received: from [192.168.2.145] (ppp91-78-208-152.pppoe.mtu-net.ru. [91.78.208.152]) by smtp.googlemail.com with ESMTPSA id v7sm14124531lfq.55.2020.04.28.07.05.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2020 07:05:35 -0700 (PDT) Subject: Re: [RFC PATCH v1 3/5] media: tegra-video: Move PM runtime handle to streaming To: Sowjanya Komatineni , thierry.reding@gmail.com, jonathanh@nvidia.com, frankc@nvidia.com, hverkuil@xs4all.nl Cc: linux-media@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <1588047650-29402-1-git-send-email-skomatineni@nvidia.com> <1588047650-29402-4-git-send-email-skomatineni@nvidia.com> From: Dmitry Osipenko Message-ID: <4d069601-5507-dc8f-0cbc-acd8fd7324b3@gmail.com> Date: Tue, 28 Apr 2020 17:05:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <1588047650-29402-4-git-send-email-skomatineni@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 28.04.2020 07:20, Sowjanya Komatineni пишет: > + ret = csi->ops->csi_streaming(csi_chan, chan->pg_mode, enable); > > - return csi->ops->csi_streaming(csi_chan, chan->pg_mode, enable); > + if ((ret < 0 || !enable) && atomic_dec_and_test(&csi->clk_refcnt)) > + pm_runtime_put_sync(csi->dev); There shouldn't be a need to sync the RPM here, hence just pm_runtime_put(csi->dev). Same for the VI.