Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 28 Apr 2020 16:11:49 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Stefan Wahren <stefan.wahren@i2se.com>
Cc:     Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
        Eric Anholt <eric@anholt.net>,
        Tim Gover <tim.gover@raspberrypi.com>,
        Dave Stevenson <dave.stevenson@raspberrypi.com>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        bcm-kernel-feedback-list@broadcom.com,
        linux-rpi-kernel@lists.infradead.org,
        Phil Elwell <phil@raspberrypi.com>,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 91/91] ARM: dts: bcm2711: Enable the display pipeline
Message-ID: <20200428141149.22n24halgw3p3qa6@gilmour.lan>
References: <cover.d1e741d37e43e1ba2d2ecd93fc81d42a6df99d14.1587742492.git-series.maxime@cerno.tech>
 <7e7941611dad8106e5d9b03eeae06a6aefc0772c.1587742492.git-series.maxime@cerno.tech>
 <aba321ef-16fa-4f9b-a3a6-47b394daeac2@i2se.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="2uzyukowame55xt3"
Content-Disposition: inline
In-Reply-To: <aba321ef-16fa-4f9b-a3a6-47b394daeac2@i2se.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--2uzyukowame55xt3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Stefan,

On Sat, Apr 25, 2020 at 10:54:22PM +0200, Stefan Wahren wrote:
> Hi Maxime,
>=20
> Am 24.04.20 um 17:35 schrieb Maxime Ripard:
> > Now that all the drivers have been adjusted for it, let's bring in the
> > necessary device tree changes.
> >
> > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> > ---
> >  arch/arm/boot/dts/bcm2711-rpi-4-b.dts |  46 +++++++++++-
> >  arch/arm/boot/dts/bcm2711.dtsi        | 115 ++++++++++++++++++++++++++-
> >  2 files changed, 160 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/=
bcm2711-rpi-4-b.dts
> > index 3205d2dfa898..0efbc4412dc9 100644
> > --- a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
> > +++ b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
> > @@ -220,3 +220,49 @@
> >  &vchiq {
> >  	interrupts =3D <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>;
> >  };
> > +
> > +&vc4 {
> > +	status =3D "okay";
> > +};
> > +
> > +&pixelvalve0 {
> > +	status =3D "okay";
> > +};
> > +
> > +&pixelvalve1 {
> > +	status =3D "okay";
> > +};
> > +
> > +&pixelvalve2 {
> > +	status =3D "okay";
> > +};
> > +
> > +&pixelvalve3 {
> > +	status =3D "okay";
> > +};
> > +
> > +&pixelvalve4 {
> > +	status =3D "okay";
> > +};
> > +
> > +&hdmi0 {
> > +	clocks =3D <&firmware_clocks 13>, <&dvp 0>;
> > +	status =3D "okay";
> > +};
> > +
> > +&ddc0 {
> > +	status =3D "okay";
> > +};
> > +
> > +&hdmi1 {
> > +	clocks =3D <&firmware_clocks 13>, <&dvp 1>;
> > +	status =3D "okay";
> > +};
> > +
> > +&ddc1 {
> > +	status =3D "okay";
> > +};
> > +
> > +&hvs {
> > +	clocks =3D <&firmware_clocks 4>;
> > +};
> > diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711=
=2Edtsi
> > index 00bcaed1be32..a6549fa6e62b 100644
> > --- a/arch/arm/boot/dts/bcm2711.dtsi
> > +++ b/arch/arm/boot/dts/bcm2711.dtsi
> > @@ -12,6 +12,11 @@
> > =20
> >  	interrupt-parent =3D <&gicv2>;
> > =20
> ...
> > +
> > +		ddc0: i2c@7ef04500 {
> > +			compatible =3D "brcm,bcm2711-hdmi-i2c";
> > +			reg =3D <0x7ef04500 0x100>, <0x7ef00b00 0x300>;
> > +			reg-names =3D "bsc", "auto-i2c";
> > +			clock-frequency =3D <390000>;
>=20
> according to a patch [1] from Dave Stevenson the i2c clock frequencies
> are too high.
>=20
> [1] -
> https://github.com/raspberrypi/linux/pull/3515/commits/c09f108de27e8bd199=
5e7713c6128fa79e69579a

Good catch, I'll merge it in my next round of changes

Maxime

--2uzyukowame55xt3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXqg5pQAKCRDj7w1vZxhR
xQ1LAP91xvr/EAIzvWK5E+bjOZazwPcp4DpONK5z9Xr2cRoGMgD/dGYehbr08g+i
YgQKRp6pnmAlE6W5yIlpR5WwrJ2vSwQ=
=6BJB
-----END PGP SIGNATURE-----

--2uzyukowame55xt3--