Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= <peron.clem@gmail.com>
To:     Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
        Rob Herring <robh+dt@kernel.org>
Cc:     linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        linux-sunxi <linux-sunxi@googlegroups.com>,
        =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= <peron.clem@gmail.com>,
        Piotr Oniszczuk <warpme@o2.pl>
Subject: [PATCH v2] arm64: dts: allwinner: h6: Use dummy regulator for Tanix TX6
Date:   Tue, 28 Apr 2020 16:26:29 +0200
Message-Id: <20200428142629.8950-1-peron.clem@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Tanix TX6 has a fixed regulator. As DVFS is instructed to change
voltage to meet OPP table, the DVFS is not working as expected.

Avoid to introduce a new dedicated OPP Table where voltage are
equals to the fixed regulator as it will only duplicate all the OPPs.
Instead remove the fixed regulator so the DVFS framework will create
dummy regulator and will have the same behavior.

Add some comments to explain this in the device-tree.

Reported-by: Piotr Oniszczuk <warpme@o2.pl>
Fixes: add1e27fb703 ("arm64: dts: allwinner: h6: Enable CPU opp tables for Tanix TX6")
Signed-off-by: Clément Péron <peron.clem@gmail.com>
---
 .../boot/dts/allwinner/sun50i-h6-tanix-tx6.dts | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
index be81330db14f..3e96fcb317ea 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
@@ -48,7 +48,15 @@
 };
 
 &cpu0 {
-	cpu-supply = <&reg_vdd_cpu_gpu>;
+	/*
+	 * Don't specify the CPU regulator, as it's a fixed
+	 * regulator DVFS will not work as it is intructed
+	 * to reach a voltage which can't be reached.
+	 * Not specifying a regulator will create a dummy
+	 * regulator allowing all OPPs.
+	 *
+	 * cpu-supply = <&reg_vdd_cpu_gpu>;
+	 */
 };
 
 &de {
@@ -68,7 +76,13 @@
 };
 
 &gpu {
-	mali-supply = <&reg_vdd_cpu_gpu>;
+	/*
+	 * Don't specify the GPU regulator, see comment
+	 * above for the CPU supply.
+	 *
+	 * mali-supply = <&reg_vdd_cpu_gpu>;
+	 */
+
 	status = "okay";
 };
 
-- 
2.20.1