Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Will Deacon <will@kernel.org>
To:     George Spelvin <lkml@SDF.ORG>
Cc:     catalin.marinas@arm.com, Will Deacon <will@kernel.org>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        lkml@sdf.org, Hsin-Yi Wang <hsinyi@chromium.org>
Subject: Re: [PATCH v2] arm64: kexec_file: Avoid temp buffer for RNG seed
Date:   Tue, 28 Apr 2020 15:49:39 +0100
Message-Id: <158807855142.208424.6865350866606582490.b4-ty@kernel.org>
In-Reply-To: <20200330173801.GA9199@SDF.ORG>
References: <202003281643.02SGhMtr029198@sdf.org> <20200330133701.GA10633@willie-the-truck> <20200330173801.GA9199@SDF.ORG>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 30 Mar 2020 17:38:01 +0000, George Spelvin wrote:
> After using get_random_bytes(), you want to wipe the buffer
> afterward so the seed remains secret.
> 
> In this case, we can eliminate the temporary buffer entirely.
> fdt_setprop_placeholder() returns a pointer to the property value
> buffer, allowing us to put the random data directly in there without
> using a temporary buffer at all.  Faster and less stack all in one.

Applied to arm64 (for-next/misc), thanks!

[1/1] arm64: kexec_file: Avoid temp buffer for RNG seed
      https://git.kernel.org/arm64/c/99ee28d99607

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev