Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC PATCH v1 3/5] media: tegra-video: Move PM runtime handle to
 streaming
To:     Dmitry Osipenko <digetx@gmail.com>, <thierry.reding@gmail.com>,
        <jonathanh@nvidia.com>, <frankc@nvidia.com>, <hverkuil@xs4all.nl>
CC:     <linux-media@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <1588047650-29402-1-git-send-email-skomatineni@nvidia.com>
 <1588047650-29402-4-git-send-email-skomatineni@nvidia.com>
 <631390cb-9aff-0e3f-6c39-81d6c565987e@gmail.com>
From:   Sowjanya Komatineni <skomatineni@nvidia.com>
Message-ID: <3ef69413-a606-b475-f530-d5534760b73b@nvidia.com>
Date:   Tue, 28 Apr 2020 07:51:45 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <631390cb-9aff-0e3f-6c39-81d6c565987e@gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 4/28/20 6:59 AM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> 28.04.2020 07:20, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>> diff --git a/drivers/staging/media/tegra-video/csi.c b/drivers/staging/m=
edia/tegra-video/csi.c
>> index b3dd0c3..29ccdae 100644
>> --- a/drivers/staging/media/tegra-video/csi.c
>> +++ b/drivers/staging/media/tegra-video/csi.c
>> @@ -272,8 +272,25 @@ static int tegra_csi_s_stream(struct v4l2_subdev *s=
ubdev, int enable)
>>        struct tegra_vi_channel *chan =3D v4l2_get_subdev_hostdata(subdev=
);
>>        struct tegra_csi_channel *csi_chan =3D to_csi_chan(subdev);
>>        struct tegra_csi *csi =3D csi_chan->csi;
>> +     int ret;
>> +
>> +     if (enable && atomic_add_return(1, &csi->clk_refcnt) =3D=3D 1) {
>> +             ret =3D pm_runtime_get_sync(csi->dev);
>> +             if (ret < 0) {
>> +                     dev_err(csi->dev,
>> +                             "failed to get runtime PM: %d\n", ret);
>> +                     pm_runtime_put_noidle(csi->dev);
>> +                     atomic_dec(&csi->clk_refcnt);
>> +                     return ret;
>> +             }
>> +     }
>> +
>> +     ret =3D csi->ops->csi_streaming(csi_chan, chan->pg_mode, enable);
>>
>> -     return csi->ops->csi_streaming(csi_chan, chan->pg_mode, enable);
>> +     if ((ret < 0 || !enable) && atomic_dec_and_test(&csi->clk_refcnt))
>> +             pm_runtime_put_sync(csi->dev);
> Runtime PM maintains its own refcount, why these
> clk_refcnt/power_on_refcnt are needed?

Streaming is per channel and we can't turn power/clocks off while other=20
channels may still be running.