Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4237951ybz; Tue, 28 Apr 2020 08:00:41 -0700 (PDT) X-Google-Smtp-Source: APiQypIndLbkCTRCad/J3jH2BG5CDfHvvsZUWeXOMpGGGktOignDhM7NZ9ik6dpws0tbSW+SI5Un X-Received: by 2002:a05:6402:1611:: with SMTP id f17mr21560741edv.352.1588086040963; Tue, 28 Apr 2020 08:00:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588086040; cv=none; d=google.com; s=arc-20160816; b=HFmgnrcwc+vTXKtz0vTilSzxVnbXYVyY9z6vnthfT/4wlbsA7P6VNd7njEM6BeB+0S rO2yGq5q7eVJSOzy1SYHBng0+u5eGtxYrLu0PxQ4h636+y/5+wJ15sapXQexGwGgebhm mE/GsRSbljzRHJ4hbz0fWv43KwuE3arn/pzXj6WzSbILxRcNxf+pY9zq27c/L3ZjUOZ/ y7kHzhXz152JEq9BmmfLhnfAAAD0aQpVaWzoGOGLTHmlrK7H1zX3oEnZZl/8+4S0U6c5 cX2A/L08mgXf4WwWmGuXLL/60ZDmyR7vV4Ono0xUYF+4PbCsKW/poV5sM3wI05Ag73lj YW1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=FGBfBHVoUY7pobD26BhL9C2Ysg9iJ0hy1ZK8tU2IPi8=; b=yO7O0qPrL7dhurXI7NVgQIA8HHyzvtrK/ZMh3DaZm+82F7O9TrsP6tvzQm6HTm26qT MEjzweMASnFU6BYYECrR7m19pVNvPc5HEDlTMa0pHs3DtvaT98GKS5l4pnLFJ5smP8fN eFX6A4GpJiOgCuE56pqYyPIW9dAB1YyNz+UfqgapRICNYrOGiSUWQcIW8hq8DPQLE5qA 6kQysZ27NKHGRHKblPaWbpmG6aJ+sHu+nJ1nDMXp2v7YBcUHl7NTgs8AMBZWZZX5W4S6 avpRfm44zZV9gdMjqJ2PWA0YaR1lhBnFudgPW2NwAvRpl17APQmhWnPD6opDSmg05Qnb B1zw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o20si1840496edr.279.2020.04.28.08.00.16; Tue, 28 Apr 2020 08:00:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727992AbgD1O4v (ORCPT + 99 others); Tue, 28 Apr 2020 10:56:51 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:43662 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727108AbgD1O4v (ORCPT ); Tue, 28 Apr 2020 10:56:51 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 00C6994C8C1753763870; Tue, 28 Apr 2020 22:56:46 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.487.0; Tue, 28 Apr 2020 22:56:36 +0800 From: Wei Yongjun To: Santosh Shilimkar CC: Wei Yongjun , , , Subject: [PATCH -next] soc: ti: knav_qmss_queue: fix error return code in knav_queue_probe() Date: Tue, 28 Apr 2020 14:57:51 +0000 Message-ID: <20200428145751.97287-1-weiyongjun1@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix to return negative error code -ENODEV from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/soc/ti/knav_qmss_queue.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c index 37f3db6c041c..64339c9bb08e 100644 --- a/drivers/soc/ti/knav_qmss_queue.c +++ b/drivers/soc/ti/knav_qmss_queue.c @@ -1864,6 +1864,7 @@ static int knav_queue_probe(struct platform_device *pdev) regions = of_get_child_by_name(node, "descriptor-regions"); if (!regions) { dev_err(dev, "descriptor-regions not specified\n"); + ret = -ENODEV; goto err; } ret = knav_queue_setup_regions(kdev, regions);