Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4301320ybz; Tue, 28 Apr 2020 09:01:44 -0700 (PDT) X-Google-Smtp-Source: APiQypKCsmVWijgZ7izj5RJs4MN/Z3H7G7gYUSrDK1h/rnHZ19Br/9U03gn+oYXs99SMXFbc5w9t X-Received: by 2002:a17:906:6a48:: with SMTP id n8mr24457876ejs.315.1588089704264; Tue, 28 Apr 2020 09:01:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588089704; cv=none; d=google.com; s=arc-20160816; b=sWAblFqNfHgtfEBIBneNNMAeebk0+lre2PYV9Qv13HNSh6TUmCyMJsbferKyfY6HY8 Er1mKr7mIwkhp5D43cAA6axKD8gmHCZ0G5okvdi/HmL+RL/98hVrSeJJBErmSG3Fl5BZ Aps5Rx1OscOWHmft+Mc8uynk/jzAcVjrshbGE2CFKzGNhKi3HY8bSAW6lAUpSnKRD7z7 xDF/NChCJudGDFLlXG1jfiGY9LBpwKF5VIeHaaeTEvWUv023v6M08zd6sOV1SaXDe0Gz 8wUq1L/ed1abkBLZnCe2i9bAtEFU+ONuIVO7z4I0u84INgzguC4nyp0PwLPHaayh5HWs +I0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=JVm1MA1gXYM6WWZ2Gubj+tP7crxI13CEubHLmh3MUow=; b=JRiAdBhAtDyCSYnGJqCrzRulvUhvzNiBkXHHl4r0svWaua5Kv7hw/R06YgJk/5jl7z hAL0mddkwmhlo4PV2ADFs73Lwr2euPwEhyf3z53AltbX9ABUh8N3hnwJWuKWlaUUxmJK itZAK2UiFoPxkYBVK4KcysftLi0/LWI8uJOXaVSibgQsIhLK0U1Z74Z/FNLb3leRiH1R 0EfiBvpZmgw9IOB3LVrCWuTqjxyZX1QG5310h/KCV5556G3Iv1wG/HgtHT6cEtyeZlIE WJGoXJBTrY9o16S3R0I28y+n2FUa5fNKlxKksaYofqRrPOucoD/SHOI3CwsTn12gYQfI OXKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=FUfYbW3G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ay22si1819508edb.134.2020.04.28.09.01.16; Tue, 28 Apr 2020 09:01:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=FUfYbW3G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728323AbgD1P6u (ORCPT + 99 others); Tue, 28 Apr 2020 11:58:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:54826 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728172AbgD1P6t (ORCPT ); Tue, 28 Apr 2020 11:58:49 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 08D74206C0; Tue, 28 Apr 2020 15:58:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588089527; bh=qXrJ1X738mDatImKsjVwSd8Q17d8jVla98VKaBYOuR4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FUfYbW3GbJdy2X49J3YY7Qd2zXiDhOXFr2vX+KqhyXFF/aB6tldFv6Ygm/uDWhMzR zHLTBYQClEk5AnwX8f3FtfDJHzxrQePDL73NQz17IbAOAHKvormV6KCwuGJBvvb5Ok uSWckYHOlHmUOJ/bR/ou+63j64apAeMiwfsvJB1E= Date: Tue, 28 Apr 2020 17:58:45 +0200 From: "gregkh@linuxfoundation.org" To: "Stahl, Manuel" Cc: "hjk@linutronix.de" , "linux-kernel@vger.kernel.org" , "devel@driverdev.osuosl.org" , "sojkam1@fel.cvut.cz" Subject: Re: [PATCH v4] Add new uio device for PCI with dynamic memory allocation Message-ID: <20200428155845.GA1611284@kroah.com> References: <1507296707.2915.14.camel@iis-extern.fraunhofer.de> <20200416163830.30623-1-manuel.stahl@iis-extern.fraunhofer.de> <20200428135443.GA1437053@kroah.com> <6e93bbcb4ba85b4cc143aa8e3e7254071b3c8bdb.camel@iis-extern.fraunhofer.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6e93bbcb4ba85b4cc143aa8e3e7254071b3c8bdb.camel@iis-extern.fraunhofer.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 28, 2020 at 03:47:42PM +0000, Stahl, Manuel wrote: > > > > > + return err; > > > + } > > > + pci_set_master(pdev); > > > + > > > + dev_info(&pdev->dev, "Legacy IRQ: %i", pdev->irq); > > > > Again, remove, be quiet :) > > Use dev_dbg() or remove completely? If it helps in debugging, dev_dbg() is fine to use. thanks, greg k-h