Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4315879ybz; Tue, 28 Apr 2020 09:14:28 -0700 (PDT) X-Google-Smtp-Source: APiQypKSIvW9qMqo1Vn03Fq47aYGKdg1rq4HF50uq+Pk/wNruUYLmKKEqVQ7vPvW5yqn9Zz7Nx0B X-Received: by 2002:a17:906:ecb8:: with SMTP id qh24mr25058569ejb.299.1588090467851; Tue, 28 Apr 2020 09:14:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588090467; cv=none; d=google.com; s=arc-20160816; b=JN8wjhG8zpI/1pdwO527GeKYm7qC7Qn/KYsJ45CqbNMdxuo1Ux68MO5NapRBq79qEn iNsOTZNbalLPT6AKOMS7cN6CHDZrWaBlEh4MNTxxcgNIW8DO3JyJDiYKkozo5vHzITg6 p33zmBc8Czxyv4n7y2z/38f4i9nIaH38jDghOj6hmwz/A6qtAgnRfVYeWucAYekgyi7d VGLIajJWfS26WVJtKajKJ1YSbXAHq55GWVpqq5wzLR+A+3Jr67hh/jQeP+fXH6oooMVX JHqInjGvxt9VB5JCaWg7wdVy0yhF8pIgQGa3CfqpawpuitUB/jCq+h1gmH1OOkynhk53 BhJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:organization:user-agent :references:message-id:in-reply-to:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=ieqnaTI8M/OQ6Kp2GQW5apOzJgMfLAx79DHMWtQsWkc=; b=feNQxoiAUhF9T8gNEOeZsh9QaDHYc4GEcF2t0lst07fJllPFvw20rYqjM3WzQcvKOn z2PbMWip6t5u9q1Ifsz8+tfNKBeJiDaX+BOIiUun+Hdv0NqQeo++57EwPJIvsn32gU6l CH8RvJGR3vxCML3YALkADuaTXV1JDT2UpKwWWMLN5TPv+IBZs9VdxUYhYB4wDC0evO0T Op+Y3YDmvbn+doiaKfl+wy/m2VzNENb39G6pRYcN4+frNdfYS7f6jiTrgJ3EFlSw4XUV JP7qet938qzt71wkLLwA/AR97KI6vqTGNnfFEEGkAU9QiiIOiFUyktBL+wKk0j8/LGLO aBwg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gl22si1972340ejb.402.2020.04.28.09.14.04; Tue, 28 Apr 2020 09:14:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728506AbgD1QKQ (ORCPT + 99 others); Tue, 28 Apr 2020 12:10:16 -0400 Received: from mga14.intel.com ([192.55.52.115]:50645 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728486AbgD1QKO (ORCPT ); Tue, 28 Apr 2020 12:10:14 -0400 IronPort-SDR: hLlFpXLBOEjbmGCOv+tD32UeEqlQSaFnQ15YWyDMdxBGZeJAvziVNBUOz4fzlV0OFpvqI6nuv8 qR1HnhkJkSWg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2020 09:10:13 -0700 IronPort-SDR: PJnYM/U8UQgUK62EVq9UqV5NB7rQRuJewhYI2+iUE076l8LYuv0z+Ghz2odcmBuCfNG0/nKIZ3 XWZUmG4xMh1g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,328,1583222400"; d="scan'208";a="432233871" Received: from eliteleevi.tm.intel.com ([10.237.54.20]) by orsmga005.jf.intel.com with ESMTP; 28 Apr 2020 09:10:11 -0700 Date: Tue, 28 Apr 2020 19:10:10 +0300 (EEST) From: Kai Vehmanen X-X-Sender: kvehmane@eliteleevi.tm.intel.com To: ChenTao cc: Jaroslav Kysela , shawnguo@kernel.org, tiwai@suse.com, s.hauer@pengutronix.de, lgirdwood@gmail.co, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, festevam@gmail.com, linux-kernel@vger.kernel.org, daniel.baluta@nxp.com Subject: Re: [PATCH] soc: imx8m: Make imx8m_dsp_ops static In-Reply-To: <20200425080026.143127-1-chentao107@huawei.com> Message-ID: References: <20200425080026.143127-1-chentao107@huawei.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7 02160 Espoo MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, [+Daniel] On Sat, 25 Apr 2020, ChenTao wrote: > Fix the following warning: > > sound/soc/sof/imx/imx8m.c:95:20: warning: > symbol 'imx8m_dsp_ops' was not declared. Should it be static? yes, this was missed in the initial version of this driver. Ok to go with this: Acked-by: Kai Vehmanen You did not send a copy of the patch to Mark Brown (broonie@kernel.org). Can you resend with him in the loop, so he can pick the patch up to ALSA ASoC tree. Also please copy the ALSA list (alsa-devel@alsa-project.org). Br, Kai