Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4407660ybz; Tue, 28 Apr 2020 10:45:35 -0700 (PDT) X-Google-Smtp-Source: APiQypIYY2zGNXolg6ciUsfYFm21oZTxmmJfnyACqxQfD9BNVZ1gGMmDfZKOleG+o3Bgx0LhMyxt X-Received: by 2002:a50:cb84:: with SMTP id k4mr24412708edi.89.1588095934906; Tue, 28 Apr 2020 10:45:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588095934; cv=none; d=google.com; s=arc-20160816; b=SfmB+C/Nvfa0SfK46FX6VJ7dLNd5akJU6xv7TRkZqwW4KeIUUWrvKUuT5sObxJO13T AlKz/ixlyScXUGa70Lg1P6B5N7SsewsJ8vs/7Tiui7yeyTaM6P25GFQaRuE2kJm4mf9t 8O8eRblLFN8EiADrWZnESa9SHqKDM6AJOx/2yGweqQKtvojl1+8R+wGuAvln4McCtMdW C34YUSmIWnOUVBvm/7pANbXof4Sc2KZhmJOzjaxYENGJ/bMvdfbZL2Lpq4eYC5YEpjoE KE2CogJjPKkft291o9i+J0HY6ctCiwYr3aNfG1dNJorOsbQDs0uhNTizyjniqPUfnNd8 R0Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=IGiu43HMKFFPXvkdYpMi3N0FOwselucEcJEG/zdPDIw=; b=AXC53SfWiNCa31rHJYnvTOGWkrd7LIBMKN/7RG6yRnWof6tZW0RvyfbMcLSXuB5jx4 5WfHzomAVQ1uK8+j3mE/WqhEOz9eyEQj/vAET8NoyHMUghDjRGJXb6uO/ZxzlQVgzBTT LO87VYDJPLt1nG0DAiY6odqCZEphaO9gXu47Cwe6h6LJ5wDHQdNSmoMKW4fjhi7549lF r/u3hauWBMsBJ1nJigOiGoJjofkr1pcQweDFruhebtlF47XacR6prlmkrJdkqfnPoJt8 8InR1KAlysk7LOqeDoYe7lbWX8dfJ5FDTIPtHLpI4cYzOXO0oDLCU1NbJ/sWWdE9rQGP PvEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=EOGYYCPy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b24si1955287edr.338.2020.04.28.10.45.08; Tue, 28 Apr 2020 10:45:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=EOGYYCPy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728394AbgD1RnX (ORCPT + 99 others); Tue, 28 Apr 2020 13:43:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728313AbgD1RnX (ORCPT ); Tue, 28 Apr 2020 13:43:23 -0400 Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com [IPv6:2607:f8b0:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12078C03C1AB; Tue, 28 Apr 2020 10:43:23 -0700 (PDT) Received: by mail-ot1-x343.google.com with SMTP id z17so34191063oto.4; Tue, 28 Apr 2020 10:43:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IGiu43HMKFFPXvkdYpMi3N0FOwselucEcJEG/zdPDIw=; b=EOGYYCPyUxYi3CwmYRd2effYWgPrmBdgkKzFQluCdCfIoDXgQv6oAdWIhGySlV1fS5 AriuaRXQ2PM9DKWacyBl/OfZvf6iqhnsyUzj0q6kwFwwYfufsC92qV/w2X+AVWvsnDxl bpjvShQ9MWMQsVrFMJJasvD0wJ4DpcwO0JjGOYg2Q/3U8QGvjOdN9Jj+7ljO6/2+sK2d qInmQh6BczaDf9VFpRZXJdq3B/yoDfQ+cxZZsCAr5xyu439BHIMH4B7jOLLRnQek9zAj AJFZXERkGXaBSGIBlBJ7nyPkHz+W/gnn7DUYpasYgxF4okOup5kpqp6tnfNEV1r3V6OH 0Akg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IGiu43HMKFFPXvkdYpMi3N0FOwselucEcJEG/zdPDIw=; b=HLqUln7bbtY/XOocW0MlSbt7J6zL3FP6c+waWWjiWXBKUndGWNL0jBoMiy6ZukYo6q mGPTI7GvCjloY9fcQ+kP0euT+jUna2WzUh6Q/1JdNzZIbF1wmtKm1SmaOH3gmNZFCdZd UJppjL/cOeTMagpxPMYjEbdjGg7jhB04kNXkeQs/YOd6YnMoWIRzG+or4LZ1Fqmu9CPn iK+6dP3xlfzQM3PRjDS8mQLztkzlX+GSYallL9H1V9hwkKcaAAJcGfViyJPnBjodlXbM LjtoajjeufhNywd7hFyZQCZxS2y8fDRhseH98SOUNx84g3jbQ2QCNujO7EYzJHrCRH5e rBgA== X-Gm-Message-State: AGi0PuZGgnE5tJ/r+ujesexmYN1YEBpf0Ut8RETJj0fzVe6uGiejyaPZ /ekCw6JfZL68XH+8eornWSo= X-Received: by 2002:a05:6808:28b:: with SMTP id z11mr3803400oic.135.1588095802295; Tue, 28 Apr 2020 10:43:22 -0700 (PDT) Received: from localhost.localdomain ([2604:1380:4111:8b00::1]) by smtp.gmail.com with ESMTPSA id w24sm5134900oor.47.2020.04.28.10.43.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2020 10:43:21 -0700 (PDT) From: Nathan Chancellor To: Ioana Ciornei , Ioana Radulescu , "David S. Miller" Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Nathan Chancellor Subject: [PATCH] dpaa2-eth: Use proper division helper in dpaa2_dbg_ch_show Date: Tue, 28 Apr 2020 10:42:22 -0700 Message-Id: <20200428174221.2040849-1-natechancellor@gmail.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-Patchwork-Bot: notify Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When building arm32 allmodconfig: ERROR: modpost: "__aeabi_uldivmod" [drivers/net/ethernet/freescale/dpaa2/fsl-dpaa2-eth.ko] undefined! frames and cdan are both of type __u64 (unsigned long long) so we need to use div64_u64 to avoid this issues. Fixes: 460fd830dd9d ("dpaa2-eth: add channel stat to debugfs") Link: https://github.com/ClangBuiltLinux/linux/issues/1012 Signed-off-by: Nathan Chancellor --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debugfs.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debugfs.c index 80291afff3ea..0a31e4268dfb 100644 --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debugfs.c +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debugfs.c @@ -139,7 +139,7 @@ static int dpaa2_dbg_ch_show(struct seq_file *file, void *offset) ch->stats.dequeue_portal_busy, ch->stats.frames, ch->stats.cdan, - ch->stats.frames / ch->stats.cdan, + div64_u64(ch->stats.frames, ch->stats.cdan), ch->buf_count); } base-commit: 0fd02a5d3eb7020a7e1801f8d7f01891071c85e4 -- 2.26.2