Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4422231ybz; Tue, 28 Apr 2020 11:02:36 -0700 (PDT) X-Google-Smtp-Source: APiQypLON2kwgerxGqffzMNTnJOaMAKyS1ZxWXXrkcnnc96ClRFp8AbYA7F4Ng9Wjr12DKjLcunt X-Received: by 2002:a17:906:74c:: with SMTP id z12mr26570841ejb.87.1588096955873; Tue, 28 Apr 2020 11:02:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588096955; cv=none; d=google.com; s=arc-20160816; b=YlKGdK4qZfey7xjyJi1Xt7PyeUTfptnI0KY/GRZ49r4ia+VlEzOtCLCjWzei+W0FaN WUMDLLF3JrIFi9T6+wD3zZrXOGHRd87uQwExM5vZGv99lpTF8RWfhYDHsG7OtQOPFv1z ZqiGHF4qY/Rg7WtII7w3FA4snJS+cafZ12Pm8dnEdk/RrOE+IVBdQMWu37vWgh1tueRk IIV79MALZhdj4fIfhhlPnAbeKlBehE+8YPKLxBfhyvZD/cPrCcYpPC96ft3Jnh+uXAGA nb1jv4aIr0/JXqpZvuYN2kYyLXacr+VndCKpoY6kVPV7/LzTWD9V0SSifzJPVUiUswf/ g9NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=bMHDr+peVKNDWx4zqP+LW/B+GykIpmD+phvceywSp1w=; b=soIiYz3cS5+0II7Hli93gZpVdCQsnPe8HjVaR6Y7QU7jVwGT56Xr5I31nyn1yehvSm t1Yzf2LQvpQ5QMlld2IWGHYzX4lL9M9eOeTfCvVIInKTrKWTGKHvqXFZHDOti5n1sdlo NSs+wi7PDDFslVPp2VBPd6nOo1iQx8PqtjzYGWM2vAQlmrhhqb5SOMDDxar9eRJlulFo K2hPwJy/9a0ZKE52IPBlU1xLFSG+yiQWpULn4ki+FnczKMnvpj6uifyK7xF0cRZcrzv6 9o+h0ChXcWifh7JBRfcm9YGZr5WcNiW8zfDfx4mhcSUaD2fhDdnHHu3kqbfEyjcKXrWv cqkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=rkQ2Izzk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s7si2015463edh.266.2020.04.28.11.02.10; Tue, 28 Apr 2020 11:02:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=rkQ2Izzk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728610AbgD1R63 (ORCPT + 99 others); Tue, 28 Apr 2020 13:58:29 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:47288 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727827AbgD1R61 (ORCPT ); Tue, 28 Apr 2020 13:58:27 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 03SHrGHc156636; Tue, 28 Apr 2020 17:58:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=bMHDr+peVKNDWx4zqP+LW/B+GykIpmD+phvceywSp1w=; b=rkQ2IzzkF8PqzV2M1/XQEJNFSKjbV3RC61KpVOGXVMkUQG/RnY2Oa2AnAEDRSMaxfrKy vamxqO6OidRyrN9xSHAKUY37tuFSrKkiIway9FM71uCq3SEam5iXyUivWDGZjJ8T8Aly tnQXFHgvImDeZV87HFKx3xjtWXgo61nkoIcmN0pTIcp7bytTdQCCQ9csCuGmlp+llPLz nYxi5xcwLDzPfynQo3eVUpYbFLeZnSELK3QCB5Th8+PzHLcbupnSsAqjVzK/JV8TQ19q x77bId0TfcFhMX95sfsrercyf9kkcuZ5+lMrJVp4PbX7HazicSeOAoueqODzM6SEkCLq VA== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 30p2p06x0c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 28 Apr 2020 17:58:24 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 03SHw14j154893; Tue, 28 Apr 2020 17:58:23 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 30mxrt3krk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 28 Apr 2020 17:58:23 +0000 Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 03SHwLO4024934; Tue, 28 Apr 2020 17:58:21 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 28 Apr 2020 10:58:21 -0700 Date: Tue, 28 Apr 2020 20:58:14 +0300 From: Dan Carpenter To: Christophe JAILLET Cc: balbi@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] usb: phy: twl6030-usb: Fix a resource leak in an error handling path in 'twl6030_usb_probe()' Message-ID: <20200428175814.GI2014@kadam> References: <20200427202116.94380-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200427202116.94380-1-christophe.jaillet@wanadoo.fr> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9605 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 suspectscore=2 mlxlogscore=938 malwarescore=0 bulkscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004280143 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9605 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 clxscore=1015 bulkscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 mlxscore=0 suspectscore=2 mlxlogscore=993 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004280142 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 27, 2020 at 10:21:16PM +0200, Christophe JAILLET wrote: > A call to 'regulator_get()' is hidden in 'twl6030_usb_ldo_init()'. A > corresponding put must be performed in the error handling path, as > already done in the remove function. > > While at it, also move a 'free_irq()' call in the error handling path in > order to be consistent. > > Signed-off-by: Christophe JAILLET > --- > Maybe adding a 'twl6030_usb_ldo_uninit()' function would be more explicit. It would be nicer, yes, but probably this is fine too. Reviewed-by: Dan Carpenter regards, dan carpenter