Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4450443ybz; Tue, 28 Apr 2020 11:30:42 -0700 (PDT) X-Google-Smtp-Source: APiQypJF4kCIqDpYQh2ipc4fXV7VCSeFjyri39JzmAdvoLkydJotBd5Kk8ZRXImUfbKaBeTc5UA/ X-Received: by 2002:a17:906:f90e:: with SMTP id lc14mr25051787ejb.156.1588098642671; Tue, 28 Apr 2020 11:30:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588098642; cv=none; d=google.com; s=arc-20160816; b=MhAsOrefGwUZWYRKyco6bSXu6I4Cv7g7fYSD64WndZUyVgo59ZTNHGWoSLZEjgAEJv zf5xoYG+1k6NFi7ZUZ0V+H4pd+G9ggon3Q7XgyobeNHHZnTaIH52rk8aafxaQ+R2O3x1 yIwDSfJf2lojhkwLZdZ7E0+dCOAIOSM3j5wwUhsFsFW7H3MxlbWlMBRMpqr1RDCfj7Z/ Wn33sJ0RZlIxdN7tupOHL1sfGAnkMjxVpzOWvmAugNLafR0H0+ixCY+vSMJkg6mSZweY S//bQNRubHeR/BdUI/27WdxI2klBTyMNZAWHjWbWVr5YJaYdXVhaqS5p20FXAnj9fBLG Nvsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=fSqx9QqFFlyM5xqwgXeqQ+WdjXMOjDGY/j6ULRQqZKA=; b=VzlvkHEpskIlltUsOjchGFWPdSAoZg2YlC2FbpOl71vVnjt4Z5ABfuNtXRD8SFwvnY Yftfthp/ruOOVpaUQ6lhHol2bOBQLbUMNqPeeeX3hGmuv+3Lo+JWU/pms5W24SGvjrYc 2DDEuiSrmGfErFRJiVJSDwOaTx28u8Q0TMMsyoAdsUlk3c6O/ID0o83ADP9AkQH9bsqz AfT1p2WABUev8g8ShVXJdXGRbfsxt7gDXHf2Cy4heOw1//k5rzJKD5OknUsxRHWkO3r0 XDRjrkZRJYRVg/K8WsqV78pZorcBh3DOLzbxcQ/93hDWF8MdTvCpQBvuatIbP0rqqQ20 wftA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PCyNrPNG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j3si2368418ejv.401.2020.04.28.11.30.18; Tue, 28 Apr 2020 11:30:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PCyNrPNG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728771AbgD1S0f (ORCPT + 99 others); Tue, 28 Apr 2020 14:26:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:38088 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728766AbgD1S0d (ORCPT ); Tue, 28 Apr 2020 14:26:33 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7199520B1F; Tue, 28 Apr 2020 18:26:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588098392; bh=no3knKj15K/kqw5BYs/rcA1+Ow+Jsr8lPJT0094hSSg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PCyNrPNGQDUFSXqq8A4ARcX8W4/AuilgHbO4jjlrbtwu247nuNj7qStqcBM4u0kO2 EmPGVm5QDMqxlb4swYYEtRNqM4J3naaj7XEZscM1AHX9kTKWqcg7d+3Xh02LlZli6h HW6sK6ARkc/Q1SB1vprW3NYw5EwZWpRjIZDqhUmQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vasily Averin , Andrew Morton , Peter Oberparleiter , Al Viro , Davidlohr Bueso , Ingo Molnar , Manfred Spraul , NeilBrown , Steven Rostedt , Waiman Long , Linus Torvalds , Sasha Levin Subject: [PATCH 5.6 021/167] kernel/gcov/fs.c: gcov_seq_next() should increase position index Date: Tue, 28 Apr 2020 20:23:17 +0200 Message-Id: <20200428182227.835883934@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200428182225.451225420@linuxfoundation.org> References: <20200428182225.451225420@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vasily Averin [ Upstream commit f4d74ef6220c1eda0875da30457bef5c7111ab06 ] If seq_file .next function does not change position index, read after some lseek can generate unexpected output. https://bugzilla.kernel.org/show_bug.cgi?id=206283 Signed-off-by: Vasily Averin Signed-off-by: Andrew Morton Acked-by: Peter Oberparleiter Cc: Al Viro Cc: Davidlohr Bueso Cc: Ingo Molnar Cc: Manfred Spraul Cc: NeilBrown Cc: Steven Rostedt Cc: Waiman Long Link: http://lkml.kernel.org/r/f65c6ee7-bd00-f910-2f8a-37cc67e4ff88@virtuozzo.com Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- kernel/gcov/fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/gcov/fs.c b/kernel/gcov/fs.c index e5eb5ea7ea598..cc4ee482d3fba 100644 --- a/kernel/gcov/fs.c +++ b/kernel/gcov/fs.c @@ -108,9 +108,9 @@ static void *gcov_seq_next(struct seq_file *seq, void *data, loff_t *pos) { struct gcov_iterator *iter = data; + (*pos)++; if (gcov_iter_next(iter)) return NULL; - (*pos)++; return iter; } -- 2.20.1