Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4450957ybz; Tue, 28 Apr 2020 11:31:07 -0700 (PDT) X-Google-Smtp-Source: APiQypJAQepRG0knwxDplkTNnZ+TmZqRXqrNJOpfDhFpRsekleK+nB5l1XebKXBcwDaVuSO6Y4WQ X-Received: by 2002:a50:ea87:: with SMTP id d7mr17693027edo.48.1588098666831; Tue, 28 Apr 2020 11:31:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588098666; cv=none; d=google.com; s=arc-20160816; b=VrNK9esk/7I16Mpd1NkeXfr8ilwaj/aWonBp78rxnBepZZ2cB9S/+qOUfriF6XdGRR sydUM4gqwle0vXWF9vE0SM7Q/WubQW8chuc1hxTXu1NefAzVTWE8Na6yaALicMF9DviY ILn5w+W25Tz22x+yUTE3cCb3/AI1OYuTk082LWrZw87Mt37evh6xA/iZ8Pvwnh1xpaIT r91gjA0nL+Ca1gj6/UThqEBlRE3pSNRc2KWQBGCF4b5he4WVS+RKMKWgnv8RVlSFAvlj PyQAVGFrr8alFhamoF0PX9JyJFUq/k4peYmauN5peJ5CtROZu5q9swcTqIwab3KoonXT FYng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=zR98Rz3584QwqucqRUwsLlul0Io2vw8L0/J471l75oc=; b=hDEVUDF3t0U0QTGsNX3N6rKoiYKvKjXBHKkMxhKhg9ef6mSHrb39/Adg2GfzHqqor+ 7wLUQFJ9Ybl2gbezp6u+0mrQuELznNadrA0X34ujoSFkt5AUaovjaoRRPw97CU83tfnk lAk32/hvN7nSUirwvH8Ax5U1zFfJ+6d6dYdFgobpQkPyvjWe4zfpCPKzspmQWgdAWMZC wjs/3p1YskC394RJAtxsBsxAxpTnpnBOXPGZ7FTXBpQdzhXLAhDA2GDomvFzpMVuV/ye S03kgVOarKRb+TUhkkhJa1BcxLMtIouPv6o8zZ+ts/+VsTqrmz7MLMXjrYsIFpAHTd9o 6m2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TlgnK7gg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n8si2157316edt.33.2020.04.28.11.30.43; Tue, 28 Apr 2020 11:31:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TlgnK7gg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728615AbgD1S0t (ORCPT + 99 others); Tue, 28 Apr 2020 14:26:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:38460 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728813AbgD1S0p (ORCPT ); Tue, 28 Apr 2020 14:26:45 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4B657208E0; Tue, 28 Apr 2020 18:26:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588098404; bh=Yb0dT5Mf5FCK4nJCMD4GNxe6Lfw8RlG4lpvc3T+67PM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TlgnK7ggbDW/6WxDThMjoyCxtNvHxQKel5QPI1RUWUOz9jd3CJMkNEgow9LlTGpUC fD3sNZcFeoMoSU7qU3FafYLUuL/f47xfR6MG6MBwVNc8CPK4yr1DvGQScHNlI0DWEh +ewPvKL1q9DlL9WxgD4swJnAM5W+aqy0xKJ/4Rp4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christoph Hellwig , Jens Axboe , Sasha Levin Subject: [PATCH 5.6 026/167] block: fix busy device checking in blk_drop_partitions Date: Tue, 28 Apr 2020 20:23:22 +0200 Message-Id: <20200428182228.490342408@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200428182225.451225420@linuxfoundation.org> References: <20200428182225.451225420@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christoph Hellwig [ Upstream commit d3ef5536274faf89e626276b833be122a16bdb81 ] bd_super is only set by get_tree_bdev and mount_bdev, and thus not by other openers like btrfs or the XFS realtime and log devices, as well as block devices directly opened from user space. Check bd_openers instead. Fixes: 77032ca66f86 ("Return EBUSY from BLKRRPART for mounted whole-dev fs") Signed-off-by: Christoph Hellwig Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- block/partition-generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/partition-generic.c b/block/partition-generic.c index 564fae77711df..5f3b2a959aa51 100644 --- a/block/partition-generic.c +++ b/block/partition-generic.c @@ -468,7 +468,7 @@ int blk_drop_partitions(struct gendisk *disk, struct block_device *bdev) if (!disk_part_scan_enabled(disk)) return 0; - if (bdev->bd_part_count || bdev->bd_super) + if (bdev->bd_part_count || bdev->bd_openers) return -EBUSY; res = invalidate_partition(disk, 0); if (res) -- 2.20.1