Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4460316ybz; Tue, 28 Apr 2020 11:40:08 -0700 (PDT) X-Google-Smtp-Source: APiQypIkbO7XA9EVA1JX4UxsNLmk6vqZeXWL79t2WVORMleeeS736SifA1cmEhXW6BgXL8PRhPMB X-Received: by 2002:a17:906:5fd2:: with SMTP id k18mr25384534ejv.243.1588099208300; Tue, 28 Apr 2020 11:40:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588099208; cv=none; d=google.com; s=arc-20160816; b=h1Q4GsEOQRsJloikVMQ4rwNId6qvzazlOQyioBL4zvONRl+eFwX7hj3WRSnEz2BlYH SFRpqtrnvbuBOMsbWeONBVPmoNPNWmcecoOIrFw3XopUwHxYE2kFj5xqbOMQ9n+/6jY9 4C4d+71jZ5e1QkMFOhFp7wUPqgbp4pdST9fKiLHKV7QRZuFoBnKAiMxcqsIY2fJoxJf4 S9s3lRakGh3tl24jer0CaQXkfRK63VeXM56O09BJzcsKcO0xYZdx1iCG5M33oX9I34xA ThzphRMflFWx1DzJK3RjuKRwKXEXoDrcbQcfPHrpav9a1de1jKUimenn7l9CjC6tmMts 0BgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=fSqx9QqFFlyM5xqwgXeqQ+WdjXMOjDGY/j6ULRQqZKA=; b=JEtyII3Gki1htOr+1GHHZUF8soxRr/Q2L4Cf/ULll6lcgWuRdqV7EW259eQ6PtQeTW jQy9dA/77vKltyKR4/JUY8efGCbQlGr3xzjG0iQsGoU3YRnf4gWfLEVqUDNsLUmJ1lvp 0xKgQPnJLPoH5+6i6hLASIWDmoUHXLy7JpzE8geuHK0us6D6kYfMtA8wZxtzi5IiDe4Q ZQ5RBtDCAPkN0ifJyAM7k3go47D+rVgdkLbWUT93l53SZ2ZvIHy7b7371mqJ+nTaXfc+ RqAYijxw6ho6IsbW5JkxC5WpQYccB5+3J/EBdpYdNXbPR+yLEQgHUm0ZjK5XTwS1ZpBU UuOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=eVwnma7u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u26si2465222ejj.44.2020.04.28.11.39.44; Tue, 28 Apr 2020 11:40:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=eVwnma7u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730128AbgD1SeZ (ORCPT + 99 others); Tue, 28 Apr 2020 14:34:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:51066 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728773AbgD1SeW (ORCPT ); Tue, 28 Apr 2020 14:34:22 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 587F620B80; Tue, 28 Apr 2020 18:34:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588098861; bh=no3knKj15K/kqw5BYs/rcA1+Ow+Jsr8lPJT0094hSSg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eVwnma7udfIIoMsYuqFX7HoOkEExMeH/EZnGUEQvg3Vo/c0PR+C4qanritqoy0JTx /5kSCK4tCvQHxjgSFwg2GFRZIrY6Ah2IEsUKCzf+rhewcslU5I4wVygY3eK8S18H+d T4UKiXa+ThGL2n4RCrB1crr8yAaX+wrR36w/ouDM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vasily Averin , Andrew Morton , Peter Oberparleiter , Al Viro , Davidlohr Bueso , Ingo Molnar , Manfred Spraul , NeilBrown , Steven Rostedt , Waiman Long , Linus Torvalds , Sasha Levin Subject: [PATCH 5.4 024/168] kernel/gcov/fs.c: gcov_seq_next() should increase position index Date: Tue, 28 Apr 2020 20:23:18 +0200 Message-Id: <20200428182234.767115767@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200428182231.704304409@linuxfoundation.org> References: <20200428182231.704304409@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vasily Averin [ Upstream commit f4d74ef6220c1eda0875da30457bef5c7111ab06 ] If seq_file .next function does not change position index, read after some lseek can generate unexpected output. https://bugzilla.kernel.org/show_bug.cgi?id=206283 Signed-off-by: Vasily Averin Signed-off-by: Andrew Morton Acked-by: Peter Oberparleiter Cc: Al Viro Cc: Davidlohr Bueso Cc: Ingo Molnar Cc: Manfred Spraul Cc: NeilBrown Cc: Steven Rostedt Cc: Waiman Long Link: http://lkml.kernel.org/r/f65c6ee7-bd00-f910-2f8a-37cc67e4ff88@virtuozzo.com Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- kernel/gcov/fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/gcov/fs.c b/kernel/gcov/fs.c index e5eb5ea7ea598..cc4ee482d3fba 100644 --- a/kernel/gcov/fs.c +++ b/kernel/gcov/fs.c @@ -108,9 +108,9 @@ static void *gcov_seq_next(struct seq_file *seq, void *data, loff_t *pos) { struct gcov_iterator *iter = data; + (*pos)++; if (gcov_iter_next(iter)) return NULL; - (*pos)++; return iter; } -- 2.20.1