Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4467405ybz; Tue, 28 Apr 2020 11:47:30 -0700 (PDT) X-Google-Smtp-Source: APiQypIgRr3g6b/SAmI30w0XrdPftsI4Uys+qypghELz8Z4qD3GnkyujxoKPLi2DcX8lwH1HE9jn X-Received: by 2002:aa7:cf0e:: with SMTP id a14mr10827376edy.188.1588099650725; Tue, 28 Apr 2020 11:47:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588099650; cv=none; d=google.com; s=arc-20160816; b=i5Wc+DGTaGA372xgky+DdDM/9TUxdrgTsDvB9YY35ubCpHVgK9baJ4QWnbOsB91M7T FjKotToXPdmZcgZWwn1FkfIezpLWbrgJnPbTYfDEhdFzMTlJ0sPKXMRsZXz+VHcx0w2L BPSkTBYoywsrF1xdWXD1m0L5GyYv+A4mcZFLm5pgQdnUYUdbCT7wm+ncUl5qCdl6AI/i m9IxdGNEZOSjrMwQMob9wYJ9TYGZ2WdALJ89NfXkdQrjs2S3Pq8dTRZkIY7ZdsCdx/P0 2G9BerasN/x0/uKWlWUFhniPQiE2zIJnehx7A5Dg4TMVQWIROBVWc216GlPOsl/6GkqD ojbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=YvetPdWNhqaKhNQCe4nTvL5mjPCnLvKai8JANCPQ4m0=; b=yADDGe6HhPj2A+t9SVccFfmO4jcKc7i5O0T5HQVsvapIIqMpe5smZT2zj9GbNjX3+m AtFTynzqOkdzyhEWlPzKvCR1b0vUN547la2zlXqB3PEa+EWCJBdVI8a8YVf+iTqlrLuK EdEM2xLGu2vAem5nX/K6MqE/ss21pSvTEwjpuujEZCo8LUkodb1v0rWIDgwUWIvxvgD/ K4aLRPkw6VLRwNPuS+CBCYFGHQ7HZ8QPGanr3sjl1LfcH12MAo6w3SKOA2sRCyaxXvEn 8ZTDtmXvNw68rYlTFVzWtsdUsCD93mlTRjVsaWXDw3O1u0/0VJujxvg4XXTgAevAPri6 5VvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ad0e4e2g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si2264388ejr.249.2020.04.28.11.47.07; Tue, 28 Apr 2020 11:47:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ad0e4e2g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731292AbgD1Snv (ORCPT + 99 others); Tue, 28 Apr 2020 14:43:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:36486 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731278AbgD1Sns (ORCPT ); Tue, 28 Apr 2020 14:43:48 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 53CE420730; Tue, 28 Apr 2020 18:43:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588099427; bh=aA6z5Im+fckIqDKy07hv31qtqVKsbkx6P9lhSktTShc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ad0e4e2gSOfp1gLFzwiwXvHyItMxvXmqzS6ignJOiafIR1LkSDA2AMAJvsSUoPPU3 kQUQVTbgMecsb8+UU043BrHFDwicYc0jgpAjSdv+oiCXOxOn6T69aGNXkuSa4/Qidg Bjr8om+R1pVAdgPEP6LovFbt8n4wLJjbz6FdxHVU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Oliver Neukum Subject: [PATCH 5.4 147/168] UAS: no use logging any details in case of ENODEV Date: Tue, 28 Apr 2020 20:25:21 +0200 Message-Id: <20200428182250.173811338@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200428182231.704304409@linuxfoundation.org> References: <20200428182231.704304409@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oliver Neukum commit 5963dec98dc52d52476390485f07a29c30c6a582 upstream. Once a device is gone, the internal state does not matter anymore. There is no need to spam the logs. Signed-off-by: Oliver Neukum Cc: stable Fixes: 326349f824619 ("uas: add dead request list") Link: https://lore.kernel.org/r/20200415141750.811-1-oneukum@suse.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/storage/uas.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/usb/storage/uas.c +++ b/drivers/usb/storage/uas.c @@ -190,6 +190,9 @@ static void uas_log_cmd_state(struct scs struct uas_cmd_info *ci = (void *)&cmnd->SCp; struct uas_cmd_info *cmdinfo = (void *)&cmnd->SCp; + if (status == -ENODEV) /* too late */ + return; + scmd_printk(KERN_INFO, cmnd, "%s %d uas-tag %d inflight:%s%s%s%s%s%s%s%s%s%s%s%s ", prefix, status, cmdinfo->uas_tag,