Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 28 Apr 2020 11:49:10 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Huazhong Tan <tanhuazhong@huawei.com>
Cc:     <davem@davemloft.net>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <salil.mehta@huawei.com>,
        <yisen.zhuang@huawei.com>, <linuxarm@huawei.com>,
        Yonglong Liu <liuyonglong@huawei.com>
Subject: Re: [PATCH net-next] net: hns3: adds support for reading module
 eeprom info
Message-ID: <20200428114910.7cc5182e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <1588075105-52158-1-git-send-email-tanhuazhong@huawei.com>
References: <1588075105-52158-1-git-send-email-tanhuazhong@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 28 Apr 2020 19:58:25 +0800 Huazhong Tan wrote:
> From: Yonglong Liu <liuyonglong@huawei.com>
> 
> This patch adds support for reading the optical module eeprom
> info via "ethtool -m".
> 
> Signed-off-by: Yonglong Liu <liuyonglong@huawei.com>
> Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>

> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> index 4d9c85f..8364e1b 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> @@ -12,6 +12,16 @@ struct hns3_stats {
>  	int stats_offset;
>  };
>  
> +#define HNS3_MODULE_TYPE_QSFP		0x0C
> +#define HNS3_MODULE_TYPE_QSFP_P		0x0D
> +#define HNS3_MODULE_TYPE_QSFP_28	0x11
> +#define HNS3_MODULE_TYPE_SFP		0x03

Could you use the SFF8024_ID_* defines from sfp.h here as well?

Otherwise looks good to me!