Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4472481ybz; Tue, 28 Apr 2020 11:53:12 -0700 (PDT) X-Google-Smtp-Source: APiQypJKhQNphm1cZmD4XoVGsaTczCs08JZRA5dpkeYbSafZyDBnmm+krI85Q4VEHywWQ94GkZSc X-Received: by 2002:a17:906:38c:: with SMTP id b12mr25450167eja.332.1588099992512; Tue, 28 Apr 2020 11:53:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588099992; cv=none; d=google.com; s=arc-20160816; b=FxYaE4B73+czzkaAqem9Ue2tbB/EURRILJNSeP4CO/u5ykrWR807Gu3sI8g36F0mn9 vOMbg4LhAkafsl2zi+00wBBn/GR0yaQ6pir+z9lHwHaDUKHHSgCVOPRZ05yWEX7X2Luo iX6Tc6xCEA8DSr2tZI2VhaQTCUNNOY74SE7869LTRrUMaOigmbayoT6HtD+mMtvS2Fhl rNzbfNilc5XhBe75GT/tU3iWZkCZTnCEe63/VcStgrueFzFh4GNXRo68XL+Y7af3tdu3 ITFCM1/lb+1xY9PZUaxlIzWq3X3i/9ZcZhj1lAlQb6RNwuLH0s+GHTNv/4ckKVN9ZC+1 eB5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=NzPbzNJ0bVX+ZXLm+qGO75EBzxxKkYDtgnKJ6oKqB+o=; b=Vh3Dm6AjmM75o7w2pUv2Bw9y+Sqi7Cyc1hS3TPkSAuNNYGh4yjMHWFoE0lnQGzE9wI gX5XnHcx4Fea8yoCtByWBdDZwFbAmdc0YtPmfGWjLy91tReCLVjAcdNLnOfJxkCT8ygi TIJIOzYNf+cSydPXc/LC+1qiZOAYwtqh9MeiPRpHQLVbv9JHSwUQz9Sa5rB4VXWYsNom jUCk2E7sYPQ2KC7wvc2eijsghcTLAK3FhguBkgRLvjwoy+lptQJ7icJIuR4bI5K36cCx KevSDq1aE2GiF2PRCkwQjHPW9QwyvSr8s0r8A1NGbexge8lWxVnYYNl6xEWR82Yyxcw1 rnaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gE006a8p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s26si2028574edy.349.2020.04.28.11.52.49; Tue, 28 Apr 2020 11:53:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gE006a8p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730629AbgD1SvB (ORCPT + 99 others); Tue, 28 Apr 2020 14:51:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:55944 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730530AbgD1Shp (ORCPT ); Tue, 28 Apr 2020 14:37:45 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CB82E2085B; Tue, 28 Apr 2020 18:37:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588099065; bh=aBiKRtEwJSJ8EawSUmhre+WjRJEOrBukB4zaQ//1MYU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gE006a8pb3n0c4C81V3f2u0ablGIYLi1fvsxqonhJLw2H81dtJpS14z23rdoOgiqh FDqeP2qlX46O9WFQ4GDAnsF4feeDwGXKKAvvpAEfzHuUwrh4j1xNJV2QrmxcJjRHqY 2Jjzww3fqN3Zf8hr69+5FahVO75/9wqtFaYDs7i0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Scott Benesh , Scott Teel , Kevin Barnett , Murthy Bhat , Don Brace , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.4 052/168] scsi: smartpqi: fix call trace in device discovery Date: Tue, 28 Apr 2020 20:23:46 +0200 Message-Id: <20200428182238.474840377@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200428182231.704304409@linuxfoundation.org> References: <20200428182231.704304409@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Murthy Bhat [ Upstream commit b969261134c1b990b96ea98fe5e0fcf8ec937c04 ] Use sas_phy_delete rather than sas_phy_free which, according to comments, should not be called for PHYs that have been set up successfully. Link: https://lore.kernel.org/r/157048748876.11757.17773443136670011786.stgit@brunhilda Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Murthy Bhat Signed-off-by: Don Brace Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/smartpqi/smartpqi_sas_transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/smartpqi/smartpqi_sas_transport.c b/drivers/scsi/smartpqi/smartpqi_sas_transport.c index 6776dfc1d317c..b7e28b9f8589f 100644 --- a/drivers/scsi/smartpqi/smartpqi_sas_transport.c +++ b/drivers/scsi/smartpqi/smartpqi_sas_transport.c @@ -45,9 +45,9 @@ static void pqi_free_sas_phy(struct pqi_sas_phy *pqi_sas_phy) struct sas_phy *phy = pqi_sas_phy->phy; sas_port_delete_phy(pqi_sas_phy->parent_port->port, phy); - sas_phy_free(phy); if (pqi_sas_phy->added_to_port) list_del(&pqi_sas_phy->phy_list_entry); + sas_phy_delete(phy); kfree(pqi_sas_phy); } -- 2.20.1