Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4472881ybz; Tue, 28 Apr 2020 11:53:40 -0700 (PDT) X-Google-Smtp-Source: APiQypKqLScLwE4VnP/3/vOag45t7CQQIPwrInjxl0SycQuRSg15t0uvBSEWxhyVTQKJk/e+Q0EE X-Received: by 2002:a17:906:adb:: with SMTP id z27mr26275989ejf.263.1588100020788; Tue, 28 Apr 2020 11:53:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588100020; cv=none; d=google.com; s=arc-20160816; b=bv75tH3hYET1Uoli7hmi+hPpCgqvD5RegC16CPKKQ5C5+KGcUuCy+fBFyvsuGAYfIv 9ulEvCNQBCWY9qg56Abrhmlvsns5A+IGN8KjGtonUdW/x6sVBX3qShVRZkJcpbCrLBWi TnssVXCsfW51lMmesspCFF9XgcMv4FcrJtn4jXOi6ct2bnKZOkShm3bHPyBAiHymCduk tfKvYIAzceAoLBsauxbXsuY/lBH1Gqb539ViPcmWMD1j50eJTPhkxp4xCi00tdv7KQiB qK9tFAMs8PAdQ5awoGGa3YhidvKz3asFfaXqZL6nQjyleWM7tAmCBVm1NCzACr74Zwvr hYUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=A2iJ3/vbAZw/yySMeHxQx+P7E+TvfMS9JDcBew8dPjI=; b=lrJvNRfKeEiBqTcvwCwlo8/EjmePDn5xOYNgUMwWVaVtbYlwCzkhebqSzGcBGOt6lj iJu7/WQS1Tsz2jn5VD2QadAdZbo9PX2U43Vyqbo+1gJvZJkN+5zs07AWKu+RUZrYSWa2 MXGjCpF09fEvKVBxYsRsV+CnzDCWGqTyePtIONW3571HCG96yebrvJt49PCSzJ8gRxHP bqpfm9ftpCylbGq03Q0EQmUV/Ak7wNp20iWoI2bFC1JyqKe4jl3MQACohp6B031gFG30 6xKtS2HaYtvd/85kNCr4jaA6rBqNYlJjBKaROI3i5obiSIbGCes2Vn6uTp0McdYxfPXL zUzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JENHmkMt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m4si2498319ejd.315.2020.04.28.11.53.16; Tue, 28 Apr 2020 11:53:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JENHmkMt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730935AbgD1SwB (ORCPT + 99 others); Tue, 28 Apr 2020 14:52:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:54146 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730383AbgD1Sgi (ORCPT ); Tue, 28 Apr 2020 14:36:38 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DA9AB2085B; Tue, 28 Apr 2020 18:36:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588098998; bh=aXQgl0ZNfrWXCQb6+w320BVyC8lkIiecHEU16PpLw9E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JENHmkMtftmVphB23ygdtljWwVhRCcFhWcUDSwDC08K9f1kVnwcoEpEzobufDL7zH 99fbiG3MdqZy2xsOkY3GDPU3UMSI1lSzEUTzVMRoq54i8ZMeOQzco3Fxt8fj/84C0+ hEUDhzAJk4VJVAGHVUHg+rH0Z7QwjYxtpvWPuzSQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Malcolm Priestley Subject: [PATCH 5.6 142/167] staging: vt6656: Power save stop wake_up_count wrap around. Date: Tue, 28 Apr 2020 20:25:18 +0200 Message-Id: <20200428182243.586007544@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200428182225.451225420@linuxfoundation.org> References: <20200428182225.451225420@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Malcolm Priestley commit ea81c3486442f4643fc9825a2bb1b430b829bccd upstream. conf.listen_interval can sometimes be zero causing wake_up_count to wrap around up to many beacons too late causing CTRL-EVENT-BEACON-LOSS as in. wpa_supplicant[795]: message repeated 45 times: [..CTRL-EVENT-BEACON-LOSS ] Fixes: 43c93d9bf5e2 ("staging: vt6656: implement power saving code.") Cc: stable Signed-off-by: Malcolm Priestley Link: https://lore.kernel.org/r/fce47bb5-7ca6-7671-5094-5c6107302f2b@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/vt6656/int.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/staging/vt6656/int.c +++ b/drivers/staging/vt6656/int.c @@ -145,7 +145,8 @@ void vnt_int_process_data(struct vnt_pri priv->wake_up_count = priv->hw->conf.listen_interval; - --priv->wake_up_count; + if (priv->wake_up_count) + --priv->wake_up_count; /* Turn on wake up to listen next beacon */ if (priv->wake_up_count == 1)