Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4474239ybz; Tue, 28 Apr 2020 11:55:17 -0700 (PDT) X-Google-Smtp-Source: APiQypJB8nBL9ib7t+OO7pui6H3iIemyA+tqhZjOA7uXMpfk5m/QDXmuvrNFwTrHHhiSYUrpmA/y X-Received: by 2002:aa7:d143:: with SMTP id r3mr17925893edo.147.1588100116824; Tue, 28 Apr 2020 11:55:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588100116; cv=none; d=google.com; s=arc-20160816; b=qEs8kQCpBrMWaCV8ZZmopcR1OT43rpU2WS4H5Xuyo3ebcKzT8anYKozso16/oKGshA 4MDKWiGne2bZJiGnsK/Ib9D1oaVd9vNNShHMLNCnd6EDK5tfMWEUO7ZVbgGt2Gg8se7U VqSr2fCIaHfRv7heeFOXrDEjCrq8auAGseRINopvJFjQUbkStkpqu8MEvyttCusYlwGF l5VR+bjPI39DgEuhJJfbEt5tO4vb+VowwKmYW10a1pp0LY+Yc54fh5+061NA4PoxUJna mUA31M0ZwGi0ZxgDyepFI2rC7QXGGYbTM4HJv1lV+e4e9NtPr4H8QytZ107whdjE4Wz3 d19w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=YvetPdWNhqaKhNQCe4nTvL5mjPCnLvKai8JANCPQ4m0=; b=fchp9/p9DQNLwMcEwsHCMcoiIqCOpG8DKJmDwOxlPbemcP4pJPzgL6VMl3vuFP0pdf LOXievbYMHfCMtMXQDitfq3R0cHB4QM44/8CTdohj/z6ZRfHc5rzC+n5hLLo7JR9h45a etdsCr8EBn3BW1GqpQczDdUuRt79LPZ3UPMD+l8rw5GlHDf7ShTHPtvlebUCrRcdyJDQ o7lK4TzSQ1u7ZlHmh2Z8jq7DE8hwfmEEtHpcogexyP59J+YUS9YKoKuu5lIEdvtBauV+ cY0OHeVkPvzBGYwAjXs4fuM3lVNP/3Sf1vXGE0c5sWDZ/q0BQ95Q3pYwY3nQ8YP+D4UF VzlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="fY/tYTIG"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j23si2426434ejm.361.2020.04.28.11.54.53; Tue, 28 Apr 2020 11:55:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="fY/tYTIG"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730392AbgD1Svh (ORCPT + 99 others); Tue, 28 Apr 2020 14:51:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:55112 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729218AbgD1ShL (ORCPT ); Tue, 28 Apr 2020 14:37:11 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 85BCD20B80; Tue, 28 Apr 2020 18:37:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588099031; bh=aA6z5Im+fckIqDKy07hv31qtqVKsbkx6P9lhSktTShc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fY/tYTIGwKMRVKzVKsa6tAVFwToeUFGVci7Hl+HVDZl8xgT+1OS6GMpoJPmFWkCTR 4dAdCB/tI4T9Aq+c/O5UxcF+u2euua4uTAib4ANOKE5CnehsR++5Fs24nzHP91PYkn 0Z3rgixrh5PyRnNOfyJyyIFr3wVuhyOB0xmU4kz8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Oliver Neukum Subject: [PATCH 5.6 146/167] UAS: no use logging any details in case of ENODEV Date: Tue, 28 Apr 2020 20:25:22 +0200 Message-Id: <20200428182244.058058234@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200428182225.451225420@linuxfoundation.org> References: <20200428182225.451225420@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oliver Neukum commit 5963dec98dc52d52476390485f07a29c30c6a582 upstream. Once a device is gone, the internal state does not matter anymore. There is no need to spam the logs. Signed-off-by: Oliver Neukum Cc: stable Fixes: 326349f824619 ("uas: add dead request list") Link: https://lore.kernel.org/r/20200415141750.811-1-oneukum@suse.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/storage/uas.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/usb/storage/uas.c +++ b/drivers/usb/storage/uas.c @@ -190,6 +190,9 @@ static void uas_log_cmd_state(struct scs struct uas_cmd_info *ci = (void *)&cmnd->SCp; struct uas_cmd_info *cmdinfo = (void *)&cmnd->SCp; + if (status == -ENODEV) /* too late */ + return; + scmd_printk(KERN_INFO, cmnd, "%s %d uas-tag %d inflight:%s%s%s%s%s%s%s%s%s%s%s%s ", prefix, status, cmdinfo->uas_tag,