Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4480915ybz; Tue, 28 Apr 2020 12:02:31 -0700 (PDT) X-Google-Smtp-Source: APiQypJS9R9KJI4n5RpFbX/K8t1Uim4lBMJxVDaLP8C02PQc/ZJ2FLSt53BYbM5PKrzRDlJmQmti X-Received: by 2002:a17:906:a38f:: with SMTP id k15mr26773136ejz.181.1588100551223; Tue, 28 Apr 2020 12:02:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588100551; cv=none; d=google.com; s=arc-20160816; b=VJc61jCvK095hVedfR+kczoiLQI+mW5uxzPqEGhWf345XAr4SbKO254KVvG5V/s9fX j7NEheArA4H2nCuh6QJmqgm5gMxxdtMhBqr5epmFaBMQLvPpbuGYsjEZck1akcDJ/vy4 967JiPQnpNMAnJJIUC11faHtOtEnOy+VjUhXajUQY30qm+OfRpCEqdYWrPOjf1dHWsYz aGaWZviMzN2fFnh2b8527IInSMjC8YzDeMmfCtqkjMqt9fHwppS5BYyWVBCtzR8bglX2 zSydaxZy5n8CeDcz7QDC6NzEuEy6EOCfO+tjYq1iTgXWaoG37r/BWHmuAVlgW6E5XEWu KEiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=6E7pma5m9M4NcZ9Yhzz4l4XvqJwnGiI80hoDsqSfZls=; b=lewJzR9SPV+0a9BTcJUHjWugYwRkTrkGD0UqzKQ3xDgUoMiSNBRLCLvypOBoQWaOeS zWNcrTHcf/rjDlZQCAifF6Ukx/d/BlQd9aqD5JpTqGrrhtRYC93jNoaGgPf3Ji9qErla 3HhSYtFQBmEf+YpTnfzEpHv3+3UojzuBjBzLpMh4cVEnIaA543Go/bO/keQ4CFqyvScG 0YOL80yRRqNJJ5WzducX3K4mJQUpGo5/r5qMs442gdrENZnSN9/7KnDbmmGeIJhc3LhR ePH7w6Bc1wuCOP/nTzrET51TvSlPpCQT7sMegJlAzV09qseqgUjtnLZbOflVoagfXmOZ ahdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ak4nOytH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r12si2308023edw.278.2020.04.28.12.02.08; Tue, 28 Apr 2020 12:02:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ak4nOytH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729729AbgD1S6o (ORCPT + 99 others); Tue, 28 Apr 2020 14:58:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:42458 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729294AbgD1S3E (ORCPT ); Tue, 28 Apr 2020 14:29:04 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2DFAB20730; Tue, 28 Apr 2020 18:29:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588098543; bh=e3Ix0CKQnO2vFrhw8s5qjaLhbJuDinvzEZLMlqEOCsc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ak4nOytHKWYQyUfIygc+xSZ5r+RTxULAW7Tv1zRjktzLiii9qKvhmFNGXo9/K85VQ 2kThyHmNhh0pprbZcj0OyjxY6c98dKsQr8SuXm4628wYOi8rBdu/p2m03QrKpU8BnZ 9L83P1CF3oB8dTdWeVO8W5DYrmUMSAw051fD8MAA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tero Kristo , Guenter Roeck , Wim Van Sebroeck , Sasha Levin Subject: [PATCH 4.19 011/131] watchdog: reset last_hw_keepalive time at start Date: Tue, 28 Apr 2020 20:23:43 +0200 Message-Id: <20200428182226.602808871@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200428182224.822179290@linuxfoundation.org> References: <20200428182224.822179290@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tero Kristo [ Upstream commit 982bb70517aef2225bad1d802887b733db492cc0 ] Currently the watchdog core does not initialize the last_hw_keepalive time during watchdog startup. This will cause the watchdog to be pinged immediately if enough time has passed from the system boot-up time, and some types of watchdogs like K3 RTI does not like this. To avoid the issue, setup the last_hw_keepalive time during watchdog startup. Signed-off-by: Tero Kristo Reviewed-by: Guenter Roeck Link: https://lore.kernel.org/r/20200302200426.6492-3-t-kristo@ti.com Signed-off-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck Signed-off-by: Sasha Levin --- drivers/watchdog/watchdog_dev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c index e64aa88e99dab..10b2090f3e5e7 100644 --- a/drivers/watchdog/watchdog_dev.c +++ b/drivers/watchdog/watchdog_dev.c @@ -264,6 +264,7 @@ static int watchdog_start(struct watchdog_device *wdd) if (err == 0) { set_bit(WDOG_ACTIVE, &wdd->status); wd_data->last_keepalive = started_at; + wd_data->last_hw_keepalive = started_at; watchdog_update_worker(wdd); } -- 2.20.1