Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4517349ybz; Tue, 28 Apr 2020 12:45:44 -0700 (PDT) X-Google-Smtp-Source: APiQypLG6QJk+AYpsVY1VEnmGpL76NaJzLLUQFMYUKYOeaRqfGKsDo544xMvF0whlaS+DLlQO0tF X-Received: by 2002:a50:a7e4:: with SMTP id i91mr3561795edc.381.1588103143938; Tue, 28 Apr 2020 12:45:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588103143; cv=none; d=google.com; s=arc-20160816; b=huaOj5fppiq42qdLRhbUi4GRJdqmTduGBFKyYKfFdD5DUn83jkYoH+whuTAY5uBrru +I3C2cP1GMXRBmVravNm/kXY4LGY/2TiuTJQXshrWXzZxDLMri9JFig/iE9v1Wb+8TfO h9fAKVVwYaJJcxJwc4tNwae0nWnk9ouEoLUuA5fRSOHJExakAmRBUnnBP9iRN7sgpByh bWcJVfSoJxRqonsAVgiZCD4z4Fxqh4BbJwlrp92b0uSEf+8JbakugpwNHlV/tvaFBl8n 7LUpwGdksfRdMUE0aidDFlmQp+CPm8fWKxeWdLc655mctVRr3Z4PT64y4bbAwClorEVA hl/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:references:cc:to:from:subject:ironport-sdr :ironport-sdr; bh=ICOiBpa/+zhT86jfyOaCz5wXbnkPIG2N0h7CxiUNU9M=; b=RkvQ4/OGeA/jczrkUXXRHcTiL7/FQaFL4cRmA9RSNRIY9mkyn44vbLC9LJ/tufnnjQ 12Z6cjtTBPBGV5fhVWqmLvojBzj3wSMsSAollSDEHE2q38seTA/cL2DH/6LKh6gW1yAn ftsczjngwDhj+73H3TzVXZT1J4XpPxGkoghBYDNfVUMUzlL7NUs2aT6O2Rp2RWR/tuWO gw4T7ICLT2cVqzvS/nT9OSY6BexeYUi6u1z2aZI1IAqFwUVh35mnD565ZYrIV9DAeVr5 4ToyE3gfK0tqMnkP5i7RBAiygtR9VEK44Jg6Lnt/wdB7+421yXEQpeiMnPdpkmsL8oT/ jrVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gr21si2331695ejb.482.2020.04.28.12.45.18; Tue, 28 Apr 2020 12:45:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728897AbgD1Tnr (ORCPT + 99 others); Tue, 28 Apr 2020 15:43:47 -0400 Received: from mga02.intel.com ([134.134.136.20]:5414 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728392AbgD1Tnq (ORCPT ); Tue, 28 Apr 2020 15:43:46 -0400 IronPort-SDR: mT3NNkrtxs+HfuwWpLsJyulLjXijn5QhW9fBfR7iG5VsWja+1CPe5y9Qyt/mNNyA1NFw2eYLBm Vr9LX4ik8MEg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2020 12:43:45 -0700 IronPort-SDR: YNafAoLdvh608aA+tMLQbG9KBS8iBO0+cvQWLK7pt4bINeqXoIhgIIVfqAeNVxCg3jWoi1rV3o taxN4i+mYYvg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,328,1583222400"; d="scan'208";a="261205442" Received: from meis-mobl1.amr.corp.intel.com (HELO [10.255.231.186]) ([10.255.231.186]) by orsmga006.jf.intel.com with ESMTP; 28 Apr 2020 12:43:45 -0700 Subject: Re: [PATCH v4 2/2] mm/gup/writeback: add callbacks for inaccessible pages From: Dave Hansen To: Claudio Imbrenda Cc: Peter Zijlstra , Andy Lutomirski , linux-next@vger.kernel.org, akpm@linux-foundation.org, jack@suse.cz, kirill@shutemov.name, "Edgecombe, Rick P" , Sean Christopherson , borntraeger@de.ibm.com, david@redhat.com, aarcange@redhat.com, linux-mm@kvack.org, frankja@linux.ibm.com, sfr@canb.auug.org.au, jhubbard@nvidia.com, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Will Deacon , "Williams, Dan J" References: <20200306132537.783769-1-imbrenda@linux.ibm.com> <20200306132537.783769-3-imbrenda@linux.ibm.com> <3ae46945-0c7b-03cd-700a-a6fe8003c6ab@intel.com> <20200415221754.GM2483@worktop.programming.kicks-ass.net> <20200416141547.29be5ea0@p-imbrenda> <20200416165900.68bd4dba@p-imbrenda> <20200416183431.7216e1d1@p-imbrenda> <396a4ece-ec66-d023-2c7e-f09f84b358bc@intel.com> Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <42fccd01-7e16-b18f-cd81-4040857d80d4@intel.com> Date: Tue, 28 Apr 2020 12:43:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/21/20 2:31 PM, Dave Hansen wrote: > On 4/16/20 12:02 PM, Dave Hansen wrote: >> On 4/16/20 9:34 AM, Claudio Imbrenda wrote: >>>> Ahh, so this is *just* intended to precede I/O done on the page, when >>>> a non-host entity is touching the memory? >>> yep >> OK, so we've got to do an action that precedes *all* I/O to a page. >> That's not too bad. >> >> I still don't understand how this could work generally, though There >> are lots of places where I/O is done to a page without either going >> through __test_set_page_writeback() or gup() with FOLL_PIN set. >> >> sendfile() is probably the best example of this: >> >> fd = open("/normal/ext4/file", O_RDONLY); >> sendfile(socket_fd, fd, &off, count); >> >> There's no gup in sight since the file doesn't have an address and it's >> not being written to so there's no writeback. >> >> How does sendfile work? > > Did you manage to see if sendfile works (or any other operation that > DMAs file-backed data without being preceded by a gup)? It's been a couple of weeks with no response on this. From where I'm standing, we have a hook in the core VM that can't possibly work with some existing kernel functionality and has virtually no chance of getting used on a second architecture. It sounds like there may need to be some additional work here, but should these hooks stay in for 5.7? Or, should we revert this patch and try again for 5.8?