Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4582553ybz; Tue, 28 Apr 2020 14:09:45 -0700 (PDT) X-Google-Smtp-Source: APiQypIofHaVRXKV2DzCbh2+3wqYoke/pTDEgYfEPjL9Fk4JQCpdoofhGBDmKZC8eJ7jU00Up3Vw X-Received: by 2002:aa7:d311:: with SMTP id p17mr24713738edq.73.1588108185668; Tue, 28 Apr 2020 14:09:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588108185; cv=none; d=google.com; s=arc-20160816; b=B14tuvVUdNgPSeZ9hUQYvEun9SzQB4Wmhp5c233z3Pw+PM0RW1u11/t0Uof5L1/WRW GDcqe65gyRlu7pDnhYDjFewikaDPkumstFqcOQqru7lIUxWUE1wxBW0UxAfOerQYKE01 wlOdTw6khL65xnft6kMyiTv+JGpHbs/A1FlHcdGqn92v1yezA6Fznu5fMBuun0dkcmal kJhwlKiO7BywdMOi5S797wNNMty15AH0TfKniocdE5KzHijOLWddC8dYR2kuUFxFRk9m uTr7dVo2LboEkH8g9jqI/PfqbUDuBrxhdqcYy1zWZHi2i8mlpBKiq/tXzmha6wt8m+Vh tXpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=Un514W96TAiHM25IVKxcx23i8VV5BDTavHFYnhTLzCQ=; b=CrYM+IBvtT/R8ldQOVcn8xaHO185SUaaFP8Zl5VGfhPie22n+EfPmG/U8mdaPN1ggW +jkcfwx1JUprHo3CvZl6BIm8OMUxHBrVr5vf6QGvCBG9Xh6DXwrquPLUD8X6PeqjSqAC Vmta/IEapaFK1q3xR9I51T4VRqQU7I7udq9LMU8MYJ4OQvbunUbmRd40YPcaIWWkMs+K 9HHDgYdnuzOLn4OmEzruipyFCuxRMHeDHWWkUCHCEQorDdeS3bFn6vW/9Wpzx/PAxRb9 EqkQedLgBAIFeBHPoK2yt7o6+8aBWruiAaNgEw2A92Yc3IBWn8YmN4TjpkZ06+Il/8JY PXbg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y19si2681999ejp.397.2020.04.28.14.09.21; Tue, 28 Apr 2020 14:09:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726424AbgD1VHt (ORCPT + 99 others); Tue, 28 Apr 2020 17:07:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726274AbgD1VHt (ORCPT ); Tue, 28 Apr 2020 17:07:49 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFB1EC03C1AC; Tue, 28 Apr 2020 14:07:48 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E69ED1210A3EF; Tue, 28 Apr 2020 14:07:46 -0700 (PDT) Date: Tue, 28 Apr 2020 14:07:46 -0700 (PDT) Message-Id: <20200428.140746.1017253285576997409.davem@davemloft.net> To: steve@sk2.org Cc: joe@perches.com, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: Protect INET_ADDR_COOKIE on 32-bit architectures From: David Miller In-Reply-To: <20200428075231.29687-1-steve@sk2.org> References: <20200428075231.29687-1-steve@sk2.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 28 Apr 2020 14:07:47 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stephen Kitt Date: Tue, 28 Apr 2020 09:52:31 +0200 > This patch changes INET_ADDR_COOKIE to declare a dummy typedef (so it > makes checkpatch.pl complain, sorry...) This is trading one problem for another, so in the end doesn't really move us forward.