Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4591941ybz; Tue, 28 Apr 2020 14:21:29 -0700 (PDT) X-Google-Smtp-Source: APiQypI0iZ/yPdULLZoGk0GZlDsYC/jZNLXmzplZPdgBi9eOyu78x8kPtM1gYGQXQV7ANEiHa3Nw X-Received: by 2002:aa7:d718:: with SMTP id t24mr10834883edq.20.1588108889322; Tue, 28 Apr 2020 14:21:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588108889; cv=none; d=google.com; s=arc-20160816; b=GSv0fY+G1GYreRtbQA+LOV0sNhJSp6WomMxITFT2VmjvX+OodLt8Qb/VEGEXHKtBNM A9cVy+7E1phbuRn5VcPW84My7Y3i9Kg3wE4rW3tpmDbpbIKYFvlrjQrb0FK98JHH7lGO KENcjiS2/BHiBuNTReb2v+mE8a2BWmM3/22/eCFWC3uTblIiFwyS/kpHyZ5FzHmqGqoj ty8zdnIGLbbztqAUuL6dQsVyPkMJ7OoAb5aiuh7r+82AyOX8K5jjLD7lCTqinknPjaW+ QL0IePefWxDH81MhdN7It2xrG9liIsnn9oMdlEYBuVEFpf65sO4a6OC/RYAUAKS/xdyZ F9bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=hkOa0kL3Mp7y+xwn5xhiJVvRXgCRLjNueS/GXnD9Q3E=; b=d8d0UmVkT4geepg0FKN7h79BU7hc226B5eMx1S/FPAuT0QAsq1nA/5eQoDOyxNBX4F pCCNXTPhM85JP5uzTM/BEQIJGYXquHdKlT79offDl1NuVcJ09/DsrP+QZS3+kcGEwKWR wI4/vqq9030J460Y+bIBD+FpNj2YFMDu+JHAQYIx2FYb28eXT1KxOyzHnhK46J5pcrXG 2LfIP+hUWCQksBxIfugjik6gzxpiDWkYW5+wkUa13TwUbsry5GpGcLKaTIXbrtF9TZ4e DHlTpILrqN17w9VRONN2QcIyFa25R3AU6+ZdrvZoZB8s3d+qi1Ux7m4YhRnUbIgwYRbe 0tNQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p7si2411462edx.98.2020.04.28.14.20.57; Tue, 28 Apr 2020 14:21:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726738AbgD1VTY (ORCPT + 99 others); Tue, 28 Apr 2020 17:19:24 -0400 Received: from mga01.intel.com ([192.55.52.88]:45107 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726483AbgD1VTX (ORCPT ); Tue, 28 Apr 2020 17:19:23 -0400 IronPort-SDR: ekVH395EVnQm27mw07g689x6lmqlcL2e3bk2L3l7/2/Efa5YwfQ+8faRKTUNO/spJnXeG5bMDX w4j/t6ghRF8g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2020 14:19:22 -0700 IronPort-SDR: bag5SpE7t8r86mNew+tfQwib1/3eh0Vj6dUD+4YqpzkfxlBlQKaFJ7gOdWS6sNKGasCi2QMv9r zFZn5zgfZ/Cg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,328,1583222400"; d="scan'208";a="336756828" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.21]) by orsmga001.jf.intel.com with ESMTP; 28 Apr 2020 14:19:22 -0700 Received: by tassilo.localdomain (Postfix, from userid 1000) id 78168301A7A; Tue, 28 Apr 2020 14:19:22 -0700 (PDT) Date: Tue, 28 Apr 2020 14:19:22 -0700 From: Andi Kleen To: Jiri Olsa Cc: Jin Yao , acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH] perf stat: Fix uncore event mixed metric with workload error issue Message-ID: <20200428211922.GA874567@tassilo.jf.intel.com> References: <20200427144116.27330-1-yao.jin@linux.intel.com> <20200428105155.GG1476763@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200428105155.GG1476763@krava> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I wonder this would break some expectations.. would it be > more safe to detect duration event and bypass it from the > decission? but maybe the case I'm worried about is not a > problem at all.. Andi? Don't see what it would break. Yes maybe we need to special case duration_time more, but that would be a much bigger patch. -Andi