Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4619708ybz; Tue, 28 Apr 2020 15:01:54 -0700 (PDT) X-Google-Smtp-Source: APiQypJZBv5Q1OPMsRiEWlFxLMvP7iw+sMPqEnLhqJuWE0WDfdt8IbBgIUAJvPzykNwilfNcFEgO X-Received: by 2002:aa7:d5d4:: with SMTP id d20mr25109540eds.369.1588111314120; Tue, 28 Apr 2020 15:01:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588111314; cv=none; d=google.com; s=arc-20160816; b=P4qASDYWBYTi/Cjd7EdTroN+QnTtxS2xZKKwYReARFoz6axEVRqD5bEmNLsMLNxpt0 HTVrvYe4AL0lw638hwOoer/QBAF4Nty0PwhLHPgjYmnLhUrM/SQGReshc3J19J3eGwsj HmmY5jGIvz4sec2iQQujt9IqHTCTMJDYQxe4fP/Menr5K8hPHYx9cVn038iPfj8ng2O/ bdI3/jp3Pyiq/BwDMCzq+JMhcn59g5rQqs9/owAVdjWq8FAj8uUvDF2CYE2gYeMDctFM yMY2dzfCXz1Gi4L+8SrNt0A/LWwBgpmQGg/OeAAixowR1zeyB8pgpM5JrP2NDODpml/z rXsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:mime-version:user-agent :message-id:in-reply-to:date:references:cc:to:from; bh=73FDoA5D44NOZ9K1t1lgG+yoaaHkKmRLdwQNvXSb+YA=; b=QgQI5bE5UdoDRNrSvJk4LvFGVGC9ztxnqSdGQ7jEOjDMkxw8U1PAGfsSRxpKk+Ayvv 2mvTmxTx8I/IUAbUPnJmHLmF/mLIPfPiRLhCfprweRodVTPIRUwvqsTxNvuhR8vc25CZ PeJKmVhgKsGCgLjW+TYHJty3YBCgMHXjObeCh7t/auDWGNlmJt2NtnF4UCvld6IsJVrX +UHRkh4zH1x4rLGF4HHSpkFWuKCcSnwpzMU8iqk1pwQYwsfyEVcTbc8f4cv4+IAgUWyl G8X2w0a/6h8a43yNI5CexE80eOB39dvuG8i14kZ5TtARIp9BIX6imSxSRe38Do5jjM9T sEjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d5si2382784edz.401.2020.04.28.15.01.23; Tue, 28 Apr 2020 15:01:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726357AbgD1V7l (ORCPT + 99 others); Tue, 28 Apr 2020 17:59:41 -0400 Received: from out01.mta.xmission.com ([166.70.13.231]:42936 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726256AbgD1V7k (ORCPT ); Tue, 28 Apr 2020 17:59:40 -0400 Received: from in01.mta.xmission.com ([166.70.13.51]) by out01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTYGR-0000Tk-EL; Tue, 28 Apr 2020 15:59:39 -0600 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95] helo=x220.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1jTYGQ-0003k8-Pl; Tue, 28 Apr 2020 15:59:39 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: LKML Cc: Oleg Nesterov , Linus Torvalds , Thomas Gleixner References: <20200419141057.621356-1-gladkov.alexey@gmail.com> <87ftcv1nqe.fsf@x220.int.ebiederm.org> <87wo66vvnm.fsf_-_@x220.int.ebiederm.org> <20200424173927.GB26802@redhat.com> <87mu6ymkea.fsf_-_@x220.int.ebiederm.org> <875zdmmj4y.fsf_-_@x220.int.ebiederm.org> <878sihgfzh.fsf@x220.int.ebiederm.org> <87sggnajpv.fsf_-_@x220.int.ebiederm.org> <20200428180540.GB29960@redhat.com> <87mu6v70in.fsf_-_@x220.int.ebiederm.org> Date: Tue, 28 Apr 2020 16:56:24 -0500 In-Reply-To: <87mu6v70in.fsf_-_@x220.int.ebiederm.org> (Eric W. Biederman's message of "Tue, 28 Apr 2020 16:39:44 -0500") Message-ID: <87pnbr5l6f.fsf_-_@x220.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1jTYGQ-0003k8-Pl;;;mid=<87pnbr5l6f.fsf_-_@x220.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1/RFDt7kKDsm8z1PG360s6aH2eNeEKiKPE= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa07.xmission.com X-Spam-Level: X-Spam-Status: No, score=0.3 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,T_TooManySym_01,XMGappySubj_01 autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4984] * 0.5 XMGappySubj_01 Very gappy subject * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa07 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa07 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;LKML X-Spam-Relay-Country: X-Spam-Timing: total 261 ms - load_scoreonly_sql: 0.04 (0.0%), signal_user_changed: 11 (4.3%), b_tie_ro: 10 (3.7%), parse: 0.84 (0.3%), extract_message_metadata: 12 (4.5%), get_uri_detail_list: 1.12 (0.4%), tests_pri_-1000: 13 (4.9%), tests_pri_-950: 1.25 (0.5%), tests_pri_-900: 1.04 (0.4%), tests_pri_-90: 72 (27.6%), check_bayes: 71 (27.0%), b_tokenize: 5 (2.1%), b_tok_get_all: 5 (2.0%), b_comp_prob: 1.69 (0.6%), b_tok_touch_all: 55 (21.1%), b_finish: 0.85 (0.3%), tests_pri_0: 139 (53.0%), check_dkim_signature: 0.48 (0.2%), check_dkim_adsp: 2.0 (0.8%), poll_dns_idle: 0.45 (0.2%), tests_pri_10: 2.2 (0.9%), tests_pri_500: 7 (2.5%), rewrite_mail: 0.00 (0.0%) Subject: [PATCH v4 4/4] signal: Remove has_group_leader_pid X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After the introduction of exchange_tids has_group_leader_pid is equivalent to thread_group_leader. After the last couple of cleanups has_group_leader_pid has no more callers. So remove the now unused and redundant has_group_leader_pid. Signed-off-by: "Eric W. Biederman" --- include/linux/sched/signal.h | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/include/linux/sched/signal.h b/include/linux/sched/signal.h index 3e5b090c16d4..0ee5e696c5d8 100644 --- a/include/linux/sched/signal.h +++ b/include/linux/sched/signal.h @@ -654,17 +654,6 @@ static inline bool thread_group_leader(struct task_struct *p) return p->exit_signal >= 0; } -/* Do to the insanities of de_thread it is possible for a process - * to have the pid of the thread group leader without actually being - * the thread group leader. For iteration through the pids in proc - * all we care about is that we have a task with the appropriate - * pid, we don't actually care if we have the right task. - */ -static inline bool has_group_leader_pid(struct task_struct *p) -{ - return task_pid(p) == task_tgid(p); -} - static inline bool same_thread_group(struct task_struct *p1, struct task_struct *p2) { -- 2.20.1