Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp98258ybz; Tue, 28 Apr 2020 19:08:36 -0700 (PDT) X-Google-Smtp-Source: APiQypLXvZw14hJ0HYnMp8vCNC81hg7PwjXlOlJSQtRW31WySc6xlrgObUVG0WRLK0aMvWzol8bc X-Received: by 2002:aa7:c7cb:: with SMTP id o11mr552585eds.380.1588126116053; Tue, 28 Apr 2020 19:08:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588126116; cv=none; d=google.com; s=arc-20160816; b=OGvCyRjxmAG2eWTuW/nyaMdyaT2APIHMxeRH61YKXC2qnu1ttI58IvJB9SpxqkUhOv CIjz7meDaPATLbSKiyjB4ljdnmC+LC3YUIsbMvX3yogesMb4QDv9CW/ZSz55C6W82paN vdLdF5zI4Dr/IxCNNko4dRuPizRTSvB3xTkciTBAYrbMTZM78spMe/w87ptSb1TDAJ9U eE90I51K2/IQWENt2k2/nN6rCqUt8bomg7HU1Jrac6v5CZ/JmqwtdBLeeuyxA/gZHHzT 2RUl6420zXPQvXoe2U+tQX4ZQeILno/YSD94AfBH2raIacDJ44JzXttV/7gigbO+ff42 HhdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=JxQYKipjr/+lQ15rbP1Crg5oVSMHPpWy4nLFjAhA7bA=; b=lv2RqNXwFrzaTwO42sl7hoHbOnTGltg8Lom6k+wPGIP5aakHz606RJQiMPw4AYR74V eCJaMRxA82ZRzKYNp6ni4lsmQIGoxWzT6k5Xuq72209f1mvkQjFFHkyAT8YCnzSnh26D KQRQP18wHkDRxNDYtdaCunTo253gslXLNK5G7xyQgItcQAVAp7g8aSxgo2FGIjzzd28T FsZ3dN+FiScwitssec9wy0hxJmXscjbeQiK+8GW3I2mvq2lTsH7tWWUqC0eKy2We6sjJ 9AQTkQDsVO9NCSxhp9zmUk9qQKSWV1EIjxWMLfxnjbp0WpHpvFpnlZ2gmAXRuCW4RrbM ocdA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p3si2754641edr.391.2020.04.28.19.08.12; Tue, 28 Apr 2020 19:08:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726523AbgD2CEj (ORCPT + 99 others); Tue, 28 Apr 2020 22:04:39 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:58130 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726158AbgD2CEi (ORCPT ); Tue, 28 Apr 2020 22:04:38 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id A0CCEB55BE340ACF03EF; Wed, 29 Apr 2020 10:04:36 +0800 (CST) Received: from linux-lmwb.huawei.com (10.175.103.112) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.487.0; Wed, 29 Apr 2020 10:04:28 +0800 From: Zou Wei To: CC: , , Zou Wei Subject: [PATCH -next] blk-mq: Use BUG_ON() instead of BUG() Date: Wed, 29 Apr 2020 10:10:24 +0800 Message-ID: <1588126224-47877-1-git-send-email-zou_wei@huawei.com> X-Mailer: git-send-email 2.6.2 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.103.112] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes coccicheck warning: block/blk-mq.c:546:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG. Fixes: 63151a449eba ("blk-mq: allow drivers to hook into I/O completion") Reported-by: Hulk Robot Signed-off-by: Zou Wei --- block/blk-mq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index bcc3a23..49a227e 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -542,8 +542,7 @@ EXPORT_SYMBOL(__blk_mq_end_request); void blk_mq_end_request(struct request *rq, blk_status_t error) { - if (blk_update_request(rq, error, blk_rq_bytes(rq))) - BUG(); + BUG_ON(blk_update_request(rq, error, blk_rq_bytes(rq))); __blk_mq_end_request(rq, error); } EXPORT_SYMBOL(blk_mq_end_request); -- 2.6.2