Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 29 Apr 2020 10:32:02 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     peng.fan@nxp.com
Cc:     s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com,
        linux-imx@nxp.com, allison@lohutok.net, info@metux.net,
        Anson.Huang@nxp.com, leonard.crestez@nxp.com, git@andred.net,
        abel.vesa@nxp.com, ard.biesheuvel@linaro.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V1 2/4] ARM: imx: cpu: drop dead code
Message-ID: <20200429023201.GJ32592@dragon>
References: <1584004645-26720-1-git-send-email-peng.fan@nxp.com>
 <1584004645-26720-3-git-send-email-peng.fan@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1584004645-26720-3-git-send-email-peng.fan@nxp.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Mar 12, 2020 at 05:17:23PM +0800, peng.fan@nxp.com wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> imx_soc_device_init is only called by i.MX6Q/SL/SX/UL/7D/7ULP.
> So we could drop the switch case for i.MX1/2/3/5 which are dead code
> that never be executed.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  arch/arm/mach-imx/cpu.c | 24 ------------------------
>  1 file changed, 24 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/cpu.c b/arch/arm/mach-imx/cpu.c
> index 2df649a84697..0302cb66134b 100644
> --- a/arch/arm/mach-imx/cpu.c
> +++ b/arch/arm/mach-imx/cpu.c
> @@ -108,30 +108,6 @@ static int __init imx_soc_device_init(void)
>  		goto free_soc;
>  
>  	switch (__mxc_cpu_type) {
> -	case MXC_CPU_MX1:
> -		soc_id = "i.MX1";
> -		break;
> -	case MXC_CPU_MX21:
> -		soc_id = "i.MX21";
> -		break;
> -	case MXC_CPU_MX25:
> -		soc_id = "i.MX25";
> -		break;
> -	case MXC_CPU_MX27:
> -		soc_id = "i.MX27";
> -		break;
> -	case MXC_CPU_MX31:
> -		soc_id = "i.MX31";
> -		break;
> -	case MXC_CPU_MX35:
> -		soc_id = "i.MX35";
> -		break;
> -	case MXC_CPU_MX51:
> -		soc_id = "i.MX51";
> -		break;
> -	case MXC_CPU_MX53:
> -		soc_id = "i.MX53";
> -		break;

The code is here to completeness.  If it doesn't get in your way, let's
just keep it.

Shawn

>  	case MXC_CPU_IMX6SL:
>  		ocotp_compat = "fsl,imx6sl-ocotp";
>  		soc_id = "i.MX6SL";
> -- 
> 2.16.4
>