Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp152444ybz; Tue, 28 Apr 2020 20:32:47 -0700 (PDT) X-Google-Smtp-Source: APiQypL+K9SUOS/90DrAM2kjIiUx6TnfxB++M+SCQdlUJIMyz9ZaYlHNxHlOC9cfvcNjGOKQxPix X-Received: by 2002:a17:906:1603:: with SMTP id m3mr755749ejd.205.1588131167351; Tue, 28 Apr 2020 20:32:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588131167; cv=none; d=google.com; s=arc-20160816; b=HEHhXGPcYv73TN0nqOBRUwa2KhA3/MEKVGjIbAEwWwMyXF0f3b3DMlWAYAkFNDaOtS 8IAqywUKk+/0vP12tzW35uRaaVmsQQJafLOZ3zUNCm/VshBNHFj9gb54ya1ENV/FNerO GTGhHtIsxgn3bzgWz/yki7JcRXjXjPEUmRodTbyCbikCAZXSkWc6xElEyTL+ksaBW+su 1BB2z+JgU755+Tk4zw3nmcEFodekjS33Iz6edfYkp3bEZX4nWzysFs3x55+SG9QMn9zq Hfrb04gYK91aqbyRYhnpw47ARAi+B70jrYwfXE+Tx7BY/Ibd0rb1EnbqXgkBZS8ch+2i oxaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=fe2BsWRvOhw/4n7R+kcaUcg5Ok3DdBPFJ57tEeZj3AM=; b=kXNnKLG0k/MXRB7++MBFVy5i2aWPZg2hS8Ek1ROMiY8xKMPUtQkgfOt4OSSwJmOflo nLyyfqpn/U0mokAlep57M6gbr/7m7uwKUHOiSl8OhyTis16g4mCcuvfMdDfOrWONweXx sKqzj/UV2qNh+S4XMxJVC28GOKaWpizqEkGsfiBbK/rQI0gQsY88vFSoFmQS3qS16l3z i4Gj62eExLn4PmbO4LXsNGVjXyz8+2PTutAvzR247Q6Op/o0LT+Fcs2PeNTdajahcTbF OkAtpEQki7kMXie20TzuDkD0sUMd6FmV3wg7PRmRKf57gt8ts43OPrw2FX1TeR4k+NiY EWGg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t7si2828752edi.315.2020.04.28.20.32.24; Tue, 28 Apr 2020 20:32:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726635AbgD2D31 (ORCPT + 99 others); Tue, 28 Apr 2020 23:29:27 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:55650 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726551AbgD2D30 (ORCPT ); Tue, 28 Apr 2020 23:29:26 -0400 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 6A0E7431E02F50010AA4; Wed, 29 Apr 2020 11:29:24 +0800 (CST) Received: from linux-lmwb.huawei.com (10.175.103.112) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Wed, 29 Apr 2020 11:29:17 +0800 From: Zou Wei To: , CC: , , Zou Wei Subject: [PATCH -next] hinic: Use kmemdup instead of kzalloc and memcpy Date: Wed, 29 Apr 2020 11:35:28 +0800 Message-ID: <1588131328-49470-1-git-send-email-zou_wei@huawei.com> X-Mailer: git-send-email 2.6.2 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.103.112] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes coccicheck warnings: drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c:452:17-24: WARNING opportunity for kmemdup drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c:458:23-30: WARNING opportunity for kmemdup Reported-by: Hulk Robot Signed-off-by: Zou Wei --- drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c index f8626df..a39cc16 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c @@ -449,18 +449,15 @@ static void recv_mbox_handler(struct hinic_mbox_func_to_func *func_to_func, return; } - rcv_mbox_temp = kzalloc(sizeof(*rcv_mbox_temp), GFP_KERNEL); + rcv_mbox_temp = kmemdup(recv_mbox, sizeof(*rcv_mbox_temp), GFP_KERNEL); if (!rcv_mbox_temp) return; - memcpy(rcv_mbox_temp, recv_mbox, sizeof(*rcv_mbox_temp)); - - rcv_mbox_temp->mbox = kzalloc(MBOX_MAX_BUF_SZ, GFP_KERNEL); + rcv_mbox_temp->mbox = kmemdup(recv_mbox->mbox, MBOX_MAX_BUF_SZ, + GFP_KERNEL); if (!rcv_mbox_temp->mbox) goto err_alloc_rcv_mbox_msg; - memcpy(rcv_mbox_temp->mbox, recv_mbox->mbox, MBOX_MAX_BUF_SZ); - rcv_mbox_temp->buf_out = kzalloc(MBOX_MAX_BUF_SZ, GFP_KERNEL); if (!rcv_mbox_temp->buf_out) goto err_alloc_rcv_mbox_buf; -- 2.6.2