Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp238631ybz; Tue, 28 Apr 2020 22:37:59 -0700 (PDT) X-Google-Smtp-Source: APiQypL6fPpYyq5NA4VSxy7X0GhkYPZwpGefklQJSrCh8tNMGODihk83Zx8Zyiq5MK2PQwH0Xn5b X-Received: by 2002:aa7:ce05:: with SMTP id d5mr1028163edv.120.1588138678948; Tue, 28 Apr 2020 22:37:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588138678; cv=none; d=google.com; s=arc-20160816; b=v2n+6Lu+q5uAzvMUEQ68qG1r90GWZZUF5gmbjJShUZtylP7o1WD5tu/kdgUeTaO/Wq L54oH3wPxKdYR9i2cC9UOQ5Sy6BS8NON8CARms1SUlln2RZVU6z4A3V94GawMp9xNudY qBsc/4kb7HxFonYuJnoKD962aLwU7wbu9m2uubGyW25I5D+DkSkrQZCFRJAwh1zexWbL idN2pXJZrWaTPS0KGBg6KJ5ToVaF54/CQiy1Sj5Qyy9JqYuUp8VWLTVlvRnk0YhRrzmi i69ER2x+e2BQYpEJPQ6l3Q9YUSzuxaf/nhm92/Tjo9/I35kS2zU94l91aVtknUHbvyPg o16g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=uXEqzsEcbNwfDyAvIWDkIbprYFShJ5zwWJri8CYrERk=; b=tHcsn0Ki6eeIqO3Dwy7zrhKcJTfOlzTIGhPn1TGiWbnGVkCbfmJxj7ZryCn/ZtOxW3 wpCRLiEviueeLlO35KmmFkJ85T4z2tSGXQjxJdM1LnHzS/4bn4BCKlpSQCe9lncsd39y IDLflBKyfO/6iJm6AIPt7iwCrDXBR2BZFBhvVUVdyGcopTyNgIfkym1/bonFSSLCp3ko Va9xI4cG+ozMUgThJL58VA9O+jtmEszIyqsWvKZ5XHJ3ceBUrBUKdbtF8DP8d3UL0v3w zvtr+LnoNtfi1JbpKw2hLEqEeL9rt4sJY5NyI/fa/vkvJuVL/mOhzA9BRDaWawJRM+UB mZtA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p17si3078213ejd.260.2020.04.28.22.37.35; Tue, 28 Apr 2020 22:37:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726516AbgD2FfD (ORCPT + 99 others); Wed, 29 Apr 2020 01:35:03 -0400 Received: from mga14.intel.com ([192.55.52.115]:35181 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726486AbgD2FfC (ORCPT ); Wed, 29 Apr 2020 01:35:02 -0400 IronPort-SDR: kNeYML+CgPmBvsKrf/YqwwXOx4P0sxfx6coHVdw9bBC5CLhG5xB+giOa26F0rCsAO9kRTznB+c tt06wcG4FOOA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2020 22:35:02 -0700 IronPort-SDR: s4NeAsRyeeP97mDZ/cj5n+fyYS8RyKuJv8U22zVY0vAzjI97LbdSn1TmcX06rXG7jPOXmHfYEA 6FGq/3el5u7Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,330,1583222400"; d="scan'208";a="459064698" Received: from ramibuso-mobl.ger.corp.intel.com (HELO localhost) ([10.249.47.170]) by fmsmga005.fm.intel.com with ESMTP; 28 Apr 2020 22:34:54 -0700 Date: Wed, 29 Apr 2020 08:34:56 +0300 From: Jarkko Sakkinen To: amirmizi6@gmail.com Cc: Eyal.Cohen@nuvoton.com, oshrialkoby85@gmail.com, alexander.steffen@infineon.com, robh+dt@kernel.org, mark.rutland@arm.com, peterhuewe@gmx.de, jgg@ziepe.ca, arnd@arndb.de, gregkh@linuxfoundation.org, benoit.houyere@st.com, eajames@linux.ibm.com, joel@jms.id.au, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, oshri.alkoby@nuvoton.com, tmaimon77@gmail.com, gcwilson@us.ibm.com, kgoldman@us.ibm.com, Dan.Morav@nuvoton.com, oren.tanami@nuvoton.com, shmulik.hager@nuvoton.com, amir.mizinski@nuvoton.com, Christophe Ricard Subject: Re: [PATCH v7 2/7] tpm: tpm_tis: Add verify_data_integrity handle toy tpm_tis_phy_ops Message-ID: <20200429053456.GE8452@linux.intel.com> References: <20200427124931.115697-1-amirmizi6@gmail.com> <20200427124931.115697-3-amirmizi6@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200427124931.115697-3-amirmizi6@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 27, 2020 at 03:49:26PM +0300, amirmizi6@gmail.com wrote: > + bool (*verify_data_integrity)(struct tpm_tis_data *data, const u8 *buf, > + size_t len); Why can't the i2c driver verify this in the end of read_bytes()? /Jarkko