Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200429053319.113508-1-pmalani@chromium.org>
In-Reply-To: <20200429053319.113508-1-pmalani@chromium.org>
From:   Prashant Malani <pmalani@chromium.org>
Date:   Tue, 28 Apr 2020 22:45:59 -0700
Message-ID: <CACeCKaesd4tbHEfM+dX=cjRMAkWEwYtqF-d7D2vvjOsECfsb1w@mail.gmail.com>
Subject: Re: [PATCH] usb: typec: mux: intel: Handle alt mode HPD_LVL
To:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc:     Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Benson Leung <bleung@chromium.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "open list:USB TYPEC CLASS" <linux-usb@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Sorry, didn't compose the Commit message quite right, have sent out v2.

Thanks,

On Tue, Apr 28, 2020 at 10:34 PM Prashant Malani <pmalani@chromium.org> wro=
te:
>
> According to the PMC Type C Subsystem (TCSS) Mux programming guide rev
> 0.6, when a device is transitioning to DP Alternate Mode state, if the
> HPD_LVL in the status update command VDO is set, the HPD_HIGH field in
> the Alternate Mode request =E2=80=9Cmode_data=E2=80=9D field (bit 14) sho=
uld also be
> set. Ensure the bit is correctly handled while issuing the Alternate
> Mode request.
>
> Signed-off-by: Prashant Malani <pmalani@chromium.org>
> Fixes: 6701adfa9693 ("usb: typec: driver for Intel PMC mux control")
> ---
>  drivers/usb/typec/mux/intel_pmc_mux.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/typec/mux/intel_pmc_mux.c b/drivers/usb/typec/mu=
x/intel_pmc_mux.c
> index f5c5e0aef66f..c599112559e7 100644
> --- a/drivers/usb/typec/mux/intel_pmc_mux.c
> +++ b/drivers/usb/typec/mux/intel_pmc_mux.c
> @@ -157,6 +157,10 @@ pmc_usb_mux_dp(struct pmc_usb_port *port, struct typ=
ec_mux_state *state)
>         req.mode_data |=3D (state->mode - TYPEC_STATE_MODAL) <<
>                          PMC_USB_ALTMODE_DP_MODE_SHIFT;
>
> +       if (data->status & DP_STATUS_HPD_STATE)
> +               req.mode_data |=3D PMC_USB_DP_HPD_LVL <<
> +                                PMC_USB_ALTMODE_DP_MODE_SHIFT;
> +
>         return pmc_usb_command(port, (void *)&req, sizeof(req));
>  }
>
> --
> 2.26.2.303.gf8c07b1a785-goog
>