Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp315505ybz; Wed, 29 Apr 2020 00:22:24 -0700 (PDT) X-Google-Smtp-Source: APiQypJdkyOWYoovMsu9ZtkpC0zTFMoB29+DH3QmEZvAvA197hOcvHXpA4JOp5OyVNW2WzL1nbJA X-Received: by 2002:a17:906:85c2:: with SMTP id i2mr1395722ejy.147.1588144944251; Wed, 29 Apr 2020 00:22:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588144944; cv=none; d=google.com; s=arc-20160816; b=cWrZETqr6QhpTkrhdJ+W3OmXHFdCHZ7ppCidtqsSNwsfz0FBt0Ha2UvtU4UZm4jvBj 6uMSnu70r0t3SeHqVx5Uvn13iLQvf3xI8rTrAA4qL+2ZarJz9eWeMXjXWTxCwGAYbr69 YiVTIC6WTYBYpKKYh0O2OZfVj/OKSYJ0mHmpmIlZUETx70jyQPKG2l6FY+Be8pL0njVV 85Lk/SIIpgn5IhFmoNe5UIK1+FT0/9NXOc3/qks9EL2dhxqZsdKi4LIh00Axi0Dj2CEO TGduFukCl3qWCgEmDbYNrgYT7EhXXy1gc0ThAxLYGvg5NzZ5xVXB2iK92s9huEPOu4fI oQ7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:ironport-sdr:ironport-sdr; bh=5SeqmJHMdkCESJtA0cOM9SIsVjhHxh7sDLRbg4JiQ/M=; b=F48qyl0iqyXj0VowINjQYL/WbDlsSgqhf/QFB/DYKfWA5u+DB18JDBLvcZeefPWG55 MmA+D/svyOZPRX98k5L5tlxImcVuqswM2GKNpLF7AX2oE1XuuOJYy3CcTtP5+z0xwqw3 nF5xcUSrAY1VXi37rHeYUNZVIU41yEXIX27KMMhEtbSnneAVuGeTRCe3Y5bNafQ9Idiv Rt1E2hcPY2DUWdihPmkPUVLBVd5NLAQK9x07DKprF2xfKoFKIOgU3BV4KSPflTGQTNcv kS123cRfGForjc+fiMZZzkdeRBLdU29++88VrLlApWSJeR2wG1jxEYuBryS6KTRo5pSH hkrA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cc27si3592273edb.544.2020.04.29.00.21.59; Wed, 29 Apr 2020 00:22:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726457AbgD2HUa (ORCPT + 99 others); Wed, 29 Apr 2020 03:20:30 -0400 Received: from mga18.intel.com ([134.134.136.126]:53723 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726366AbgD2HUa (ORCPT ); Wed, 29 Apr 2020 03:20:30 -0400 IronPort-SDR: hldEkLBas8zKC6Zpdsj1fU7GfCOTMYn9w5vnw/ab35rD0fuBG2iv/d/Gwa0U0D4F48ldzb7ivS aFWuInY3Y5EA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2020 00:20:25 -0700 IronPort-SDR: QPa7dHTv8XQQJsIZN5cmsH7yNXzMZPGce0fOF6mMDVpLMYW3rZskWmYi79w7kHtpz65X8ogfOL mI6pifLqNZWg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,330,1583222400"; d="scan'208";a="459496148" Received: from linux.intel.com ([10.54.29.200]) by fmsmga006.fm.intel.com with ESMTP; 29 Apr 2020 00:20:25 -0700 Received: from [10.215.242.51] (ekotax-mobl.gar.corp.intel.com [10.215.242.51]) by linux.intel.com (Postfix) with ESMTP id 355A4580619; Wed, 29 Apr 2020 00:20:21 -0700 (PDT) Subject: Re: [PATCH 1/4] spi: lantiq: Synchronize interrupt handlers and transfers To: Mark Brown Cc: robh@kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, daniel.schwierzeck@gmail.com, hauke@hauke-m.de, andriy.shevchenko@intel.com, cheol.yong.kim@intel.com, chuanhua.lei@linux.intel.com, qi-ming.wu@intel.com References: <3bf88d24b9cad9f3df1da8ed65bf55c05693b0f2.1587702428.git.eswara.kota@linux.intel.com> <20200424112505.GD5850@sirena.org.uk> <616a5419-add3-085e-32dc-c83d9d975725@linux.intel.com> <20200427134555.GC4383@sirena.org.uk> <43ecffb1-4786-c038-09bb-648657c0f5f3@linux.intel.com> <20200428100055.GB5677@sirena.org.uk> From: Dilip Kota Message-ID: <68948cb1-6c78-1545-45c6-5a95465b05e2@linux.intel.com> Date: Wed, 29 Apr 2020 15:20:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200428100055.GB5677@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/28/2020 6:00 PM, Mark Brown wrote: > On Tue, Apr 28, 2020 at 01:39:06PM +0800, Dilip Kota wrote: > >> Do you suggest to use different ISRs for multiple interrupt lines and single >> ISR for single interrupt line? I see, this results in writing repetitive >> code lines. > It looks like the shared case is mainly a handler that calls the two > other handlers? Yes. > >> Does single ISR looks erroneous! Please let me know. > The change was not entirely clear, I was having trouble convincing > myself that all the transformations were OK partly because I kept on > finding little extra changes in there and partly because there were > several things going on. In theory it could work. You want me to split this in to multiple patches? Regards, Dilip