Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp379028ybz; Wed, 29 Apr 2020 01:47:17 -0700 (PDT) X-Google-Smtp-Source: APiQypKPB1kFdvp/xA5E5blmEhDp0xvrBSMgw4OsDSEjFoEDhc0vcF735l5osiDoYXC+OWH1U5th X-Received: by 2002:a50:c3c2:: with SMTP id i2mr1481199edf.227.1588150037517; Wed, 29 Apr 2020 01:47:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588150037; cv=none; d=google.com; s=arc-20160816; b=ZIar+lomzf7IVZ2BmtoY/VfdlP96VvjD4h6h4qULT3agtTcOf5F1QSu4eyooESTdf1 I8ubKjShu1yK/0IdpC6lDSWAe6UnOqGIczcD/3+TJEfMd9bpt1/kU6e6qj56CR7/zD08 nAQ/bQB+89aKaufmX6WJcf1EK8JaKAgigyPyOZ2uOdQ62LOmzBDLi0sKCVFUOpYAx2yC p/riEoFgx279szui8kKTOlXH2MvsWpiJcC9DvodTaf4zcyQHULICqS0Wyj+F/7SNdO9h bZD7mCdMp+x4/vJJHzeBhFjcf4Pe393E3/9mbGSAaH754VrDpSybHYEKybdIwN3cdKsl XmjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=ikKc7g7MxMh3zXinWkeIoZ3SkQjBdcfdfhlAWMlsFxY=; b=GGbNq8uMZzfXeoBHBQbuCk+pLSnV7T7/gIGKfo/STXVbgKJZOqATXFIoKqaDkb/yLO dFMLH++l9X40/MgjQbOWx3WvU2WGaKBaUqJHqsG0SlffPV3eNhZm/VifxmfeIX/7hFvV OykUFBPzsEWtkHnql1CNvfFUknsgp8uNDvpKNAMnT4MQhBnroYMq4sDsz2tflsGpj2uG 7uc+CUEsnQ4u6lKMQpGQ0EF4FMTHRpBOPxr6nCBxkUMpwZUhKav/Z++JY0VULxBB85l2 TIUCuDqSkRRyKrvpZwg0OkkgedR9eLRHMzjIJDMVMpKSwl35Cr3wNwrEZUfWBDEX3wI/ 5TCQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t26si2961863edw.567.2020.04.29.01.46.53; Wed, 29 Apr 2020 01:47:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726560AbgD2IpN (ORCPT + 99 others); Wed, 29 Apr 2020 04:45:13 -0400 Received: from smtp02.smtpout.orange.fr ([80.12.242.124]:48392 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726345AbgD2IpN (ORCPT ); Wed, 29 Apr 2020 04:45:13 -0400 Received: from localhost.localdomain ([92.148.159.11]) by mwinf5d03 with ME id YYl72200G0F2omL03Yl75P; Wed, 29 Apr 2020 10:45:11 +0200 X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Wed, 29 Apr 2020 10:45:11 +0200 X-ME-IP: 92.148.159.11 From: Christophe JAILLET To: b.zolnierkie@samsung.com, sumit.semwal@linaro.org, rafael.j.wysocki@intel.com, corbet@lwn.net, viresh.kumar@linaro.org, jani.nikula@intel.com, mchehab+samsung@kernel.org, eric.miao@marvell.com Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] video: pxafb: Fix the function used to balance a 'dma_alloc_coherent()' call Date: Wed, 29 Apr 2020 10:45:05 +0200 Message-Id: <20200429084505.108897-1-christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 'dma_alloc_coherent()' must be balanced by a call to 'dma_free_coherent()' not 'dma_free_wc()'. The correct dma_free_ function is already used in the error handling path of the probe function. Fixes: 77e196752bdd ("[ARM] pxafb: allow video memory size to be configurable") Signed-off-by: Christophe JAILLET --- drivers/video/fbdev/pxafb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c index 00b96a78676e..6f972bed410a 100644 --- a/drivers/video/fbdev/pxafb.c +++ b/drivers/video/fbdev/pxafb.c @@ -2417,8 +2417,8 @@ static int pxafb_remove(struct platform_device *dev) free_pages_exact(fbi->video_mem, fbi->video_mem_size); - dma_free_wc(&dev->dev, fbi->dma_buff_size, fbi->dma_buff, - fbi->dma_buff_phys); + dma_free_coherent(&dev->dev, fbi->dma_buff_size, fbi->dma_buff, + fbi->dma_buff_phys); return 0; } -- 2.25.1