Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: K8AboDQXsW8YZoXYONZzkIizxiyiNkRHbVOEogmdF86aRc06DTu2amOAD3i/LB4jfRbhjfsz1z
 5Mv3iajYFj2Q==
From:   SeongJae Park <sjpark@amazon.com>
To:     Jonathan Cameron <Jonathan.Cameron@Huawei.com>
CC:     SeongJae Park <sjpark@amazon.com>, <akpm@linux-foundation.org>,
        "SeongJae Park" <sjpark@amazon.de>, <aarcange@redhat.com>,
        <acme@kernel.org>, <alexander.shishkin@linux.intel.com>,
        <amit@kernel.org>, <benh@kernel.crashing.org>,
        <brendan.d.gregg@gmail.com>, <brendanhiggins@google.com>,
        <cai@lca.pw>, <colin.king@canonical.com>, <corbet@lwn.net>,
        <dwmw@amazon.com>, <irogers@google.com>, <jolsa@redhat.com>,
        <kirill@shutemov.name>, <mark.rutland@arm.com>, <mgorman@suse.de>,
        <minchan@kernel.org>, <mingo@redhat.com>, <namhyung@kernel.org>,
        <peterz@infradead.org>, <rdunlap@infradead.org>,
        <riel@surriel.com>, <rientjes@google.com>, <rostedt@goodmis.org>,
        <sblbir@amazon.com>, <shakeelb@google.com>, <shuah@kernel.org>,
        <sj38.park@gmail.com>, <snu@amazon.de>, <vbabka@suse.cz>,
        <vdavydov.dev@gmail.com>, <yang.shi@linux.alibaba.com>,
        <ying.huang@intel.com>, <linux-damon@amazon.com>,
        <linux-mm@kvack.org>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PATCH v9 00/15] Introduce Data Access MONitor (DAMON)
Date:   Wed, 29 Apr 2020 12:10:19 +0200
Message-ID: <20200429101019.26299-1-sjpark@amazon.com>
In-Reply-To: <20200429101806.000002f4@Huawei.com> (raw)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 29 Apr 2020 10:18:06 +0100 Jonathan Cameron <Jonathan.Cameron@Huawei.com> wrote:

> On Wed, 29 Apr 2020 09:49:54 +0200
> SeongJae Park <sjpark@amazon.com> wrote:
> 
> > On Tue, 28 Apr 2020 17:17:13 +0100 Jonathan Cameron <Jonathan.Cameron@Huawei.com> wrote:
> > 
> > > On Tue, 28 Apr 2020 15:23:42 +0200
> > > SeongJae Park <sjpark@amazon.com> wrote:
> > >   
> > > > On Tue, 28 Apr 2020 13:27:04 +0100 Jonathan Cameron <Jonathan.Cameron@Huawei.com> wrote:
> > > >   
> > > > > On Mon, 27 Apr 2020 14:04:27 +0200
> > > > > SeongJae Park <sjpark@amazon.com> wrote:
> > > > >     
> > > > > > From: SeongJae Park <sjpark@amazon.de>
> > > > > > 
> > > > > > Introduction
> > > > > > ============
> > > > > > 
[...]
> > 
> > Appreciate your explanations and suggestions.
> 
> You are welcome.
> 
> Out of interest, do you have any comparative data on how 'accurate' the resulting
> estimates are vs a more precise heatmap from a memory trace?

No, I don't have such data.

I'm only comparing the big trends of heatmap, working set sizes analyzed from
the recorded access pattern and the DAMOS performance results for each version
using my human eye, to check regression.

> 
> I'm looking at gathering such data but much happier to leverage your work if
> you've already done it!

That would be great.  If I get such data later, I will let you know.  I will be
also very happy if you could get it first and share with me.

Maybe we could make and use another variant of DAMON, which uses page-size
regions only and disable the adaptive regions adjustment.  It will be also
useful for overhead comparison.  Actually, I heard that my previous colleague
made this variant for the comparison based on a prototype of DAMON.  I will
also consider extending DAMON to support such variant.

Also, if you need the heatmaps, analyzed working set size distribution, and/or
the record file itself for each version of the patchsets, please let me know.


Thanks,
SeongJae Park