Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 3IM+E+WeE7+4VkJwoxzrB9BZH/FghVldTZDBMh/hAJ66IYSWnFsXUT1fAw5/Uv2964DspL7cIm
 MEQgNmVnTo1w==
IronPort-SDR: eE+O1+6e1XtGtd8JUdDlakeYwWPFk4LNtvwubLqQnCneIupXarg2zWhgxwP/6zJHH+XbmHkf8n
 cqRnVG+imodg==
Date:   Wed, 29 Apr 2020 13:17:42 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Syed Nayyar Waris <syednwaris@gmail.com>
Cc:     akpm@linux-foundation.org, vilhelm.gray@gmail.com,
        rrichter@marvell.com, linus.walleij@linaro.org,
        bgolaszewski@baylibre.com, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/4] gpio: thunderx: Utilize for_each_set_clump macro
Message-ID: <20200429101742.GE185537@smile.fi.intel.com>
References: <cover.1588112714.git.syednwaris@gmail.com>
 <ea25f5cbe03a3bb4bf5d976b004d87c4bab178e3.1588112716.git.syednwaris@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ea25f5cbe03a3bb4bf5d976b004d87c4bab178e3.1588112716.git.syednwaris@gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 29, 2020 at 04:37:41AM +0530, Syed Nayyar Waris wrote:
> This patch reimplements the thunderx_gpio_set_multiple function in
> drivers/gpio/gpio-thunderx.c to use the new for_each_set_clump macro.
> Instead of looping for each bank in thunderx_gpio_set_multiple
> function, now we can skip bank which is not set and save cycles.

> +	const unsigned long bank_size = 64;

Shouldn't be rather definition?

-- 
With Best Regards,
Andy Shevchenko