Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: A5n8sHPjzXSV90RQUd8OoPTBisaLaZ/Xn5bHSOwPiYU9gu7iTz/ksO9Ox9gcNbk/qSzPSkRWuh
 O4c0Ux8Z6Q/Q==
IronPort-SDR: H4zHciGZTwYi0gg8aA1WCO3C5ckFgJATsv5r/mqRZlt7JSKQc1dSJPRMfxa+/MPcZIYu+qdb96
 9gBzOwzMvdWg==
Date:   Wed, 29 Apr 2020 13:22:47 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Jules Irenge <jbi.octave@gmail.com>
Cc:     linux-kernel@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Shannon Nelson <snelson@pensando.io>,
        Thomas Gleixner <tglx@linutronix.de>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        "open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>
Subject: Re: [PATCH 6/6] net: atm: Add annotation for lec_priv_walk()
Message-ID: <20200429102247.GG185537@smile.fi.intel.com>
References: <0/6>
 <20200429100529.19645-1-jbi.octave@gmail.com>
 <20200429100529.19645-7-jbi.octave@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200429100529.19645-7-jbi.octave@gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 29, 2020 at 11:05:28AM +0100, Jules Irenge wrote:
> Sparse reports a warning at lec_priv_walk()
> warning: context imbalance in lec_priv_walk() - unexpected unlock
> 
> The root cause is the missing annotation at lec_priv_walk()
> To fix this, __acquire() and __release() annotations
> are added in case conditions are not met.
> This only instruct  Sparse to shutdown the warning
> 
> Add the  __acquire(&priv->lec_arp_lock)
> Add __release(&priv->lec_arp_lock) annotation

At least those two I got should be in one patch. Simple fix all same sparse
issues at once.

-- 
With Best Regards,
Andy Shevchenko