Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp505100ybz; Wed, 29 Apr 2020 04:22:38 -0700 (PDT) X-Google-Smtp-Source: APiQypIsJlaizLVPCfb9K6q4iQdxLZuMgZL80XnEGl+QE3nnQSWhgNvwsZ1n/5oOcCS0zR/QG6jd X-Received: by 2002:a17:906:1dce:: with SMTP id v14mr2189899ejh.244.1588159358389; Wed, 29 Apr 2020 04:22:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588159358; cv=none; d=google.com; s=arc-20160816; b=mMsHpBjSpBYfSZ5/KMdBzSoANEpg/hK9CHJECJ0SISguIM19QyI8dxDKBKQNTB3psB rJaJHwNwAfS5fpk5zHLlBKd+ePpfdC04535x7g3KnEsVWn9txG6nsBpPRiRbChk7wH4e TrMYIoI8OzdWFbB57tCpUo8nFoy8jt13M50qMaKJZa0KlpmMN/zTNQTtjuVDV0OOPQrM hPW8QDedDmzm/7KzoWutoAIbyLUsEFJbm9Eii9k+mDTKl9QTlP5husJimO1nuNUa3/+g 9eUyMSgpw+wXEplNhZHXeOkJ2SgzG2TdboIFbW+IZYiI/g11WDE6jade0hJgd84hVEDJ jRgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=edQRYOZC7+bGzu4klieEhzueP0ff7UULya+SzfH1TFk=; b=sCF4y3daU4+DuoZQrCNizzxmFUgPLzfkIGBpzuUeephNIEfwprHahtDAcYK6Pbq4Y9 4S35Wh6JjW0seFyY98UlJusGMoTT7TfpkqcDFapocvg5nELGPeDGAsBZS9xRK0oyB/IA 3SZgRqXPONuHgf33J73NXYEUvbw1pT1u3XO4eitiOUuO48L7QcKAEXNx1e7L9Q+wuOe1 k86jcr8vCOp8tmAtTmSiDl6h4vx1JmGSaXciqf+ys55BcFAagWWRVvi+VsaVs+e8lAhG CXq3CJG+FwisFh/r7zHGSWXKlKrnpavv26yC46JQbAXTUHOwdXbz1clDO62Wn2ZL5YMA JAFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=XXorFLsX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q28si3211041edb.547.2020.04.29.04.22.14; Wed, 29 Apr 2020 04:22:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=XXorFLsX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726743AbgD2LUk (ORCPT + 99 others); Wed, 29 Apr 2020 07:20:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726554AbgD2LUj (ORCPT ); Wed, 29 Apr 2020 07:20:39 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BC15C03C1AD; Wed, 29 Apr 2020 04:20:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=edQRYOZC7+bGzu4klieEhzueP0ff7UULya+SzfH1TFk=; b=XXorFLsXqdHVXmLrX+9IgfnsxQ 5VLCAPMu/Ppvt+f7r7KKi+BXdFnbn6eoofTEEHqmnmxyP47UtfKApzzHBpr7xrYb273cYgiK/raqU /QI4/Z9+k8Qw7QlNW/XrHrjdxaFsADhn+n5jdUp3fBrZeWrn5gfycmpoTuk7rukv4Nbi6VV44KpAa zEvEuRElKH0NUlIXmCdJq0nvHN0IhhErjVVy4+W7KPONRtI+tiullzIrhJtW9w9cpkR7HJ+FJftff x7v9M98q5EvMoQC+a8ZnQBxaSsENgO5Q37JM81dCortelI7S3lJsA+nw6wELukZZHb0PObFYU5uFr nfJLVJTw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTklD-0004CL-B7; Wed, 29 Apr 2020 11:20:15 +0000 Date: Wed, 29 Apr 2020 04:20:15 -0700 From: Christoph Hellwig To: Luis Chamberlain Cc: axboe@kernel.dk, viro@zeniv.linux.org.uk, bvanassche@acm.org, gregkh@linuxfoundation.org, rostedt@goodmis.org, mingo@redhat.com, jack@suse.cz, ming.lei@redhat.com, nstange@suse.de, akpm@linux-foundation.org, mhocko@suse.com, yukuai3@huawei.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/6] blktrace: move blktrace debugfs creation to helper function Message-ID: <20200429112015.GC21892@infradead.org> References: <20200429074627.5955-1-mcgrof@kernel.org> <20200429074627.5955-4-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200429074627.5955-4-mcgrof@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 29, 2020 at 07:46:24AM +0000, Luis Chamberlain wrote: > Move the work to create the debugfs directory used into a helper. > It will make further checks easier to read. This commit introduces > no functional changes. > > Signed-off-by: Luis Chamberlain Looks good, Reviewed-by: Christoph Hellwig