Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp517885ybz; Wed, 29 Apr 2020 04:37:18 -0700 (PDT) X-Google-Smtp-Source: APiQypIIUvgiIz//4qvHfMtl6tv8+FzrfZyuOFUehY/Q4KxoX/vfRZnyRX2GHHnwxsb1duag+JiO X-Received: by 2002:a50:d6d0:: with SMTP id l16mr2042393edj.317.1588160238671; Wed, 29 Apr 2020 04:37:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588160238; cv=none; d=google.com; s=arc-20160816; b=qhDkH0cVXsGP7O6GX5EUlCD66RqRy77/bVCZULSJu7J2c//Pn2UIDkVr8+hIgrSM1s wNDjxhELQ5lCKL7Crm5AigAlOmot8IVtkBXv/jSu2TSwWdx/umVkfbfCnzGAr+zioL35 YEHFl7r6n6OnLR6p+R0g2LI4Sm4FK+VqF57JFC8MhtU5eBCV2XFK9cQeoxh4HrGNf3JP If6a63PUAN57Ce897uRfHxKs+jVcglT33hMafBZoz4qHAAwfSMMxgLzP1cy6FeeioU3H Dng6wvbFnpjChU3o9ldYkWaBKwrzYRnFqetNE06U+e9NWAhVK951yIdIkEv38y1k9rxd WFWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=KfZ825FvT2I2g+qBInw2N3eIvp4QmMQURWdPiiPQJE0=; b=bUgHwNeBBgS0HyCfiOxHK7MgB02/3RG9aP5Jxr2ozcZw3vgS0dSgHGxuFEsucJ2AKq 0g+fJsm0IHWEbTGH9THq+MMzg8ClWNyc/6xF+uPFfFdL/OvTCQua8DGt2lLytWVm5ftp dSGF3OrBecysb1ivdrzowcVNhdqb2DCjY4SwRDayw5ZmWGCiaDwSPer1PQmY1agb8cUg ArmSTJslkR9wmiJr7HAkaorgVHXOT+aXInkBxuN+g8nYsRTOEli9H3rqshn4HB89Y7oc Ea392xanyoV9pORLS5dRa8ijzAOPuHYn4GaA6MqhdPcJ1EmSx5RfP++D171pYUU75/vY HpWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f21si3287121edc.246.2020.04.29.04.36.56; Wed, 29 Apr 2020 04:37:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726911AbgD2LdP (ORCPT + 99 others); Wed, 29 Apr 2020 07:33:15 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:60782 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726345AbgD2LdN (ORCPT ); Wed, 29 Apr 2020 07:33:13 -0400 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 249EA2A0BDD; Wed, 29 Apr 2020 12:33:11 +0100 (BST) Date: Wed, 29 Apr 2020 13:33:08 +0200 From: Boris Brezillon To: "Ramuthevar,Vadivel MuruganX" Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, arnd@arndb.de, brendanhiggins@google.com, tglx@linutronix.de, anders.roxell@linaro.org, masonccyang@mxic.com.tw, robh+dt@kernel.org, linux-mips@vger.kernel.org, hauke.mehrtens@intel.com, andriy.shevchenko@intel.com, qi-ming.wu@intel.com, cheol.yong.kim@intel.com Subject: Re: [PATCH v4 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC Message-ID: <20200429133308.4f91c35c@collabora.com> In-Reply-To: <20200429104205.18780-3-vadivel.muruganx.ramuthevar@linux.intel.com> References: <20200429104205.18780-1-vadivel.muruganx.ramuthevar@linux.intel.com> <20200429104205.18780-3-vadivel.muruganx.ramuthevar@linux.intel.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Apr 2020 18:42:05 +0800 "Ramuthevar,Vadivel MuruganX" wrote: > +#define NAND_WRITE_CMD (EBU_CON_CS_P_LOW | HSNAND_CLE_OFFS) > +#define NAND_WRITE_ADDR (EBU_CON_CS_P_LOW | HSNAND_ALE_OFFS) > + I thought we agreed on dropping those definitions.