Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 29 Apr 2020 13:46:24 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Jernej =?utf-8?Q?=C5=A0krabec?= <jernej.skrabec@siol.net>
Cc:     Chen-Yu Tsai <wens@csie.org>, Robin Murphy <robin.murphy@arm.com>,
        =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= <peron.clem@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux-ALSA <alsa-devel@alsa-project.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-sunxi <linux-sunxi@googlegroups.com>,
        Takashi Iwai <tiwai@suse.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Marcus Cooper <codekipper@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [linux-sunxi] Re: Audio sound card name [was [PATCH 4/7] arm64:
 dts: allwinner: a64: Add HDMI audio]
Message-ID: <20200429114624.42chsbmnsk36jtqw@gilmour.lan>
References: <20200426120442.11560-1-peron.clem@gmail.com>
 <20200429081729.qa3gqtl5sof2jhem@gilmour.lan>
 <f9b701d9-0c4e-6e41-1ce8-52adf0f59a2a@arm.com>
 <2545943.S5iK65abk1@jernej-laptop>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="ksk6gvoylw54ps5r"
Content-Disposition: inline
In-Reply-To: <2545943.S5iK65abk1@jernej-laptop>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--ksk6gvoylw54ps5r
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 29, 2020 at 12:53:49PM +0200, Jernej =C5=A0krabec wrote:
> Dne sreda, 29. april 2020 ob 12:43:06 CEST je Robin Murphy napisal(a):
> > On 2020-04-29 9:17 am, Maxime Ripard wrote:
> > > On Wed, Apr 29, 2020 at 02:24:00PM +0800, Chen-Yu Tsai wrote:
> > >> On Wed, Apr 29, 2020 at 1:11 AM Robin Murphy <robin.murphy@arm.com>=
=20
> wrote:
> > >>> On 2020-04-28 5:49 pm, Cl=C3=A9ment P=C3=A9ron wrote:
> > >>>> Hi Mark, Rob,
> > >>>>=20
> > >>>> On Tue, 28 Apr 2020 at 18:04, Maxime Ripard <maxime@cerno.tech> wr=
ote:
> > >>>>> On Tue, Apr 28, 2020 at 10:54:00AM +0200, Cl=C3=A9ment P=C3=A9ron=
 wrote:
> > >>>>>> Hi Maxime,
> > >>>>>>=20
> > >>>>>> On Tue, 28 Apr 2020 at 10:00, Maxime Ripard <maxime@cerno.tech>=
=20
> wrote:
> > >>>>>>> On Sun, Apr 26, 2020 at 02:04:39PM +0200, Cl=C3=A9ment P=C3=A9r=
on wrote:
> > >>>>>>>> From: Marcus Cooper <codekipper@gmail.com>
> > >>>>>>>>=20
> > >>>>>>>> Add a simple-soundcard to link audio between HDMI and I2S.
> > >>>>>>>>=20
> > >>>>>>>> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> > >>>>>>>> Signed-off-by: Marcus Cooper <codekipper@gmail.com>
> > >>>>>>>> Signed-off-by: Cl=C3=A9ment P=C3=A9ron <peron.clem@gmail.com>
> > >>>>>>>> ---
> > >>>>>>>>=20
> > >>>>>>>>    arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 21
> > >>>>>>>>    +++++++++++++++++++
> > >>>>>>>>    1 file changed, 21 insertions(+)
> > >>>>>>>>=20
> > >>>>>>>> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > >>>>>>>> b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index
> > >>>>>>>> e56e1e3d4b73..08ab6b5e72a5 100644
> > >>>>>>>> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > >>>>>>>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > >>>>>>>> @@ -102,6 +102,25 @@
> > >>>>>>>>=20
> > >>>>>>>>                 status =3D "disabled";
> > >>>>>>>>        =20
> > >>>>>>>>         };
> > >>>>>>>>=20
> > >>>>>>>> +     hdmi_sound: hdmi-sound {
> > >>>>>>>> +             compatible =3D "simple-audio-card";
> > >>>>>>>> +             simple-audio-card,format =3D "i2s";
> > >>>>>>>> +             simple-audio-card,name =3D "allwinner,hdmi";
> > >>>>>>>=20
> > >>>>>>> I'm not sure what the usual card name should be like though. I =
would
> > >>>>>>> assume that this should be something specific enough so that yo=
u're
> > >>>>>>> able to differentiate between boards / SoC so that the userspace
> > >>>>>>> can choose a different configuration based on it?
> > >>>>>>=20
> > >>>>>> I really don't know what we should use here,
> > >>>>>> I just have a look at other SoC:
> > >>>>>> rk3328: "HDMI"
> > >>>>>> rk3399: "hdmi-sound"
> > >>>>>> r8a774c0-cat874: "CAT874 HDMI sound"
> > >>>>>>=20
> > >>>>>> But maybe it's time to introduce proper name:
> > >>>>>> What about :
> > >>>>>> pat
> > >>>>>> sun50i-h6-hdmi
> > >>>>>=20
> > >>>>> It's pretty much what we've been using for the other sound cards =
we
> > >>>>> have, so it makes sense to me.
> > >>>>=20
> > >>>> I have a question regarding the simple-audio-card,name.
> > >>>> In this patch, I would like to introduce a simple-audio-card for t=
he
> > >>>> Allwinner A64 HDMI.
> > >>>>=20
> > >>>> What should be the preferred name for this sound card?
> > >>>> "sun50i-a64-hdmi" ? "allwinner, sun50i-a64-hdmi" ?
> > >>>=20
> > >>> I can at least speak for RK3328, and the reasoning there was that a=
s the
> > >>> user looking at what `aplay -l` says, I don't give a hoot about wha=
t the
> > >>> SoC may be called, I see two cards and I want to know, with the lea=
st
> > >>> amount of uncertainty, which one will make the sound come out of the
> > >>> port that's labelled "HDMI" on the box ;)
> > >>=20
> > >> I agree. The user really doesn't care what SoC the system uses. The =
only
> > >> real requirement is to be able to tell which output the card is rela=
ted
> > >> to, i.e. is it onboard or an external DAC, is it analog or HDMI, etc=
=2E.
> > >=20
> > > Yeah, but it's exactly the point.
> > >=20
> > > If we also end up with "HDMI" as our card name, then the userspace ha=
s no
> > > way to tell anymore if it's running from an rk3328 or an allwinner So=
C,
> > > or something else entirely. And therefore it cannot really configure
> > > anything to work out of the box anymore.
> >=20
> > OK, you're a userspace audio application - enlighten me as to what exact
> > chip you're running on here, and why you need to know:
> >=20
> > card 0: HDMI [HDA ATI HDMI]
> >=20
> > or how about here?
> >=20
> > card 0: Intel [HDA Intel]
> >=20
> >=20
> > Furthermore, your argument works both ways - if the equivalent (or in
> > common cases like DesignWare IP blocks, exact same) thing across 3
> > different SoCs has 3 different names, then it's that much harder for
> > userspace that wants to present a consistent behaviour. I don't know
> > exactly why LibreELEC have downstream patches that standardise all the
> > Rockchip ones to "HDMI", but I can't help noting that they do.
> >=20
> > With simple-audio-card we're talking about trivial interfaces that often
> > don't expose any controls at all, so there's unlikely to be much
> > 'configuration' for userspace to do beyond choosing which card to outpu=
t to.
>=20
> Only difference is slightly different version of HDMI controller and diff=
erent
> This combination (DesignWare HDMI controller + I2S) is same as on Rockchi=
p.
> I2S core.

Well, that fact only is already information that is not carried on to the
userspace. Think about it this way: let's say you run Debian, you just inst=
alled
it without any configuration, and you don't have any knowledge about the
hardware, you're just a user. Can the OS know how to configure that output =
based
on the card name "HDMI" alone?

HDMI is an easy one compared to the i2s + codec combinations we might have,=
 but
it already has some interesting differences between hardwares. For example,=
 the
RPi iirc needs an IEC958 format, while this one works just fine with a stan=
dard
PCM format.

Maxime

--ksk6gvoylw54ps5r
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXqlpEAAKCRDj7w1vZxhR
xceuAQD7ZQuXykpB0izmXzhIHRMLAEuqdSkBj//F5pIRAU3Y9AEAvovq1h0wrKWg
oGOAHmXqkZsagk6Icg0LvTMvw26v0QA=
=eKGm
-----END PGP SIGNATURE-----

--ksk6gvoylw54ps5r--