Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <5EA96AE8.6000707@cn.fujitsu.com>
Date:   Wed, 29 Apr 2020 19:54:16 +0800
From:   Xiao Yang <yangx.jy@cn.fujitsu.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.2; zh-CN; rv:1.9.2.18) Gecko/20110616 Thunderbird/3.1.11
MIME-Version: 1.0
To:     Steven Rostedt <rostedt@goodmis.org>
CC:     "Joel Fernandes (Google)" <joel@joelfernandes.org>,
        <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH] kernel/trace: Stop and wait for kthread on preempt irq
 module unload
References: <20200424223630.224895-1-joel@joelfernandes.org>    <5EA80319.7080005@cn.fujitsu.com>       <20200428104409.0995ceb0@gandalf.local.home> <20200428104543.3926eaaf@gandalf.local.home>
In-Reply-To: <20200428104543.3926eaaf@gandalf.local.home>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020/4/28 22:45, Steven Rostedt wrote:
> diff --git a/kernel/trace/preemptirq_delay_test.c b/kernel/trace/preemptirq_delay_test.c
>>  index 1c28ca20e30b..6d9131ae7e8c 100644
>>  --- a/kernel/trace/preemptirq_delay_test.c
>>  +++ b/kernel/trace/preemptirq_delay_test.c
>>  @@ -113,15 +113,27 @@ static int preemptirq_delay_run(void *data)
>>
>>    	for (i = 0; i<  s; i++)
>>    		(testfuncs[i])(i);
>>  +
>>  +	while (!kthread_should_stop()) {
>>  +		schedule();
>>  +		set_current_state(TASK_INTERRUPTIBLE);
>>  +	}
>>  +
>>  +	__set_current_state(TASK_RUNNING);
>>  +
>>    	return 0;
>>    }
>>
Hi Steven,

Thanks for your patch.

I also used the following steps to do test and didn't get any 
warning/panic after applying your patch.
---------------------------------
for i in $(seq 1 100); do modprobe preemptirq_delay_test test_mode=irq 
delay=500000; rmmod preemptirq_delay_test; done
for i in $(seq 1 100); do modprobe preemptirq_delay_test 
test_mode=preempt delay=500000; rmmod preemptirq_delay_test; done
---------------------------------

But I am not sure which fix(from you and Joel) is better.

Thanks,
Xiao Yang