Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp546354ybz;
        Wed, 29 Apr 2020 05:09:14 -0700 (PDT)
X-Google-Smtp-Source: APiQypLyFEXNofjcyeHV6SV68BVZO41Ucjtk/Mb3XUNtp5wDJpp0oG4MMkrgl0qzzIoBXkhUIBCM
X-Received: by 2002:aa7:ca48:: with SMTP id j8mr2007531edt.328.1588162153944;
        Wed, 29 Apr 2020 05:09:13 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1588162153; cv=none;
        d=google.com; s=arc-20160816;
        b=PvOxtOuSEuYMyzoWQIjFOGNNYjYoDFtoLMKBe3DV/6wPt2EWLyLbQI6WOX5A8vU39w
         +Jcl3JIFYbGgV+/gK0m3gZeMgMoH7v+Q7fxV/xgzRmGIphLhMzElVL9AMamzpeeo5Smd
         WUFSw7hyWTj/h8s+g3y7StKuDaQ1e1ZmaXDhFqZIFQdqd15mHPxxt+fFmKr00htB8Z68
         T0yMujSpCKeDtEr9SJX+x6ACitPcNlV4LyOPTNEOTioN228x8iOiEc9pW4lMHXXE966/
         XCm9Wg9iliIeQqd7oPzwXii6ozCNIhdJcZORVLZ9oUcdrvUhkETbUa9g3Zo1E8bVjP3W
         S77A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=O385uY4zHGIJRbWSoL99UmJmEY6lnZgJqFnu8+7Cu40=;
        b=DPBs3OEMItzOzm70Po5WtXF2uJxSgbEuk64qxlNcKU/0zK7t1MWvXZLyxiaonD1TNe
         nHAVkBg+tg0qdWpKn5vqc4gDITFganCpzTN1XI6MKKj0/EXpI9uDUn1OI8H1plZmFnnZ
         jf48UkQvotInCsxBxRBwP49mwOBCf4/WJpAhWBXuWQ7F28ldbQTAXiDG0ZqBbBcne9MR
         N5tyYWfyQjOo+AIEs8O9IgN5iTFcYjaa6wSimx+fephmSO8ciDL0EjWPnh09fXN0oHFX
         KbnvL73+AhdbQUMoxMM8ihlQIlKg4p1RifHXG9UCw1cDRT0EGXBwXOcODrQJbeX5ZRh5
         hNvA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=CXmhYwSf;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id r27si3331123edc.594.2020.04.29.05.08.47;
        Wed, 29 Apr 2020 05:09:13 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=CXmhYwSf;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726832AbgD2MEZ (ORCPT <rfc822;ahaning.tech@gmail.com>
        + 99 others); Wed, 29 Apr 2020 08:04:25 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38438 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL)
        by vger.kernel.org with ESMTP id S1726554AbgD2MEZ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 29 Apr 2020 08:04:25 -0400
Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1111FC03C1AD;
        Wed, 29 Apr 2020 05:04:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version
        :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=O385uY4zHGIJRbWSoL99UmJmEY6lnZgJqFnu8+7Cu40=; b=CXmhYwSfXlX1ebl+S79JE2NY6q
        XnbTqO+F0IktLJMaZ8QCyjvIaMilP1HM0OlazqM9rA2EOGDQVi6NHpZ9pqFV5Fe6AR+VZEClZ6dZj
        l4Z1seG7fVFOxDf3beKsjJYigCFR3RFYpqlfcuHEKYMp4PT3GN5gz24f14GG8Xqq6ImWpsAfPE6jb
        hP1Li8bNfuQx7/eCptaxMWX3vgnAvo9HzXfUUvQQIwp23DCBWlqYhRnVos739pnxtIoPeZUMnDQIC
        Wb31Bv4cGYfn+WdRK28KbdMYbowLQRS6urnSfU35qXmQcXe+q+w30oN4p8SSj0uysStV5c7WTt9/p
        Jwp7qi5g==;
Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux))
        id 1jTlRf-0000p0-1K; Wed, 29 Apr 2020 12:04:07 +0000
Date:   Wed, 29 Apr 2020 05:04:06 -0700
From:   Christoph Hellwig <hch@infradead.org>
To:     Luis Chamberlain <mcgrof@kernel.org>
Cc:     Christoph Hellwig <hch@infradead.org>, axboe@kernel.dk,
        viro@zeniv.linux.org.uk, bvanassche@acm.org,
        gregkh@linuxfoundation.org, rostedt@goodmis.org, mingo@redhat.com,
        jack@suse.cz, ming.lei@redhat.com, nstange@suse.de,
        akpm@linux-foundation.org, mhocko@suse.com, yukuai3@huawei.com,
        linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Omar Sandoval <osandov@fb.com>,
        Hannes Reinecke <hare@suse.com>,
        Michal Hocko <mhocko@kernel.org>,
        syzbot+603294af2d01acfdd6da@syzkaller.appspotmail.com
Subject: Re: [PATCH v3 4/6] blktrace: fix debugfs use after free
Message-ID: <20200429120406.GA913@infradead.org>
References: <20200429074627.5955-1-mcgrof@kernel.org>
 <20200429074627.5955-5-mcgrof@kernel.org>
 <20200429112637.GD21892@infradead.org>
 <20200429114542.GJ11244@42.do-not-panic.com>
 <20200429115051.GA27378@infradead.org>
 <20200429120230.GK11244@42.do-not-panic.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200429120230.GK11244@42.do-not-panic.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 29, 2020 at 12:02:30PM +0000, Luis Chamberlain wrote:
> > Err, that function is static and has two callers.
> 
> Yes but that is to make it easier to look for who is creating the
> debugfs_dir for either the request_queue or partition. I'll export
> blk_debugfs_root and we'll open code all this.

No, please not.  exported variables are usually a bad idea.  Just
skip the somewhat pointless trivial static function.