Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp557913ybz; Wed, 29 Apr 2020 05:21:31 -0700 (PDT) X-Google-Smtp-Source: APiQypKjIQSXotWuK97M99KejNtHzJwLdpIoJZR3elbKC4AqZWGyQWBFDv00w/TAy9iT68tNBFvm X-Received: by 2002:aa7:c886:: with SMTP id p6mr2056986eds.97.1588162891578; Wed, 29 Apr 2020 05:21:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588162891; cv=none; d=google.com; s=arc-20160816; b=sg2okwS/JSB95YjnQblBIWicuvsgX95fN49w/JLU6uZp1yjBm7wBpMy62GmgGEmvFX FpwPXjjzgIb6r5uicmc3mwc0GrXj5PI2kmn1mf7pBFmtSWK8g4EZLUr6Lm8NhTKu5XT2 jC8lMdIHpAuXjpQ/4GDU8pUwfpak2AUwiffm1Xn+F4MuZzc6i2FCw8NxcKC/wxg3a5V2 k3M3n/3TXVt7RQJ0YwGKTDjas70mTAMSmSCI7CwK0Da58abWMXg3di4gkflRJR7tB2KJ jXKmBr2IEFcKvbTSJQA+1jajB+TJfKpbd7SUyF7zQVehyYsI9R+HIaSu+fpeOQFGNKNa aNMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=C1Ts4DfOpbqwNmKAyV/9/Lll4n9YArjQ/mn7brU53Ks=; b=hN0Nzaf2bP8thcijfdz59wDkEtAS1aDOvCtAXAv227o9hGqzyEyzSSUBzB26Y8F0lN xPJVfQXRRNHlOmGm5sUwvu5jh4YbuMlphSRkOeGxLv6DU/ZlmTidQ9tVgVpP5kVc1zc2 rHAgVr51KvKOGRQ8aQEFKNQrUeE0PZIDohbPJocUWHD+jFzVoGAcvS2gzV9YWJ97Nd0D 8O+qBfGYXnT7j1DgMKgregW2Is4sconLX/drDaJ54UiseryOmCEAGe+BgKKeWpTF4Blu b20h3iCSMxgMePxOKdS3WyNSL8z2IPkNoioZvYG9seKzFvxayIvYyHeDL4XalD3mqesv GfOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HeQpH7rx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d19si3539134edz.214.2020.04.29.05.21.08; Wed, 29 Apr 2020 05:21:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HeQpH7rx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726691AbgD2MTt (ORCPT + 99 others); Wed, 29 Apr 2020 08:19:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726524AbgD2MTs (ORCPT ); Wed, 29 Apr 2020 08:19:48 -0400 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 612AFC03C1AE for ; Wed, 29 Apr 2020 05:19:48 -0700 (PDT) Received: by mail-lf1-x144.google.com with SMTP id g10so1434293lfj.13 for ; Wed, 29 Apr 2020 05:19:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=C1Ts4DfOpbqwNmKAyV/9/Lll4n9YArjQ/mn7brU53Ks=; b=HeQpH7rxp/Oyh4cRIDkKuEC/nrOQkmhe2swtarQuUReEO9o8Fgc5g5gq10VX8AQ9Ca 9FUz0xLE0yzVF97yDlEt5U8ogfTQLqmFS5CBYqICi2zKUeyYtLnU/dG73H3PEFPr4uzg O7fEBhpMIUKX1MZfGlQ3RPfC8YI+3CQ4CWCQ2+9tqLp6xSNSavLwClNKF9av4efRAURB KeARE2/mJ0kKPp8hy5nuL4+z4J2kd9NG229n7jc0ndiQF1qA1xFeAMNAHoETBgACTXeB QqIgG/CQ1UTq3Q8vG88ewPteWzXsxqDvel6D9PYwVvaXXYsiFAA8QiKShxdQzqvsKXpw IdMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=C1Ts4DfOpbqwNmKAyV/9/Lll4n9YArjQ/mn7brU53Ks=; b=UXaf/KUgBNy+epVi5OeeVHclCM4+iu4q8/S0Zu6T5SlzB547p5PNmIGnvBihr8MvBk JaojVHSSFz9qKJmn7q3lhf/WDB1fRWh916HhTxWo/jqNNICFPPT7a9nCKhJS659dy1pC Bs3s9a48OOsBOJfiWU3ZSrklY9/KmSoPu9Z+//W0SgF3nY/f2EJ+b43f7A5BYwcUOyp4 S1ECcGdBW/0QTkBcaMVdGAVkctARIuCT12GNu6J4UtK/ZkaD7iMnHly2mzf5MvOB1IEG tTk5TB+uPYuQ+WxnL+xmnzy4y3WN4dFDcrdZsgz60gybghB8ODvQA1rRNKzTDeVKDQN8 6VFQ== X-Gm-Message-State: AGi0PuYGHI8MgFAws/t4yqueousthsY3rWbSuFaoVsgaJa1niVa6mrBv hU0wZpjvxDoAxQ1eCvnJ12STDf2mKFFHm1SVKCxqUw== X-Received: by 2002:ac2:4a9d:: with SMTP id l29mr21464343lfp.4.1588162786702; Wed, 29 Apr 2020 05:19:46 -0700 (PDT) MIME-Version: 1.0 References: <20200428172322.1.I396f351e364f3c09df7c7606e79abefb8682c092@changeid> <20200428172322.2.Iacb3c8152c3cf9015a91308678155a578b0cc050@changeid> In-Reply-To: <20200428172322.2.Iacb3c8152c3cf9015a91308678155a578b0cc050@changeid> From: Linus Walleij Date: Wed, 29 Apr 2020 14:19:35 +0200 Message-ID: Subject: Re: [PATCH 2/2] gpio: Make "offset" and "unsigned int", not just "unsigned" To: Douglas Anderson Cc: Bartosz Golaszewski , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 29, 2020 at 2:24 AM Douglas Anderson wrote: > When I copied the function prototypes from the GPIO header file into > my own driver, checkpatch yelled at me saying that I shouldn't use use > "unsigned" but instead should say "unsigned int". Let's make the > header file use "unsigned int" so others who copy like I did won't get > yelled at. > > Signed-off-by: Douglas Anderson Patch applied. Nice cleanup! Yours, Linus Walleij