Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp560012ybz; Wed, 29 Apr 2020 05:23:58 -0700 (PDT) X-Google-Smtp-Source: APiQypIGJSmssNrnUxW5bd8BisdnBETZhd5p9jsm4SPAuEjeYEpVerIZb5OiTBBoVwqeVpDYPBAm X-Received: by 2002:a17:907:214d:: with SMTP id rk13mr2395202ejb.220.1588163038556; Wed, 29 Apr 2020 05:23:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588163038; cv=none; d=google.com; s=arc-20160816; b=o3O2WMBkikMdk6Cz7f14u0EH/nzX8Awn08JSFBCxKZsUHaxsCKWFxMOWcAUCLAcWgi 3aRoobxTXV3oBPQFeoANHLyX0F2fuxIHm0yUUhZRkaI+iri8abCYyCSW8gZhYyZ9bSOY CFIlxi9MhQar9aiHtUW67k6WndiVgEKOT9vzJV7+SswkT+HJTVaCCC52146Ory0TBYyg 9Bgh9jI/VPysaDcJgcIsudyFog0vvwrHisYLhfArYb8Gg21vnNndpSvBdXhNUSoz2ygT mhzma1s6OKQv3o+wamLbyj2UumZHYOLYTye5p+6iV2Joxk3DHo5gGjmbwjVeKIeq5jpE WRSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=8hYyIcFg83pPVTyQcqYDesu3NloqLxLSIbckmr0AwHk=; b=TFjFSk2BymVZjeNOyJIUScyX/nnDvowX6CuDcy+mjd3Z3Y8dhMWf+tmCYhbVaPjMTx RFkosYMgbCxZUC1OoyCG+RzzDiwX6v7q7mJDhYxSypNs/TiXuBTnojkLlvHklLmxoLcz UD7v5+Qtbf9KIOCjgFoO9W4DTqrwAbzQwndhAaO9yAMoXSFBKd0pCnNNVjdEiujWYVeC BgSeAK0KdzAe/9segSgi9gNuWowFi11QxQpeIuGjx+XMjey6qcYkm4wh+ayO0GNWtLUl MloB3RilDSCBw0fJ+EQbeWDouclxPK6lF1P5df1BUfC5m2e6Xp82c7KC49AhP/NVYb9D EfwQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g15si3244638edu.131.2020.04.29.05.23.29; Wed, 29 Apr 2020 05:23:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727054AbgD2MVz (ORCPT + 99 others); Wed, 29 Apr 2020 08:21:55 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:33764 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726910AbgD2MVz (ORCPT ); Wed, 29 Apr 2020 08:21:55 -0400 Received: by mail-pl1-f196.google.com with SMTP id t7so791347plr.0; Wed, 29 Apr 2020 05:21:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8hYyIcFg83pPVTyQcqYDesu3NloqLxLSIbckmr0AwHk=; b=JrxAkFrbFloSjpp2rbn9klvLI0OhbYSsdXqkMBfIPNsgqeUA8ADBI1MSnk55XxAMgv u3gl1DTZ4FxFDxbkdYJIv2zOnDx/lolIrBxBsZl19CsIaL+QUnq3MCeu4CWpjkerQ7wD 8HB3rDXbUH7Zed0YUqgg5ysDgllZTvZteNmZqbfsFM2ntpZz5CFUOoEvkVeXJUTTSXBs 28WcE1DupmcpiO95iS/kSxLmMR1GHCLwf4gwHLdGSH4pQufLwwO6z36UegaV00gT/O4/ kcqHFGk44lYltrd6fDJvAsSMY600aVHbUI1yWqN5psNtcW8HhpCzeK2TN2Ggi0AQgNmp wSog== X-Gm-Message-State: AGi0PuZI82T/fLIMhjkx6iV6F6OO14Kj44mQzqN8YuxIVMJBC4WkgrpS XapShQfLFSxIj3WmcISSq/c= X-Received: by 2002:a17:90a:fa0e:: with SMTP id cm14mr2871825pjb.92.1588162914403; Wed, 29 Apr 2020 05:21:54 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id h9sm966620pfo.129.2020.04.29.05.21.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2020 05:21:53 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 861A4403AB; Wed, 29 Apr 2020 12:21:52 +0000 (UTC) Date: Wed, 29 Apr 2020 12:21:52 +0000 From: Luis Chamberlain To: Christoph Hellwig Cc: axboe@kernel.dk, viro@zeniv.linux.org.uk, bvanassche@acm.org, gregkh@linuxfoundation.org, rostedt@goodmis.org, mingo@redhat.com, jack@suse.cz, ming.lei@redhat.com, nstange@suse.de, akpm@linux-foundation.org, mhocko@suse.com, yukuai3@huawei.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Omar Sandoval , Hannes Reinecke , Michal Hocko , syzbot+603294af2d01acfdd6da@syzkaller.appspotmail.com Subject: Re: [PATCH v3 4/6] blktrace: fix debugfs use after free Message-ID: <20200429122152.GL11244@42.do-not-panic.com> References: <20200429074627.5955-1-mcgrof@kernel.org> <20200429074627.5955-5-mcgrof@kernel.org> <20200429112637.GD21892@infradead.org> <20200429114542.GJ11244@42.do-not-panic.com> <20200429115051.GA27378@infradead.org> <20200429120230.GK11244@42.do-not-panic.com> <20200429120406.GA913@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200429120406.GA913@infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 29, 2020 at 05:04:06AM -0700, Christoph Hellwig wrote: > On Wed, Apr 29, 2020 at 12:02:30PM +0000, Luis Chamberlain wrote: > > > Err, that function is static and has two callers. > > > > Yes but that is to make it easier to look for who is creating the > > debugfs_dir for either the request_queue or partition. I'll export > > blk_debugfs_root and we'll open code all this. > > No, please not. exported variables are usually a bad idea. Just > skip the somewhat pointless trivial static function. Alrighty. It has me thinking we might want to only export those symbols to a specific namespace. Thoughts, preferences? BLOCK_GENHD_PRIVATE ? The scsi-generic driver seems... rather unique, and I'd imagine we'd want to discourage such concoctions in the future, so proliferations of these symbols. Luis