Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp572951ybz; Wed, 29 Apr 2020 05:38:28 -0700 (PDT) X-Google-Smtp-Source: APiQypKw/9fM56m3SJI1dC2xcKv1tOdvicIF+6dm50Td9dxB3EbkoPi1/xDgQb6s2fIhhhfzGHqV X-Received: by 2002:aa7:c3c2:: with SMTP id l2mr2274309edr.362.1588163908307; Wed, 29 Apr 2020 05:38:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588163908; cv=none; d=google.com; s=arc-20160816; b=ujaSnew9oNh7LvGlUke2gH2w9uewlHt83RW9+at0/QEap2dHfwrY8vHccAl17GP7Iw F4veEkRZaZowKyTtgg1IqGKZ8brM8mJW3pi3l+AZd4SCqYcC+0k/UVz1oWQGHsBRz53q K80QUaY2350IYi6UTwan/p+DYy9BYmiSVHsT4R/idQXmus48MKMaNEf/lDxPK9t4YcQS 9clj/0VlxS1Lcnt/mEsK3cgR7Igq6g8SzoKAGBCZMama04AsV3f62pSTFqJhHc45YHkE m+fCyiHlVg/0e3x5WkzdYTY4SdA3GHU9vMQhJCi0HuMQ+iwhIiWkg+0La4LcG9TDnp5d ZzxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=6lD/kQN+2/noO6l676D/crTQxbfBilzk74je4uWi+RE=; b=AcoqGyu22zgYDjsoMUnA5w2Dcfmi7Ywgb/dkcCNzqO7l3PHYvGnlWeE3ao4BQenLwf XHZPH1oGVMU+DtH63ruRcVgzhEZTWOfYr0/Ztp+LjWIQKOM3pUmx18XPVrYAt5+Qvgic mVGfIS5suyVp5L1dedxpwEiebK6OB5v+omL47P+7FaeDeiZets0Boe7vNoEcW6v/or+j t2WvuJO2dZ138rtvPNqAx++95kmweZ8SUWhwFBQf7sHVm+89wAoM7h7T7RP75FwiBMKP ByGxEWawQ12GAK7mIe297sQpZzllK4Vep2cMnwSxApzJTrLdJ8mthkHHMbZNqgUQ31MO BnJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=D5TyUZV+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q24si3684486ejz.458.2020.04.29.05.38.04; Wed, 29 Apr 2020 05:38:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=D5TyUZV+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726963AbgD2Mfn (ORCPT + 99 others); Wed, 29 Apr 2020 08:35:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726781AbgD2Mfn (ORCPT ); Wed, 29 Apr 2020 08:35:43 -0400 Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE59DC03C1AD; Wed, 29 Apr 2020 05:35:41 -0700 (PDT) Received: by mail-pf1-x442.google.com with SMTP id 18so1018349pfx.6; Wed, 29 Apr 2020 05:35:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6lD/kQN+2/noO6l676D/crTQxbfBilzk74je4uWi+RE=; b=D5TyUZV+K2dz48gCCRMuv18HfmOtvNgOmPvURzvzzAGjW2uTy21G07/Bs1fTMlOdkK JqGQ9YYuoQGNdBV77/HGXcu5sBoHLkAjB6S4sQk08CONbupRhmSbmkG8DavGRpfJeW2Y 3JtlSEy/xIcOYz0iY0pQ6RVSYw3fZC8vJnxNaA6bDijigfozEBfbU2uSp/5QEMhYZqMu b9A8gd9Ib8RHurG/anB84s8coQvM167UEhkBTwQZzI0eJs1tw23zjfYzwMLE4uKF859E Bn6XWs+j0NI0iVG/5QEiDU+s3NwafiQj/YkurkB2CWm2ArDgs1PAPp24W2v3sHBGqR0h /s4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6lD/kQN+2/noO6l676D/crTQxbfBilzk74je4uWi+RE=; b=uTvD15gm7lj7IWnhHap5J+bu6qD5ugUZC/tGXP8OKnJl+elazhWdk52mzYke45PIqJ 1SWNRwK/zck1PvaOOTJNEtTTNPrmQQfWtQ/8NM/0W0pl63OG60OUz0OxamHEEg0sag2O +ViIwYDR4i0UPzkegpM0IqrTf/RPdhE4uvpQcpWc+rIFiaN7QcBmUdhim7Zf+DJWhGaT I6mUQi1Jfn/KbqSC0rCZGV4MJFm9dYoWFEq11Kx3EHw7JxlghJrbageZi0crLRldxWVE lT1KRr2EREcK8n5FdxKKaliUeWYzij63faubWLcE9HkBaDnYz3s0ie/D/sx7pXQi4ofc hffw== X-Gm-Message-State: AGi0PuaB9MAeYQpY2nuDkIEAaFBY+Lq7iBG26Qgb72Nsb5hU8qQ6pBDP aMji9st5dIAiB6GzwM6kGi+riAc2+qGH6Zf68PQ= X-Received: by 2002:a62:5ec7:: with SMTP id s190mr33747269pfb.130.1588163741365; Wed, 29 Apr 2020 05:35:41 -0700 (PDT) MIME-Version: 1.0 References: <1588150780-53718-1-git-send-email-wangxiongfeng2@huawei.com> In-Reply-To: <1588150780-53718-1-git-send-email-wangxiongfeng2@huawei.com> From: Andy Shevchenko Date: Wed, 29 Apr 2020 15:35:34 +0300 Message-ID: Subject: Re: [PATCH] platform/x86: thinkpad_acpi: Remove always false 'value < 0' statement To: Xiongfeng Wang Cc: Henrique de Moraes Holschuh , Darren Hart , Andy Shevchenko , Thinkpad-acpi devel ML , Platform Driver , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 29, 2020 at 12:06 PM Xiongfeng Wang wrote: > > Since 'value' is declared as unsigned long, the following statement is > always false. > value < 0 > > So let's remove it. It's bogus. The warning here doesn't tell anything useful, so doesn't the patch. -- With Best Regards, Andy Shevchenko