Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp574077ybz; Wed, 29 Apr 2020 05:39:48 -0700 (PDT) X-Google-Smtp-Source: APiQypIzI67wBJ8yNxrEBrhgn4ORSuG/8loI3YrYO41C+BkRuCG8aftNrGiOusjzu8w1P6EWUt8g X-Received: by 2002:a50:ea87:: with SMTP id d7mr2163015edo.48.1588163988587; Wed, 29 Apr 2020 05:39:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588163988; cv=none; d=google.com; s=arc-20160816; b=OyW3IE+N3RVlrzi3IHlc1uwkcV8uGMpCg+4HpyGpr/u2FYwB3sdYiWGTZZZRF2DxUp CWr8LE59KpxpgyUjXzLV220h3A7Ji6BitqdYqq//jfPDw7cNmQSig6+79fg1aEEm59Ds UpuxfA8+eSXlN1UYxnLkzxZxJFK3MkrjDROWlhygZG3VsffyScndUfe/1iS7DItQlx4g M+vbCVgfUGh4v0jT8W1Rk3+GZ/yLzyTPlG1ffg0t7P3+BqVtyjD1d8oxHqetkS8Tmd5S M4ppAsgXNqOxuuxsaMvKiALBKZsUK3IqILctWRmN04iKWwWHmJkRZqDzK0z4nR857T+F Hldg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=wEFj1LbbBZbuf64ktJeqB0BNoaslLRMTHF58cVKJVS0=; b=tdyZymambuDgaWkT3ae8p10mG9pPsGLmB5+QUv2RtilYiPuPWUM+4bukjJ3KMXhmjq wWV6RPwgFZSnJWeTwH4bGVmQHcVu6waH/Wsup2dpL89gW/soHqOO4Lw16+iJdO8h1krt YYNID5EwJW5L7WguSt6T34LCKF3i9N0JhB6qddDJZ1IjeAmRPf5nycIU++onGRR/3acv VnnWcuBFhnLWQXEJ+e5/f8+pHtohMQyZw+a8TEqO2gFx7mewy9uz2vD6KsXLnUWiR0Nv 3/VDAanBX06Q1+DuBlFfQyppjpiXoEVtQ31hpvUx5sPqU2IFLCwbaHJphcVJ3Vx5BB5Y MQog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=TptblHra; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gr24si3809637ejb.162.2020.04.29.05.39.23; Wed, 29 Apr 2020 05:39:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=TptblHra; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726838AbgD2Mh5 (ORCPT + 99 others); Wed, 29 Apr 2020 08:37:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726628AbgD2Mh5 (ORCPT ); Wed, 29 Apr 2020 08:37:57 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65464C03C1AD; Wed, 29 Apr 2020 05:37:57 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id 7so2291388pjo.0; Wed, 29 Apr 2020 05:37:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=wEFj1LbbBZbuf64ktJeqB0BNoaslLRMTHF58cVKJVS0=; b=TptblHra4+AZt0TguWbljkKi6DxQrlS/2/vpgendjeSnrE/wFRa+ylLRYbndB0+I2m rQ22rgQs5KvnHi6W6X0Zoz4HqXgdPXjverIgghrkyMQWxZ/yY45FOq0tItfxBzKvfVJk BP16C0I4maFq3tneQ7ITZBCmdI6S2EHwdJSHttPJ6pLXnTNMAYAnKaNmryYpSGZ1y3oF dsMPdFxLKoCPJBbGX3wLlL/Jdieuag3Z3JNBFrXG78ahVqEILanbHCYggXOur9DaQuNa HpxDyxjcKte68ZX8dRT3pRu8HdYCguwkiHVxbN9jEOXI9b4cCJIFgrNpB2CYC2Q0gcxX e8Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=wEFj1LbbBZbuf64ktJeqB0BNoaslLRMTHF58cVKJVS0=; b=j9WAAfF8tPSRoqbMN83BMWPkcjfSrQc1x/jiUj8ncq6zTLVZ1YpC3LbqsOdEh/dsbL 3JhWiceIpz18ax00l3S6Ps3CL9EHu63QrbD07fbbOwPLF1oyQI/4dDkFMP5FaKjV56z/ H52BLAMf/fvlbfMc1JiINn45lzktvdyIq3gX/05xI090XIBSKx92bEscmJaYP8/vZdz+ JOdnlMEzEmKKX3/4qLRuRgVOjOPm+ezwX7P8GO9JRa49yJrW2azG1LDXVQVjJvkPlaRm sD9+nvoanwmRfJkV9nnpcNp5nrMEPNuamz6tyj2HEi/proFf3xiLSQ8Ve1AGH8u6O3Mt z5WA== X-Gm-Message-State: AGi0PuaZfnElqaXAfS4LJYJpPn7EA6uNPKE2mZc0Ox+q/1WgrTDrvg9E KP/JlDX0IzgvlkRFepiJ4IC8DwIPpuLEi7oSBWE= X-Received: by 2002:a17:90a:364c:: with SMTP id s70mr2915977pjb.143.1588163876955; Wed, 29 Apr 2020 05:37:56 -0700 (PDT) MIME-Version: 1.0 References: <20200320093125.23092-1-brgl@bgdev.pl> In-Reply-To: From: Andy Shevchenko Date: Wed, 29 Apr 2020 15:37:50 +0300 Message-ID: Subject: Re: [PATCH] gpiolib: don't call sleeping functions with a spinlock taken To: Bartosz Golaszewski Cc: Linus Walleij , Bartosz Golaszewski , Geert Uytterhoeven , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 29, 2020 at 9:40 AM Bartosz Golaszewski wrote: > wt., 28 kwi 2020 o 17:53 Andy Shevchenko napi= sa=C5=82(a): > > On Tue, Apr 14, 2020 at 6:35 PM Bartosz Golaszewski > > wrote: > > > wt., 14 kwi 2020 o 14:00 Linus Walleij nap= isa=C5=82(a): > > > > On Fri, Mar 20, 2020 at 10:31 AM Bartosz Golaszewski wrote: ... > > It looks like we need a mutex less function which can be used here and > > in the call you are considering racy. > > The thing is this mutex is in pinctrl - we'd need to export it too so > that gpio can use it. Oh, I see now. So, something like pinctrl_ext_operation_begin() .... pinctrl_ext_operation_end() perhaps. --=20 With Best Regards, Andy Shevchenko