Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: AWd6Ifb1KwULWPo4G7aT6O92fY7eZdkrX9gX0w3Wz1IGm026iq/7iRVo73JM5OmYqFoiXEp0N+
 y8JAvkZB9YyQ==
IronPort-SDR: 2UaTrOx0IU2JFuLtDh2zLVLh8AkFd/TzUTn4ESfgu67UiQFtwQjbVO9dmFy2jwlk1NvuKv4sIq
 XmXTc6mZjKbg==
Subject: Re: [LKP] Re: [mm/debug] fa6726c1e7: kernel_BUG_at_include/linux/mm.h
To:     Anshuman Khandual <anshuman.khandual@arm.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Qian Cai <cai@lca.pw>
Cc:     Christophe Leroy <christophe.leroy@c-s.fr>,
        kernel test robot <lkp@intel.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Ingo Molnar <mingo@kernel.org>,
        Mike Rapoport <rppt@linux.ibm.com>,
        Vineet Gupta <vgupta@synopsys.com>,
        Will Deacon <will@kernel.org>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Heiko Carstens <heiko.carstens@de.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        "Kirill A. Shutemov" <kirill@shutemov.name>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>, lkp@lists.01.org
References: <9e9091b9-6918-d0af-dd92-3bdc0e29a4d5@arm.com>
 <813D7CD3-F31C-4056-92DF-D462633E9D69@lca.pw> <20200428092105.GB3868@gaia>
 <b62c66c8-1550-087f-f5d2-b33a18bb0edc@arm.com>
From:   "Chen, Rong A" <rong.a.chen@intel.com>
Message-ID: <07ea0efd-0145-eaaf-c628-e48957154a2c@intel.com>
Date:   Wed, 29 Apr 2020 20:52:25 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <b62c66c8-1550-087f-f5d2-b33a18bb0edc@arm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 4/29/2020 11:28 AM, Anshuman Khandual wrote:
>
> On 04/28/2020 02:51 PM, Catalin Marinas wrote:
>> On Tue, Apr 28, 2020 at 04:41:11AM -0400, Qian Cai wrote:
>>> On Apr 28, 2020, at 1:54 AM, Anshuman Khandual <Anshuman.Khandual@arm.com> wrote:
>>>> That is true. There is a slight change in the rules, making it explicit yes
>>>> only when both ARCH_HAS_DEBUG_VM_PGTABLE and DEBUG_VM are enabled.
>>>>
>>>> +config DEBUG_VM_PGTABLE
>>>> +    bool "Debug arch page table for semantics compliance"
>>>> +    depends on MMU
>>>> +    depends on !IA64 && !ARM
>>>> +    depends on ARCH_HAS_DEBUG_VM_PGTABLE || EXPERT
>>>> +    default y if ARCH_HAS_DEBUG_VM_PGTABLE && DEBUG_VM
>>>> +    help
>>>>
>>>> The default is really irrelevant as the config option can be set explicitly.
>>> That could also explain. Since not long time ago, it was only “default
>>> y if DEBUG_VM”, that caused the robot saved a .config with
>>> DEBUG_VM_PGTABLE=y by default.
>>>
>>> Even though you changed the rule recently, it has no effect as the
>>> robot could “make oldconfig” from the saved config for each linux-next
>>> tree execution and the breakage will go on.
>> I'm not entirely sure that's the case. This report still points at the
>> old commit fa6726c1e7 which has:
>>
>> +       depends on ARCH_HAS_DEBUG_VM_PGTABLE || EXPERT
>> +       default n if !ARCH_HAS_DEBUG_VM_PGTABLE
>> +       default y if DEBUG_VM
>>
>> In -next we now have commit 647d9a0de34c and subsequently modified by
>> commit 0a8646638865. So hopefully with the latest -next tree we won't
>> see this report.
> Could some one from LKP test framework, please confirm if this still causes
> above problem on the latest linux-next by default ?

Hi,

The .config is a rand config, the problem is still exist if run "make 
oldconfig" for the config
with commit 0a8646638865.

$ grep -e CONFIG_MMU= -e CONFIG_EXPERT= -e 
CONFIG_ARCH_HAS_DEBUG_VM_PGTABLE= -e CONFIG_DEBUG_VM= .config
CONFIG_EXPERT=y
CONFIG_MMU=y
CONFIG_DEBUG_VM=y

should we disable DEBUG_VM_PGTABLE by default?

Best Regards,
Rong Chen