Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE:[PATCH 1/1] mm/vmscan.c: change prototype for shrink_page_list
Reply-To: maninder1.s@samsung.com
From:   Maninder Singh <maninder1.s@samsung.com>
To:     Michal Hocko <mhocko@kernel.org>
CC:     "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        AMIT SAHRAWAT <a.sahrawat@samsung.com>,
        Vaneet Narang <v.narang@samsung.com>
In-Reply-To: <20200429120951.GC28637@dhcp22.suse.cz>
Message-ID: <20200429125323epcms5p67a539511c573cd598d78b726503e3204@epcms5p6>
Date:   Wed, 29 Apr 2020 18:23:23 +0530
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
References: <20200429120951.GC28637@dhcp22.suse.cz>
        <1588139967-19012-1-git-send-email-maninder1.s@samsung.com>
        <CGME20200429055946epcas5p2d5faf2b320913d59a4a8380cb017053c@epcms5p6>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Hi,

>
>Acked-by: Michal Hocko <mhocko@suse.com>
>
>Is there any reason to move declarations here?
>

"unsigned int ret" was changed mistakenely, sending V2.
and "unsigned int nr_reclaimed" is changed to remove hole.
 
>> -unsigned long reclaim_clean_pages_from_list(struct zone *zone,
>> +unsigned int reclaim_clean_pages_from_list(struct zone *zone,
>>  					    struct list_head *page_list)
>>  {
>> +	unsigned int ret;
>>  	struct scan_control sc = {
>>  		.gfp_mask = GFP_KERNEL,
>>  		.priority = DEF_PRIORITY,
>>  		.may_unmap = 1,
>>  	};
>>  	struct reclaim_stat dummy_stat;
>> -	unsigned long ret;
>>  	struct page *page, *next;
>>  	LIST_HEAD(clean_pages);
>>  
>> @@ -1900,13 +1900,13 @@ static int current_may_throttle(void)
>>  {
>>  	LIST_HEAD(page_list);
>>  	unsigned long nr_scanned;
>> -	unsigned long nr_reclaimed = 0;
>>  	unsigned long nr_taken;
>>  	struct reclaim_stat stat;
>>  	int file = is_file_lru(lru);
>>  	enum vm_event_item item;
>>  	struct pglist_data *pgdat = lruvec_pgdat(lruvec);
>>  	struct zone_reclaim_stat *reclaim_stat = &lruvec->reclaim_stat;
>> +	unsigned int nr_reclaimed = 0;
>>  	bool stalled = false;
>>  
>>  	while (unlikely(too_many_isolated(pgdat, file, sc))) {


Thanks,
Maninder Singh