Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp601362ybz; Wed, 29 Apr 2020 06:11:03 -0700 (PDT) X-Google-Smtp-Source: APiQypLbhL/PROfR7b6DkG8WvmyiOz8iXvQEIEGTN0KIcvES/AuAGnlB0oaCxzBfG+pZVGHN9okm X-Received: by 2002:a17:906:7c4e:: with SMTP id g14mr2581328ejp.382.1588165863417; Wed, 29 Apr 2020 06:11:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588165863; cv=none; d=google.com; s=arc-20160816; b=Pw0YjUEX7yNr4gBqIYDhjPMyIFa709sKa8UjbDOEjHl//S2V92oGKJLX7spCXxLrlR MgVZ+9N5eyL1IgSVnmctiPpPzKrm+5YcV+eQyqiCb4e/QvmmSm3+7QQ0AsS+5/Prqq7D we/fZpCP3ibLbwUIq9KFWZGtDM1M90cQOHU5VFld/z9jkBNdLaGGWp69Ez7aDqNIqmOU k9YMEaDjT8RCTaraE/QgndG7riB/EV2mwpCAryrLMpH1J1cjCUVLxXRN4AdTm9HvUIKa MMgJtJm5t7l6ThuDprIvcncS9DH4Hz4/ecgSHaEneqjsHHN93SmItmNWgqJK9Kk4DOmh 4pHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=bH0bbqVQbeUY5It5xqT1zYzIFKuvRYaWvNIr4hXMeAE=; b=x+Oc9q2ADCt+kipq+f+vbmB94YGVFEMDuArmhAp5TJAEmY1HgvLUM7fDmj3u4PZmZF +RDFNGBSWURf1rcQzcfwH4VL3y9uMLyARtsOSsplv/nYh1Nn8m8aP1FrzJVPvoGdi8l9 4/GJOACvcM/q9HIcQjvzn4Gq8z4waN2/Ab2s/n/DGwOmixhUq+UNdZQV2tp19lPfNjo6 9w96cKSjlxpVKZApYDSwKjlCWSy6mOAj6ZTpBvXR4/dvCnn7X0pIx8hJsJMsUGN+id4r xD9H+E3voXGqEFyXsUC7dpSsYm90ZfWh4ozXOWdfORVG7NMbX7xuSYVpvIQwKVo6Pj0A XepA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id eb6si4618228edb.271.2020.04.29.06.10.39; Wed, 29 Apr 2020 06:11:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726853AbgD2NJR (ORCPT + 99 others); Wed, 29 Apr 2020 09:09:17 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:33156 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726516AbgD2NJR (ORCPT ); Wed, 29 Apr 2020 09:09:17 -0400 Received: by mail-wr1-f65.google.com with SMTP id s10so2482962wrr.0 for ; Wed, 29 Apr 2020 06:09:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bH0bbqVQbeUY5It5xqT1zYzIFKuvRYaWvNIr4hXMeAE=; b=A6nT6ZBosg6K9CwrMGA5GRmhDnyzkjMyh1nnsJQlk5h0AOrSQLdnedvujwkJJc/WxC zkAFapclZQ5wCCWOsr3fW7YPqFqxRuZgY1iIqnsta332+xrYNNn4tgD8RyR9PxzQG5na 3BDbJfOazXjIhvirlXHA9FmL0hETLwPj89/waoyZK7uhX1WnyM9ydyn8KkgOA34LyH/X 9S5RLoJsryzUn0/z7RzIrU2TBvYJBEBhsAxSL2dJseBOH4R2Vsbek8aSLy5lBDFsev5P MWc1MaUqjMbWvy1ApHCQWzXHJA/U37UuVp7Zkx0j6ZBkDP+z+btl4wlrgE3KgFUTX3Ug fmvg== X-Gm-Message-State: AGi0PubIpPtkBSSOWFLp2cr2vftJ9AqrsLfVmJ0Fqg9rsf5GQLHAQjD0 dfqpW7wxaPsOLmIe8QCDn1M= X-Received: by 2002:a5d:42cf:: with SMTP id t15mr38561028wrr.354.1588165755294; Wed, 29 Apr 2020 06:09:15 -0700 (PDT) Received: from localhost (ip-37-188-130-62.eurotel.cz. [37.188.130.62]) by smtp.gmail.com with ESMTPSA id n2sm30894945wrq.74.2020.04.29.06.09.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2020 06:09:14 -0700 (PDT) Date: Wed, 29 Apr 2020 15:09:12 +0200 From: Michal Hocko To: Maninder Singh Cc: "akpm@linux-foundation.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , AMIT SAHRAWAT , Vaneet Narang Subject: Re: [PATCH 1/1] mm/vmscan.c: change prototype for shrink_page_list Message-ID: <20200429130912.GE28637@dhcp22.suse.cz> References: <20200429120951.GC28637@dhcp22.suse.cz> <1588139967-19012-1-git-send-email-maninder1.s@samsung.com> <20200429125323epcms5p67a539511c573cd598d78b726503e3204@epcms5p6> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200429125323epcms5p67a539511c573cd598d78b726503e3204@epcms5p6> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 29-04-20 18:23:23, Maninder Singh wrote: > > Hi, > > > > >Acked-by: Michal Hocko > > > >Is there any reason to move declarations here? > > > > "unsigned int ret" was changed mistakenely, sending V2. > and "unsigned int nr_reclaimed" is changed to remove hole. Could you be more specific? Have you seen a better stack allocation footprint? -- Michal Hocko SUSE Labs