Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE:(2) [PATCH 1/1] mm/vmscan.c: change prototype for
 shrink_page_list
Reply-To: v.narang@samsung.com
From:   Vaneet Narang <v.narang@samsung.com>
To:     Michal Hocko <mhocko@kernel.org>,
        Maninder Singh <maninder1.s@samsung.com>
CC:     "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        AMIT SAHRAWAT <a.sahrawat@samsung.com>
In-Reply-To: <20200429130912.GE28637@dhcp22.suse.cz>
Message-ID: <20200429132940epcms5p81e75e09469b62253ff512222c568556f@epcms5p8>
Date:   Wed, 29 Apr 2020 18:59:40 +0530
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
References: <20200429130912.GE28637@dhcp22.suse.cz>
        <20200429120951.GC28637@dhcp22.suse.cz>
        <1588139967-19012-1-git-send-email-maninder1.s@samsung.com>
        <20200429125323epcms5p67a539511c573cd598d78b726503e3204@epcms5p6>
        <CGME20200429055946epcas5p2d5faf2b320913d59a4a8380cb017053c@epcms5p8>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Michal,=C2=A0=0D=0A=0D=0A>>=C2=A0>=0D=0A>>=C2=A0>Acked-by:=C2=A0Michal=
=C2=A0Hocko=C2=A0<mhocko=40suse.com>=0D=0A>>=C2=A0>=0D=0A>>=C2=A0>Is=C2=A0t=
here=C2=A0any=C2=A0reason=C2=A0to=C2=A0move=C2=A0declarations=C2=A0here?=0D=
=0A>>=C2=A0>=0D=0A>>=C2=A0=0D=0A>>=C2=A0=22unsigned=C2=A0int=C2=A0ret=22=C2=
=A0was=C2=A0changed=C2=A0mistakenely,=C2=A0sending=C2=A0V2.=0D=0A>>=C2=A0an=
d=C2=A0=22unsigned=C2=A0int=C2=A0nr_reclaimed=22=C2=A0is=C2=A0changed=C2=A0=
to=C2=A0remove=C2=A0hole.=0D=0A=C2=A0=0D=0A>Could=C2=A0you=C2=A0be=C2=A0mor=
e=C2=A0specific?=C2=A0Have=C2=A0you=C2=A0seen=C2=A0a=C2=A0better=C2=A0stack=
=C2=A0allocation=0D=0A>footprint?=0D=0A=0D=0AWe=20didn't=20check=20stack=20=
allocation=20footprint,=20we=20did=20changes=20just=20by=20looking=20into=
=20the=20code.=0D=0Awe=20thought=20changing=20reclaimed=20type=20from=20lon=
g=20to=20int=20on=2064=20bit=20platform=20will=20add=20=0D=0Ahole=20of=204=
=20bytes=20between=20two=20stack=20variables=20nr_reclaimed=20&=20nr_taken.=
=0D=0A=0D=0ASo=20we=20tried=20to=20remove=20that=20hole=20by=20packing=20it=
=20with=20bool.=0D=0A=0D=0A=20=09unsigned=20long=20nr_scanned;=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20-->=20Size=20and=20alignment=208=20b=
yte=20for=20long=20=0D=0A-=09unsigned=20long=20nr_reclaimed=20=3D=200;=20=
=20=20=20=20=20=20=20=20=20=20-->=20Changing=20to=20int=20will=20make=20its=
=20size=20as=204=20=20=0D=0A=20=09unsigned=20long=20nr_taken;=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20-->=20nr_taken=20needs=20align=
ment=20of=208=20so=20will=20add=20hole.=0D=0A=20=09struct=20reclaim_stat=20=
stat;=0D=0A=20=09int=20file=20=3D=20is_file_lru(lru);=0D=0A=20=09enum=20vm_=
event_item=20item;=0D=0A=20=09struct=20pglist_data=20*pgdat=20=3D=20lruvec_=
pgdat(lruvec);=0D=0A=20=09struct=20zone_reclaim_stat=20*reclaim_stat=20=3D=
=20&lruvec->reclaim_stat;=0D=0A+=09unsigned=20int=20nr_reclaimed=20=3D=200;=
=20=20=20=20=20=20=20=20=20=20=20=20-->=20So=20moving=20to=20this=20place=
=20to=20pack=20it=20along=20with=20bool=20=0D=0A=20=09bool=20stalled=20=3D=
=20false;=0D=0A=0D=0A=0D=0AOverall=20stack=20footprint=20might=20not=20chan=
ge=20as=20compiler=20makes=20function=20stack=20pointer=20as=2016=20byte=20=
aligned=20but=20we=20did=20this=20=0D=0Aas=20we=20normally=20follow=20this=
=20coding=20convention=20when=20defining=20structures=20or=20stack=20variab=
les.=20=0D=0A=0D=0AThanks=20&=20Regards,=0D=0AVaneet=20Narang=0D=0A=C2=A0=
=0D=0A=C2=A0=0D=0A=0D=0A=C2=A0