Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp662891ybz; Wed, 29 Apr 2020 07:14:45 -0700 (PDT) X-Google-Smtp-Source: APiQypIrDs+ET/WjOIueZScC46zmYscTU/aqMxlZapBCVFXtyXVhwxg7RYBg2plX3xg1EdXGy9ao X-Received: by 2002:a50:c44c:: with SMTP id w12mr2674146edf.83.1588169685052; Wed, 29 Apr 2020 07:14:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588169685; cv=none; d=google.com; s=arc-20160816; b=OxIP/gjzqbBaM7wmnMdlz3jREOCCb3KHGW6E6XvdSiOPZqp4sW4KXAyJIUxV7BpjL6 5Vdd0Wi2Pe7IIrhpKS4SmYxYjr3HhoCyF5rNJU+hj1jQdAxOMxxVMbV3Wad/AmTLtf4K imV1SstYQp5G+M1YEaTmJRS9Brnpn3uWaYYSNF4rj/yYFwY2XVswRbmxmCAHszEB+haL Gry0yb+YJlLNKOPUbQfF6bKAyDX98HQ4LTnJg/MFZCzsskBx47ZxeN1SlrUM+UsJENHk eoZAXjRVV5SfheZRALca33j5xw316hRrY3MbvHuI8kI047AZZMQFJEr72fvX//QPcmMd gebw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=NTgKKXn+HPXagmPkQKtyIbRRXwhnL3VdVYdDVASikGk=; b=cpo4l32jC+xm0sXZSnhbrXWOd/lk5A7E1bFWgH+ZXnvRjnm9A4pWTeW5Y/Q8n2BgDm P8zoJhQMc0qWRvLQtnPkxzF2Tu+59frx2/65GxDRSFWMXK0ly6TWPCgLeZd0Z0bKlv/6 AP3IDDfvcuClZRZVKN6GxRfJJhmw5vOyIp9p5+h4IXX+zUs3Khfdtafozs3PiRqmjy/O sTeyBR4198VP3BOpKN58GK0Em1isbNMDKSVwCP+0bTWwA7PPrSXAKBkH/Z4iwgOboAj3 3+8xLdXMStgiJl/lNjHFFIcZ4Hs+M+yiGVK2O12tCrbuBzC7j1ewuVFB8a2cIhHEIZVC FtKQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a16si4562658edn.579.2020.04.29.07.14.22; Wed, 29 Apr 2020 07:14:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728183AbgD2OK2 (ORCPT + 99 others); Wed, 29 Apr 2020 10:10:28 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:3383 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726691AbgD2OK1 (ORCPT ); Wed, 29 Apr 2020 10:10:27 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id EF597D0A7553792897A7; Wed, 29 Apr 2020 22:10:24 +0800 (CST) Received: from huawei.com (10.175.124.28) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.487.0; Wed, 29 Apr 2020 22:10:16 +0800 From: Jason Yan To: , , , CC: Jason Yan Subject: [PATCH] video: fbdev: valkyriefb.c: fix warning comparing pointer to 0 Date: Wed, 29 Apr 2020 22:09:42 +0800 Message-ID: <20200429140942.8137-1-yanaijie@huawei.com> X-Mailer: git-send-email 2.21.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.124.28] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccicheck warning: drivers/video/fbdev/valkyriefb.c:348:10-11: WARNING comparing pointer to 0, suggest !E drivers/video/fbdev/valkyriefb.c:334:12-13: WARNING comparing pointer to 0 drivers/video/fbdev/valkyriefb.c:348:10-11: WARNING comparing pointer to 0 Signed-off-by: Jason Yan --- drivers/video/fbdev/valkyriefb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/valkyriefb.c b/drivers/video/fbdev/valkyriefb.c index 4d20c4603e5a..8425afe37d7c 100644 --- a/drivers/video/fbdev/valkyriefb.c +++ b/drivers/video/fbdev/valkyriefb.c @@ -331,7 +331,7 @@ int __init valkyriefb_init(void) struct resource r; dp = of_find_node_by_name(NULL, "valkyrie"); - if (dp == 0) + if (!dp) return 0; if (of_address_to_resource(dp, 0, &r)) { @@ -345,7 +345,7 @@ int __init valkyriefb_init(void) #endif /* ppc (!CONFIG_MAC) */ p = kzalloc(sizeof(*p), GFP_ATOMIC); - if (p == 0) + if (!p) return -ENOMEM; /* Map in frame buffer and registers */ -- 2.21.1