Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp732884ybz; Wed, 29 Apr 2020 08:25:55 -0700 (PDT) X-Google-Smtp-Source: APiQypLJmZv2ve2IyTqApgnthLwoI7dQIVKns1sngk4QA+qrQFTniZQoWBMG1Fx9XYkSTsGmEVyh X-Received: by 2002:a17:907:2711:: with SMTP id w17mr3098465ejk.116.1588173955728; Wed, 29 Apr 2020 08:25:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588173955; cv=none; d=google.com; s=arc-20160816; b=V0QU+chgHraf5nU+kzG5ANEW+EO6SSGEttnV9wpLvtQTFbIxuecmUbHE04epHMkmQ6 ZUgV7GTcmlnpLAOI4YmT9lII6lohOl1yto5/Ku31ufrQF+PSD3jS5U2TincBDgRHKYEX LchMpKJOc3tfzR4rOldZi3VDlgt6U1jg7i1qYlIqTeH3ZPK9AvsIDqAxJmuS3IEBuJns oD8mGz38vPfvsZKDASgXhIiGA6gKQnTRBuoeyfDlDRKhG4BJiFcBw8IuSn2aodIgb2s9 PwnQz5HO9BKBv8+q1vVlwFPWG3713WBdtOnGqcc6UoT48afYc6ugrEBfNM07bqGb8IEN M9uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Ty18jkh7zkBHOD6czGW8SkI58aj/+4PBnyEc+GD/orI=; b=jIDVFFbI3xVHBLOMJw5feA4datzeW7C1VUA957BB4McD1saI48PXZFhIZZ8F++ds3W xDGZ8r9QPnwHctAkD5TPkh/iX0O8NitDghHxzzCRJn6VMh0J4uSOJeiragbs7ZnZlLsO 1jBNP8MQN6AWTx21h1a2FTEd3xSHlLNlesp9kegic6chxLwnYu3xbKZiQGBYom0g/AKN UrMCyBy9CBs7igN1wUWnMwp6/14c96sOHVt61xx0y88UZRa1glX02HJQr+jHMGfqTGDb SmO2x6uoGEc1H+u14UXoqAcgR6Xkc84N9YSswX2leeE9fQoycFqiEuGX2/pQDcLtKivc GrIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=tus7bxqL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x21si3983809ejc.141.2020.04.29.08.25.19; Wed, 29 Apr 2020 08:25:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=tus7bxqL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726808AbgD2PX1 (ORCPT + 99 others); Wed, 29 Apr 2020 11:23:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726539AbgD2PX1 (ORCPT ); Wed, 29 Apr 2020 11:23:27 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00E33C03C1AD for ; Wed, 29 Apr 2020 08:23:26 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id v4so5192062wme.1 for ; Wed, 29 Apr 2020 08:23:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ty18jkh7zkBHOD6czGW8SkI58aj/+4PBnyEc+GD/orI=; b=tus7bxqLbV6hNyOMoOR6rWwDXhsBMRK+6jioSAfK0KlwrSwSOr0fmUyBIRvGaBMJ3D J+JlxtgqA3bkzn5APaglpsmiIS6twFCJ3AGHR5NZDxsBKV4m7NcmKV4qvCZkCiCLHj0F wVoQWAC+k03amUFqge3cecu7wfI7kFyy9QCAe9F0i/n0P6dtZnLi+UdaSFW/3XXvzdXs TUbRmLQoCXCdOo1JndE/p4Fgcxzj2LoOcuMtDw1VvF15eL/AOqIuI98VYfVmRkbb39Db n62qJSCybrymus8vXGkZZxI/36eSFoxKIoJO96tDCyBieKuVk79quKpuUGc0iTWLojHU Mn8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ty18jkh7zkBHOD6czGW8SkI58aj/+4PBnyEc+GD/orI=; b=ruvvcOFE9l0IOt7IWGZYYlIpdcZYCyFWhr8j/tQ3Sfo7j8eHKvteA+WitK4d0rxcpU Ye2s4rGa+0LMOGcIeIRPVTXzZp67TPgzMw0gaq7TYk6FI+ldM8L94BVXwkY6592S6gAW CWppUGdeOlymrDWaS3P3OItzkkhn/Nmi2Ala5KZ7k5cuEcQ0j1tIbB/Hj0h8QR1zIr/V YC7upzQspig0XM80bCi+G165NS3mzCLsN/zxbvoOhuqlIbz/YAkjKu8aSFygpXXA9emt MimUsft2EPOhIM5F0ahceUmlRsgBMwUO7Z3HD6iJ2Byz/J7E/1PjEVUTe/XS1hhnkOwT hX8g== X-Gm-Message-State: AGi0PuYsqQdQKjofQs22udIBbRU1k1ERDE7H0HPjtEUvuxf9LMbbsTAl 1/9vsbSgr3SpIyUPaQE/9CXLkTCcAtVpavF1jsr62g== X-Received: by 2002:a7b:cc8e:: with SMTP id p14mr3795755wma.70.1588173804710; Wed, 29 Apr 2020 08:23:24 -0700 (PDT) MIME-Version: 1.0 References: <20200428063101.25556-1-yanaijie@huawei.com> In-Reply-To: <20200428063101.25556-1-yanaijie@huawei.com> From: Alex Deucher Date: Wed, 29 Apr 2020 11:23:13 -0400 Message-ID: Subject: Re: [PATCH] drm/amd/display: remove duplicate assignment of dcn21_funcs members To: Jason Yan Cc: "Wentland, Harry" , "Leo (Sunpeng) Li" , "Deucher, Alexander" , Christian Koenig , Chunming Zhou , Dave Airlie , Daniel Vetter , Anthony Koo , amd-gfx list , Maling list - DRI developers , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 28, 2020 at 8:46 AM Jason Yan wrote: > > Fix the following coccicheck warning: > > drivers/gpu/drm/amd/display/dc/dcn21/dcn21_init.c:31:51-52: > exit_optimized_pwr_state: first occurrence line 86, second occurrence > line 92 > drivers/gpu/drm/amd/display/dc/dcn21/dcn21_init.c:31:51-52: > optimize_pwr_state: first occurrence line 85, second occurrence line 91 > drivers/gpu/drm/amd/display/dc/dcn21/dcn21_init.c:31:51-52: > set_cursor_attribute: first occurrence line 71, second occurrence line > 89 > drivers/gpu/drm/amd/display/dc/dcn21/dcn21_init.c:31:51-52: > set_cursor_position: first occurrence line 70, second occurrence line 88 > drivers/gpu/drm/amd/display/dc/dcn21/dcn21_init.c:31:51-52: > set_cursor_sdr_white_level: first occurrence line 72, second occurrence > line 90 > > Signed-off-by: Jason Yan Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/display/dc/dcn21/dcn21_init.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_init.c b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_init.c > index 8410a6305a9a..fe64bcb49456 100644 > --- a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_init.c > +++ b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_init.c > @@ -85,11 +85,6 @@ static const struct hw_sequencer_funcs dcn21_funcs = { > .optimize_pwr_state = dcn21_optimize_pwr_state, > .exit_optimized_pwr_state = dcn21_exit_optimized_pwr_state, > .get_vupdate_offset_from_vsync = dcn10_get_vupdate_offset_from_vsync, > - .set_cursor_position = dcn10_set_cursor_position, > - .set_cursor_attribute = dcn10_set_cursor_attribute, > - .set_cursor_sdr_white_level = dcn10_set_cursor_sdr_white_level, > - .optimize_pwr_state = dcn21_optimize_pwr_state, > - .exit_optimized_pwr_state = dcn21_exit_optimized_pwr_state, > .power_down = dce110_power_down, > }; > > -- > 2.21.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel