Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp738791ybz; Wed, 29 Apr 2020 08:31:54 -0700 (PDT) X-Google-Smtp-Source: APiQypLMB4JcEJSVfhBWBwj51FJeEq6c4UHSmKnLpsaDxagoW69i2dxdkBKeXt6ObDEgBd8ujdg8 X-Received: by 2002:a17:906:dc02:: with SMTP id yy2mr3022833ejb.11.1588174314514; Wed, 29 Apr 2020 08:31:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588174314; cv=none; d=google.com; s=arc-20160816; b=OB0XgyH+BbAQx7/5YPTbzWK/hXsshZV299uwzj1WUkuVTamx69BFSpWiDSWsjaNpEK EBzP/fTIPYhsm8rRP0ZNTDd5KSYM6f5RC1Je5qLQj+MdLWX+BzdJjbpCFm9aQ+zJSkHZ +dB7NRsMIByT25ZRUl+/TRuQ6Z/pDH3KQDQGbRJBeYKVK+DNb07q/ssVH/2U6RCS62np ysA76nI1SpC51jquZm+m7rhr96T41+2W3STpD4WxSJHJY6ybqfQyumlL9Nf6pByZNyzC z/7t4ms0YCSVtUm7ZFV+7lvejRVklJTKuWzyLZ+nX8hJAVd9SdeE8JrJFqA0jSxrDhNK 4IIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject:reply-to:ironport-sdr :ironport-sdr; bh=/2OpvDuaH754Z0AHpS0iuS3ipbZy8b7+NBv9+UNmtvU=; b=idwYkirv7YPf8dIv+LMojuEq30CejzDcw1F0Cm6dZA66kK/RBaEniV03O/xJo6ECnJ UHPX98rBYnEdMB+3nPpahKLRNhDtky8NBsxSduHLWfHPOHz5zkUnLVmduCY6fnnexpxJ 52wFBCP0cawIYCsSELC6GiZ8/misW9IQuDPnw/bMjARXT3e6dCFh8gSQUgkzwh4viIxL S0VviXJ33SdAygqngsYF6S7FzR6aKtunwDNO8rGwEg7/pjSpKnP+tES1dA84zl1HImNw lyorrW4Cg/rATHpTfpOr/MmPPQoBkS5I61LltCxRZ6frp4KDk62VrVYc3+y0SkhQaV2O Dowg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l64si2574963ede.47.2020.04.29.08.31.30; Wed, 29 Apr 2020 08:31:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726580AbgD2P3g (ORCPT + 99 others); Wed, 29 Apr 2020 11:29:36 -0400 Received: from mga05.intel.com ([192.55.52.43]:51969 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726423AbgD2P3g (ORCPT ); Wed, 29 Apr 2020 11:29:36 -0400 IronPort-SDR: ZbHsZ18bGBlN0FU7L68dy+01UZi695KSWoDdpV/tyVtdLTRHUddhYxEWYJ+DgpxtZ5xnuRpwA7 o3w5WM+9kOWg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2020 08:29:35 -0700 IronPort-SDR: wHf8dhSjYq1ovl6/KJN6kiRcTLDiQ66kPnQ15/b7VAWrefT12q7R2zmrmTVy6hxv4qabvPobuF ghmfu4hGXVAw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,332,1583222400"; d="scan'208";a="432595853" Received: from linux.intel.com ([10.54.29.200]) by orsmga005.jf.intel.com with ESMTP; 29 Apr 2020 08:29:35 -0700 Received: from [10.255.166.42] (vramuthx-mobl1.gar.corp.intel.com [10.255.166.42]) by linux.intel.com (Postfix) with ESMTP id B2A905802C8; Wed, 29 Apr 2020 08:29:30 -0700 (PDT) Reply-To: vadivel.muruganx.ramuthevar@linux.intel.com Subject: Re: [PATCH v4 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC From: "Ramuthevar, Vadivel MuruganX" To: Boris Brezillon , qi-ming.wu@intel.com Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, cheol.yong.kim@intel.com, hauke.mehrtens@intel.com, anders.roxell@linaro.org, vigneshr@ti.com, arnd@arndb.de, richard@nod.at, brendanhiggins@google.com, linux-mips@vger.kernel.org, robh+dt@kernel.org, miquel.raynal@bootlin.com, tglx@linutronix.de, masonccyang@mxic.com.tw, andriy.shevchenko@intel.com References: <20200429104205.18780-1-vadivel.muruganx.ramuthevar@linux.intel.com> <20200429104205.18780-3-vadivel.muruganx.ramuthevar@linux.intel.com> <20200429162249.55d38ee8@collabora.com> <9d77c64c-d0f9-7a13-3391-d05bf458bdb1@linux.intel.com> <20200429164832.6800fc70@collabora.com> <2e83a2f7-853c-f0e2-f686-daf1e0649eae@linux.intel.com> Message-ID: Date: Wed, 29 Apr 2020 23:29:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <2e83a2f7-853c-f0e2-f686-daf1e0649eae@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris, On 29/4/2020 11:18 pm, Ramuthevar, Vadivel MuruganX wrote: > +    writel(lower_32_bits(ebu_host->cs[ebu_host->cs_num].nand_pa) | > +           EBU_ADDR_SEL_REGEN | EBU_ADDR_MASK, > +           ebu_host->ebu + EBU_ADDR_SEL(reg)); > + > +    writel(EBU_MEM_BASE_CS_0 | EBU_ADDR_MASK | EBU_ADDR_SEL_REGEN, > +           ebu_host->ebu + EBU_ADDR_SEL(0)); Good catch!, one will be removed , Thanks ! Regards Vadivel