Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp739632ybz; Wed, 29 Apr 2020 08:32:38 -0700 (PDT) X-Google-Smtp-Source: APiQypIczxzNRTklqgVIGCl/Tu/zI7+CYAkjrwOqXLMYgJSeVvKcrPapBAb3+XkBSZqTjZFqPoI6 X-Received: by 2002:a05:6402:28e:: with SMTP id l14mr2932530edv.184.1588174357830; Wed, 29 Apr 2020 08:32:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588174357; cv=none; d=google.com; s=arc-20160816; b=sbfqSrOBESkUAuDNhVyHdHPAIlDvcWBIj3HC1peKzkzB15XVEYB0Rl5Xn7nTs292Ix A3wQ3wOG1qHuoJvv85ljTamBmMK1i/voilEKNL2Wx/PhYBDz5qJSvcgNQm14H8UGUhUV 129VHhKMwH7pOhLscNqDXh24E1Fq+4ZCtABZjtmoGjVBuDaVY/aWxWvFd7j/05PCjRrX JZ3koS/7I5mB50kx/myqEr7oZDz0Dkd7lqD5V1IAtRnLcD0PwYGI5BZ9aTw152S89Kyx NUze1ZfjUy8rIzhv+cB6BsvJ/LV0uWvYAONWjk+G7beQvKQSKIb3SDAcqdfvQcR1SKQy y8tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=N9yPL5U8quFESl4Stw3OsG4QqTTqIkWJu59ukHEiK9k=; b=AgMJlABol74LhkexDw2bcX8RJv0ZdareH5KUIOMmlmdbePVMetAuTaOoAzRT1XXriJ QVs5sHORLjmQadZBut80noGdKOOCLmMJi8r5/xp99BBbcDc2/LAe9d3ekzRQo5uY4q67 GAIftf2LO/w7RtpNEaTFIOcnLGMBSc1voQSRKp/p8n3AqWwr+RgEg1tA0MwtWWOv0ngI rQasDtpvP9BOqqMNbqwt1LdznAkp/LFI0YMaYuFKr5/tOAgYrvW0+OwwBnN/UiwdY1Tb pNWhIWkbnTcwr2Lfcz5kRLj83XlZtQsg8YXb7Nx/78MODvv+pUEqaP/C7RDU51+ipIvT nFHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=whxuS1tB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m12si3955024edq.510.2020.04.29.08.32.11; Wed, 29 Apr 2020 08:32:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=whxuS1tB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727023AbgD2Pac (ORCPT + 99 others); Wed, 29 Apr 2020 11:30:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726937AbgD2Pac (ORCPT ); Wed, 29 Apr 2020 11:30:32 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A33B3C03C1AE for ; Wed, 29 Apr 2020 08:30:31 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id y24so2492783wma.4 for ; Wed, 29 Apr 2020 08:30:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=N9yPL5U8quFESl4Stw3OsG4QqTTqIkWJu59ukHEiK9k=; b=whxuS1tBIOGCXGKR4D9txfj0YrmvLOppPzKf133Orw2xrDFaxNC2NVAj2Yxms3Btjw NHvTheC/ne7068Zqc8rsMg+2BAga/XkLIMao16bcGyxemQ9q9tPqOjHk0EluqowWkXKP rm2JZAmN0vdwbkYiYGVNeiyAnsrCfqjEdvzEutsmoYC9XAyQMi2c6PjQHLansB11bjyF bAUz0LQ+Eq99vqYrtX7aMn19G5+Vdwv7XDOACYvKaODSQs9rSt0XJ86Th9EXer1tOHDZ ZX6Bc45zaPh7n7Ra92xD31RtoqDp7AyFTEGH76JSzCHwW70/ZSoSvsFSSJUMHHiKJ0T5 Qbkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=N9yPL5U8quFESl4Stw3OsG4QqTTqIkWJu59ukHEiK9k=; b=t0fgS+yB8MnZY6OXsVZd43jWBEMuj3v5/x4jVNr/dJBjeqPmxwiHqWXHlfGewTE6D6 YQjDNsXhPT/soeT2VDaQYC+a1Lsgg5ici0/vl30OifMAxpEWmS1yf463naRgzTEqPrIK 0VdulGl+IoPOSwTYaBGw36SKsiqVVA5jFkbI2F8qey1ub5Ox6je+gJIOC6Un5XDH3he5 GvWJi1OAy/Kl6zDP2H1NIKDBPwXgbMsyWMH6eQ7kKYfwoR9QPRhAUQkRpeTxL8QB3iju cZb4cXKWgXs/0MbBWoxGkO99UL10kxNrjELufj8ABy0mL/mP4+2xVTCyeZiZAHWMegAK QLgw== X-Gm-Message-State: AGi0PuaXUAmCrXHylqsmkh3UJKT2e+f3CK1ytXP7b01uDCGyYKsuNXfu iTEBO5Lh+Yq6jZNdqv61N25eglcL19Q= X-Received: by 2002:a05:600c:2314:: with SMTP id 20mr4090739wmo.118.1588174200388; Wed, 29 Apr 2020 08:30:00 -0700 (PDT) Received: from srini-hackbox.lan (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.gmail.com with ESMTPSA id l5sm7923729wmi.22.2020.04.29.08.29.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2020 08:29:59 -0700 (PDT) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, Srinivas Kandagatla Subject: [PATCH] misc: fastrpc: fix memory leak Date: Wed, 29 Apr 2020 16:29:51 +0100 Message-Id: <20200429152951.18504-1-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org if misc_register() fails, previously allocated data is left without freeing, this could result in memory leak. So fix it! Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index e3e085e33d46..9065d3e71ff7 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -1613,8 +1613,10 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev) domains[domain_id]); data->miscdev.fops = &fastrpc_fops; err = misc_register(&data->miscdev); - if (err) + if (err) { + kfree(data); return err; + } kref_init(&data->refcount); -- 2.21.0